Issues in SettingsPresenter.php (master) - Issues in master - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Issues (789)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/presenters/SettingsPresenter.php (18 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Presenters;

use App\Models\SettingsModel;
use App\Services\Emailer;
use Tracy\Debugger;

class SettingsPresenter extends BasePresenter
{

	/**
	 * @var Emailer
	 */
	private $emailer;

	/**
	 * @param SettingsModel $settingsModel
	 * @param Emailer       $emailer
	 */
	public function __construct(SettingsModel $settingsModel, Emailer $emailer)
	{
		$this->setModel($settingsModel);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$this->setEmailer($emailer);
	}

	/**
	 * @param 	string 	$id
	 * @return 	void
	 */
	public function actionUpdate($id)
	{
		try {
			$data = $this->getHttpRequest()->getPost();
			$this->getModel()->modifyMailJSON($id, $data['subject'], $data['message']);

			Debugger::log('Settings: mail type ' . $id . ' update succesfull.', Debugger::INFO);
			$this->flashMessage('Settings: mail type ' . $id . ' update succesfull.', 'ok');
		} catch(Exception $e) {

			Debugger::log('Settings: mail type ' . $id . ' update failed, result: ' . $e->getMessage(), Debugger::ERROR);
			$this->flashMessage('Settings: mail type ' . $id . ' update failed, result: ' . $e->getMessage(), 'error');
		}

		$this->redirect('Settings:listing');
	}

	/**
	 * @return 	void
	 */
	public function actionDebug()
	{
		try {
			$activate = false;
			$data = $this->getHttpRequest()->getPost();

			if(array_key_exists('debug', $data)) {
				$activate = true;
			}

			$this->getModel()->updateDebugRegime($activate);

			Debugger::log('Settings: debug regime update succesfull.', Debugger::INFO);
			$this->flashMessage('Settings: debug regime update succesfull.', 'ok');
		} catch(Exception $e) {

			Debugger::log('Settings: debug update update failed, result: ' . $e->getMessage(), Debugger::ERROR);
			$this->flashMessage('Settings: debug regime update failed, result: ' . $e->getMessage(), 'error');
		}

		$this->redirect('Settings:listing');
	}

	/**
	 * @param 	string 	$id
	 * @return 	void
	 */
	public function actionMail($id)
	{
		try {
			$recipient = $this->getHttpRequest()->getPost()['test-mail'];
			$jsonMail = $this->getModel()->getMailJSON($id);

			$this->getEmailer()
				->sendMail(
					[$recipient => ''],
					$jsonMail->subject,
					html_entity_decode($jsonMail->message)
				);

			Debugger::log('Settings: mail type ' . $id . ' succesfully send to recipient ' . $recipient, Debugger::INFO);
			$this->flashMessage('Settings: mail type ' . $id . ' succesfully send.', 'ok');
		} catch (Exception $e) {

			Debugger::log('Settings: mail type ' . $id . ' send to recipient ' . $recipient . ' failed, result: ' . $e->getMessage(), Debugger::ERROR);
			$this->flashMessage('Settings: mail type ' . $id . ' send to recipient failed, result: ' . $e->getMessage(), 'error');
		}

		$this->redirect('Settings:listing');
	}

	/**
	 * @return void
	 */
	public function renderListing()
	{
		$settingsModel = $this->getModel();
		$template = $this->getTemplate();
		$error = '';
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

		$template->payment_subject = $settingsModel->getMailJSON('cost')->subject;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->payment_message = $settingsModel->getMailJSON('cost')->message;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->payment_html_message = html_entity_decode($settingsModel->getMailJSON('cost')->message);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->advance_subject = $settingsModel->getMailJSON('advance')->subject;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->advance_message = $settingsModel->getMailJSON('advance')->message;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->advance_html_message = html_entity_decode($settingsModel->getMailJSON('advance')->message);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->tutor_subject = $settingsModel->getMailJSON('tutor')->subject;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->tutor_message = $settingsModel->getMailJSON('tutor')->message;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->tutor_html_message = html_entity_decode($settingsModel->getMailJSON('tutor')->message);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->reg_subject = $settingsModel->getMailJSON('post_reg')->subject;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->reg_message = $settingsModel->getMailJSON('post_reg')->message;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->reg_html_message = html_entity_decode($settingsModel->getMailJSON('post_reg')->message);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->debugRegime = $settingsModel->findDebugRegime();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
	}

	/**
	 * @return Emailer
	 */
	protected function getEmailer()
	{
		return $this->emailer;
	}

	/**
	 * @param  Emailer $emailer
	 * @return $this
	 */
	protected function setEmailer(Emailer $emailer)
	{
		$this->emailer = $emailer;
		return $this;
	}

}


1			<?php
2
3			namespace App\Presenters;
4
5			use App\Models\SettingsModel;
6			use App\Services\Emailer;
7			use Tracy\Debugger;
8
9			class SettingsPresenter extends BasePresenter
10			{
11
12			/**
13			* @var Emailer
14			*/
15			private $emailer;
16
17			/**
18			* @param SettingsModel $settingsModel
19			* @param Emailer $emailer
20			*/
21			public function __construct(SettingsModel $settingsModel, Emailer $emailer)
22			{
23			$this->setModel($settingsModel);
			0 ignored issues – show Documentation introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$settingsModel` is of type `object<App\Models\SettingsModel>`, but the function expects a `object<App\Model>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24			$this->setEmailer($emailer);
25			}
26
27			/**
28			* @param string $id
29			* @return void
30			*/
31			public function actionUpdate($id)
32			{
33			try {
34			$data = $this->getHttpRequest()->getPost();
35			$this->getModel()->modifyMailJSON($id, $data['subject'], $data['message']);
36
37			Debugger::log('Settings: mail type ' . $id . ' update succesfull.', Debugger::INFO);
38			$this->flashMessage('Settings: mail type ' . $id . ' update succesfull.', 'ok');
39			} catch(Exception $e) {
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `App\Presenters\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
40			Debugger::log('Settings: mail type ' . $id . ' update failed, result: ' . $e->getMessage(), Debugger::ERROR);
41			$this->flashMessage('Settings: mail type ' . $id . ' update failed, result: ' . $e->getMessage(), 'error');
42			}
43
44			$this->redirect('Settings:listing');
45			}
46
47			/**
48			* @return void
49			*/
50			public function actionDebug()
51			{
52			try {
53			$activate = false;
54			$data = $this->getHttpRequest()->getPost();
55
56			if(array_key_exists('debug', $data)) {
57			$activate = true;
58			}
59
60			$this->getModel()->updateDebugRegime($activate);
61
62			Debugger::log('Settings: debug regime update succesfull.', Debugger::INFO);
63			$this->flashMessage('Settings: debug regime update succesfull.', 'ok');
64			} catch(Exception $e) {
			0 ignored issues – show Bug introduced 2017-09-20 20:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `App\Presenters\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
65			Debugger::log('Settings: debug update update failed, result: ' . $e->getMessage(), Debugger::ERROR);
66			$this->flashMessage('Settings: debug regime update failed, result: ' . $e->getMessage(), 'error');
67			}
68
69			$this->redirect('Settings:listing');
70			}
71
72			/**
73			* @param string $id
74			* @return void
75			*/
76			public function actionMail($id)
77			{
78			try {
79			$recipient = $this->getHttpRequest()->getPost()['test-mail'];
80			$jsonMail = $this->getModel()->getMailJSON($id);
81
82			$this->getEmailer()
83			->sendMail(
84			[$recipient => ''],
85			$jsonMail->subject,
86			html_entity_decode($jsonMail->message)
87			);
88
89			Debugger::log('Settings: mail type ' . $id . ' succesfully send to recipient ' . $recipient, Debugger::INFO);
90			$this->flashMessage('Settings: mail type ' . $id . ' succesfully send.', 'ok');
91			} catch (Exception $e) {
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The class `App\Presenters\Exception` does not exist. Did you forget a USE statement, or did you not list all dependencies? Scrutinizer analyzes your `composer.json`/`composer.lock` file if available to determine the classes, and functions that are defined by your dependencies. It seems like the listed class was neither found in your dependencies, nor was it found in the analyzed files in your repository. If you are using some other form of dependency management, you might want to disable this analysis. Loading history...
92			Debugger::log('Settings: mail type ' . $id . ' send to recipient ' . $recipient . ' failed, result: ' . $e->getMessage(), Debugger::ERROR);
93			$this->flashMessage('Settings: mail type ' . $id . ' send to recipient failed, result: ' . $e->getMessage(), 'error');
94			}
95
96			$this->redirect('Settings:listing');
97			}
98
99			/**
100			* @return void
101			*/
102			public function renderListing()
103			{
104			$settingsModel = $this->getModel();
105			$template = $this->getTemplate();
106			$error = '';
			0 ignored issues – show Unused Code introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$error` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
107
108			$template->payment_subject = $settingsModel->getMailJSON('cost')->subject;
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `payment_subject` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
109			$template->payment_message = $settingsModel->getMailJSON('cost')->message;
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `payment_message` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
110			$template->payment_html_message = html_entity_decode($settingsModel->getMailJSON('cost')->message);
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `payment_html_message` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
111			$template->advance_subject = $settingsModel->getMailJSON('advance')->subject;
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `advance_subject` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
112			$template->advance_message = $settingsModel->getMailJSON('advance')->message;
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `advance_message` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
113			$template->advance_html_message = html_entity_decode($settingsModel->getMailJSON('advance')->message);
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `advance_html_message` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
114			$template->tutor_subject = $settingsModel->getMailJSON('tutor')->subject;
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `tutor_subject` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
115			$template->tutor_message = $settingsModel->getMailJSON('tutor')->message;
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `tutor_message` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
116			$template->tutor_html_message = html_entity_decode($settingsModel->getMailJSON('tutor')->message);
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `tutor_html_message` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
117			$template->reg_subject = $settingsModel->getMailJSON('post_reg')->subject;
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `reg_subject` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
118			$template->reg_message = $settingsModel->getMailJSON('post_reg')->message;
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `reg_message` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
119			$template->reg_html_message = html_entity_decode($settingsModel->getMailJSON('post_reg')->message);
			0 ignored issues – show Bug introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `reg_html_message` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
120			$template->debugRegime = $settingsModel->findDebugRegime();
			0 ignored issues – show Bug introduced 2017-09-20 20:18 UTC by Report Bug Copy Issue Report Show Similar Issues like this Accessing `debugRegime` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
121			}
122
123			/**
124			* @return Emailer
125			*/
126			protected function getEmailer()
127			{
128			return $this->emailer;
129			}
130
131			/**
132			* @param Emailer $emailer
133			* @return $this
134			*/
135			protected function setEmailer(Emailer $emailer)
136			{
137			$this->emailer = $emailer;
138			return $this;
139			}
140
141			}
142

literat / srazvs

Issues (789)

Security Analysis not enabled

app/presenters/SettingsPresenter.php (18 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like