Issues in SettingsModel.php (master) - Issues in master - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Issues (789)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

app/models/SettingsModel.php (2 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace App\Models;

use App\Models\BaseModel;
use Nette\Utils\Json;
use Nette\Database\Context;
use Tracy\Debugger;
use \Exception;

/**
 * Settings
 *
 * class for handling settings
 *
 * @created 2012-03-06
 * @author Tomas Litera <[email protected]>
 */
class SettingsModel extends BaseModel
{

	/** @var string */
	protected $table = 'kk_settings';

	/**
	 * @param Context $database
	 */
	public function __construct(Context $database)
	{
		$this->setDatabase($database);
	}

	/**
	 * @return	Nette\Database\Table\ActiveRow
	 */
	public function allOrFail()
	{
		$data = $this->all();

		if(!$data) {

			throw new Exception('Settings: no data found!');
		} else {
			return $data;
		}
	}

	/**
	 * Modify mail subject and message
	 *
	 * @param	string 	$subject 	e-mail subject
	 * @param	string	$message 	e-mail message
	 * @return	string 				error code
	 */
	public function modifyMailJSON($type, $subject, $message)
	{
		$mailData = [
			'subject' => $subject,
			'message' => $message
		];

		$result = $this->updateByName($mailData, 'mail_' . $type);

		if(!$result) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
			throw new Exception('Mail modification failed!');
		} else {
			return $result;
		}
	}

	/**
	 * @param  string $type
	 * @return object
	 */
	public function getMailJSON($type)
	{
		return $this->findByName('mail_' . $type);
	}

	/**
	 * @return ActiveRow
	 */
	public function all()
	{
		return $this->getDatabase()
			->table($this->getTable())
			->order('name')
			->fetchAll();
	}

	/**
	 * @param  string $name
	 * @return ActiveRow
	 */
	public function findByName($name)
	{
		$result = $this->getDatabase()
			->table($this->getTable())
			->where('name', $name)
			->fetch();

		return Json::decode($result->value);
	}

	/**
	 * @param  mixed  $value
	 * @param  string $name
	 * @return ActiveRow
	 */
	public function updateByName($value, $name)
	{
		return $this->getDatabase()
			->table($this->getTable())
			->where('name', $name)
			->update($this->encodeValue($value));
	}

	/**
	 * @param  mixed $data
	 * @return Row
	 */
	public function updateDebugRegime($data)
	{
		return $this->updateByName($data, 'debug');
	}

	/**
	 * @return bool
	 */
	public function findDebugRegime()
	{
		return (bool) $this->findByName('debug');
	}

	/**
	 * @param  mixed $value
	 * @return array
	 */
	protected function encodeValue($value): array
	{
		return [
			'value' => Json::encode($value)
		];
	}

}


1			<?php
2
3			namespace App\Models;
4
5			use App\Models\BaseModel;
6			use Nette\Utils\Json;
7			use Nette\Database\Context;
8			use Tracy\Debugger;
9			use \Exception;
10
11			/**
12			* Settings
13			*
14			* class for handling settings
15			*
16			* @created 2012-03-06
17			* @author Tomas Litera <[email protected]>
18			*/
19			class SettingsModel extends BaseModel
20			{
21
22			/** @var string */
23			protected $table = 'kk_settings';
24
25			/**
26			* @param Context $database
27			*/
28			public function __construct(Context $database)
29			{
30			$this->setDatabase($database);
31			}
32
33			/**
34			* @return Nette\Database\Table\ActiveRow
35			*/
36			public function allOrFail()
37			{
38			$data = $this->all();
39
40			if(!$data) {
			0 ignored issues – show Bug Best Practice introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$data` of type `Nette\Database\IRow[]` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history...
41			throw new Exception('Settings: no data found!');
42			} else {
43			return $data;
44			}
45			}
46
47			/**
48			* Modify mail subject and message
49			*
50			* @param string $subject e-mail subject
51			* @param string $message e-mail message
52			* @return string error code
53			*/
54			public function modifyMailJSON($type, $subject, $message)
55			{
56			$mailData = [
57			'subject' => $subject,
58			'message' => $message
59			];
60
61			$result = $this->updateByName($mailData, 'mail_' . $type);
62
63			if(!$result) {
			0 ignored issues – show Bug Best Practice introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report Show Similar Issues like this The expression `$result` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be zero. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
64			throw new Exception('Mail modification failed!');
65			} else {
66			return $result;
67			}
68			}
69
70			/**
71			* @param string $type
72			* @return object
73			*/
74			public function getMailJSON($type)
75			{
76			return $this->findByName('mail_' . $type);
77			}
78
79			/**
80			* @return ActiveRow
81			*/
82			public function all()
83			{
84			return $this->getDatabase()
85			->table($this->getTable())
86			->order('name')
87			->fetchAll();
88			}
89
90			/**
91			* @param string $name
92			* @return ActiveRow
93			*/
94			public function findByName($name)
95			{
96			$result = $this->getDatabase()
97			->table($this->getTable())
98			->where('name', $name)
99			->fetch();
100
101			return Json::decode($result->value);
102			}
103
104			/**
105			* @param mixed $value
106			* @param string $name
107			* @return ActiveRow
108			*/
109			public function updateByName($value, $name)
110			{
111			return $this->getDatabase()
112			->table($this->getTable())
113			->where('name', $name)
114			->update($this->encodeValue($value));
115			}
116
117			/**
118			* @param mixed $data
119			* @return Row
120			*/
121			public function updateDebugRegime($data)
122			{
123			return $this->updateByName($data, 'debug');
124			}
125
126			/**
127			* @return bool
128			*/
129			public function findDebugRegime()
130			{
131			return (bool) $this->findByName('debug');
132			}
133
134			/**
135			* @param mixed $value
136			* @return array
137			*/
138			protected function encodeValue($value): array
139			{
140			return [
141			'value' => Json::encode($value)
142			];
143			}
144
145			}
146

literat / srazvs

Issues (789)

Security Analysis not enabled

app/models/SettingsModel.php (2 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like