Completed
Push — master ( fea2cb...118c60 )
by Litera
21s
created

PublicBlockDetailControl   A

Complexity

Total Complexity 4

Size/Duplication

Total Lines 49
Duplicated Lines 100 %

Coupling/Cohesion

Components 1
Dependencies 3

Importance

Changes 0
Metric Value
dl 49
loc 49
rs 10
c 0
b 0
f 0
wmc 4
lcom 1
cbo 3

4 Methods

Rating   Name   Duplication   Size   Complexity  
A __construct() 4 4 1
A render() 7 7 1
A getBlockModel() 4 4 1
A setBlockModel() 6 6 1

How to fix   Duplicated Code   

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

1
<?php
2
3
namespace App\Components;
4
5
use App\Models\BlockModel;
6
7 View Code Duplication
class PublicBlockDetailControl extends BaseControl
0 ignored issues
show
Duplication introduced by
This class seems to be duplicated in your project.

Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation.

You can also find more detailed suggestions in the “Code” section of your repository.

Loading history...
8
{
9
10
	const TEMPLATE_NAME = 'PublicBlockDetail';
11
12
	/**
13
	 * @var BlockModel
14
	 */
15
	private $blockModel;
16
17
	/**
18
	 * @param BlockModel $model
19
	 */
20
	public function __construct(BlockModel $model)
21
	{
22
		$this->setBlockModel($model);
23
	}
24
25
	/**
26
	 * @return void
27
	 */
28
	public function render($blockId)
29
	{
30
		$template = $this->getTemplate();
31
		$template->setFile($this->buildTemplatePath());
32
		$template->block = $this->getBlockModel()->find($blockId);
0 ignored issues
show
Bug introduced by
Accessing block on the interface Nette\Application\UI\ITemplate suggest that you code against a concrete implementation. How about adding an instanceof check?

If you access a property on an interface, you most likely code against a concrete implementation of the interface.

Available Fixes

  1. Adding an additional type check:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeInterface $object) {
        if ($object instanceof SomeClass) {
            $a = $object->a;
        }
    }
    
  2. Changing the type hint:

    interface SomeInterface { }
    class SomeClass implements SomeInterface {
        public $a;
    }
    
    function someFunction(SomeClass $object) {
        $a = $object->a;
    }
    
Loading history...
33
		$template->render();
34
	}
35
36
	/**
37
	 * @return BlockModel
38
	 */
39
	protected function getBlockModel(): BlockModel
40
	{
41
		return $this->blockModel;
42
	}
43
44
	/**
45
	 * @param BlockModel $model
46
	 * @return self
47
	 */
48
	protected function setBlockModel(BlockModel $model): self
49
	{
50
		$this->blockModel = $model;
51
52
		return $this;
53
	}
54
55
}
56