RouterFactory - Code Metrics - Inspection of "Devel" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Pull Request — master (#125)

by Litera

created 2017-10-29 12:54 UTC

RouterFactory A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	32
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
dl	0
loc	32
rs	10
c	1
b	0
f	0
wmc	1
lcom	0
cbo	2

1 Method

Rating	Name	Duplication	Size	Complexity
B	createRouter()	0	24	1

<?php

namespace App\Routers;

use Nette,
	Nette\Application\Routers\RouteList,
	Nette\Application\Routers\Route,
	Nette\Application\Routers\SimpleRouter;


/**
 * Router factory.
 */
class RouterFactory
{

	/**
	 * @return \Nette\Application\IRouter
	 */
	public function createRouter()
	{
		$router = new RouteList();
		$router[] = new Route('', 'Dashboard:default', Route::ONE_WAY);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$router[] = new Route('index.php', 'Dashboard:default', Route::ONE_WAY);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$router[] = new Route('dashboard/', 'Dashboard:default');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$router[] = new Route('registrace/[<action>/[<guid>/]]', 'Registration:default', Route::ONE_WAY);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$router[] = new Route('registration/[<action>/[<guid>/]]', 'Registration:default');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$router[] = new Route('export/[<action>/[<type>/[<id>/]]]', 'Export:default');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$router[] = new Route('block/annotation/<guid>', [
			'presenter' => 'Annotation',
			'action'    => 'edit',
			'type'      => 'block',
		], Route::ONE_WAY);
		$router[] = new Route('program/annotation/<guid>', [
			'presenter' => 'Annotation',
			'action'    => 'edit',
			'type'      => 'program',
		], Route::ONE_WAY);
		$router[] = new Route('annotation/<action>/<type>/<guid>/', 'Annotation:default');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$router[] = new Route('<presenter>/[<action>/[<id>/]]', 'Dashboard:listing');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

		return $router;
	}

}


1			<?php
2
3			namespace App\Routers;
4
5			use Nette,
6			Nette\Application\Routers\RouteList,
7			Nette\Application\Routers\Route,
8			Nette\Application\Routers\SimpleRouter;
9
10
11			/**
12			* Router factory.
13			*/
14			class RouterFactory
15			{
16
17			/**
18			* @return \Nette\Application\IRouter
19			*/
20			public function createRouter()
21			{
22			$router = new RouteList();
23			$router[] = new Route('', 'Dashboard:default', Route::ONE_WAY);
			0 ignored issues – show Documentation introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report `'Dashboard:default'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
24			$router[] = new Route('index.php', 'Dashboard:default', Route::ONE_WAY);
			0 ignored issues – show Documentation introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report `'Dashboard:default'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
25			$router[] = new Route('dashboard/', 'Dashboard:default');
			0 ignored issues – show Documentation introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report `'Dashboard:default'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
26			$router[] = new Route('registrace/[<action>/[<guid>/]]', 'Registration:default', Route::ONE_WAY);
			0 ignored issues – show Documentation introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report `'Registration:default'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
27			$router[] = new Route('registration/[<action>/[<guid>/]]', 'Registration:default');
			0 ignored issues – show Documentation introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report `'Registration:default'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
28			$router[] = new Route('export/[<action>/[<type>/[<id>/]]]', 'Export:default');
			0 ignored issues – show Documentation introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report `'Export:default'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
29			$router[] = new Route('block/annotation/<guid>', [
30			'presenter' => 'Annotation',
31			'action' => 'edit',
32			'type' => 'block',
33			], Route::ONE_WAY);
34			$router[] = new Route('program/annotation/<guid>', [
35			'presenter' => 'Annotation',
36			'action' => 'edit',
37			'type' => 'program',
38			], Route::ONE_WAY);
39			$router[] = new Route('annotation/<action>/<type>/<guid>/', 'Annotation:default');
			0 ignored issues – show Documentation introduced 2017-10-29 13:03 UTC by Report Bug Copy Issue Report `'Annotation:default'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
40			$router[] = new Route('<presenter>/[<action>/[<id>/]]', 'Dashboard:listing');
			0 ignored issues – show Documentation introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report `'Dashboard:listing'` is of type `string`, but the function expects a `array`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
41
42			return $router;
43			}
44
45			}
46

literat / srazvs

Pull Request — master (#125)

RouterFactory A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

1 Method

Duplication Side-by-Side

Filter issues like