literat / srazvs

app/presenters/VisitorPresenter.php

Doc Comments +6 added lines, -6 removed lines

@@ -92,7 +92,7 @@ 
 	/**
 	 * Process data from form
 	 *
-	 * @return void
+	 * @return boolean
 	 */
 	public function actionCreate($visitor)
 	{
@@ -114,7 +114,7 @@ 
 	 * Process data from editing
 	 *
 	 * @param  integer 	$id
-	 * @return void
+	 * @return boolean
 	 */
 	public function actionUpdate($id, $visitor)
 	{
@@ -189,7 +189,7 @@ 
 	}
 
 	/**
-	 * @param  integer|string $ids
+	 * @param  integer|string $id
 	 * @return void
 	 */
 	public function actionPay($id)
@@ -218,7 +218,7 @@ 
 	}
 
 	/**
-	 * @param  string|interger $ids
+	 * @param  string|interger $id
 	 * @return void
 	 */
 	public function actionAdvance(int $id = null)
@@ -343,7 +343,7 @@ 
 	}
 
 	/**
-	 * @return VisitorFormControl
+	 * @return VisitorForm
 	 */
 	protected function createComponentVisitorForm(): VisitorForm
 	{
@@ -373,7 +373,7 @@ 
 	}
 
 	/**
-	 * @return Latte
+	 * @return \Nette\Application\UI\ITemplate
 	 */
 	protected function createMailTemplate()
 	{

Indentation +3 added lines, -3 removed lines

@@ -208,9 +208,9 @@
 			$this->flashSuccess('Platba byla zaplacena.');
 		} catch(Exception $e) {
 			$this->logError('Visitor: Action pay for id %s failed, result: %s', [
-			    json_encode($id),
-                $e->getMessage()
-            ]);
+				json_encode($id),
+				$e->getMessage()
+			]);
 			$this->flashFailure('Visitor: Action pay for id ' . $id . ' failed, result: ' . $e->getMessage());
 		}
 

Spacing +12 added lines, -12 removed lines

@@ -100,10 +100,10 @@ 
 			$guid = $this->getVisitorRepository()->create($visitor);
 			$result = $this->sendRegistrationSummary($visitor, $guid);
 
-			$this->logInfo('Creation of visitor('. $guid .') successfull, result: ' . json_encode($result));
+			$this->logInfo('Creation of visitor(' . $guid . ') successfull, result: ' . json_encode($result));
 			$this->flashSuccess('Účastník(' . $guid . ') byl úspěšně vytvořen.');
 		} catch(Exception $e) {
-			$this->logError('Creation of visitor('. $guid .') failed, result: ' .  $e->getMessage());
+			$this->logError('Creation of visitor(' . $guid . ') failed, result: ' . $e->getMessage());
 			$this->flashError('Creation of visitor failed, result: ' . $e->getMessage());
 		}
 
@@ -122,10 +122,10 @@ 
 			$result = $this->getVisitorRepository()->update($id, $visitor);
 			$result = $this->sendRegistrationSummary($visitor, $id);
 
-			$this->logInfo('Modification of visitor('. $id .') successfull, result: ' . json_encode($result));
+			$this->logInfo('Modification of visitor(' . $id . ') successfull, result: ' . json_encode($result));
 			$this->flashSuccess('Účastník(' . $id . ') byl úspěšně upraven.');
 		} catch(Exception $e) {
-			$this->logError('Modification of visitor('. $id .') failed, result: ' .  $e->getMessage());
+			$this->logError('Modification of visitor(' . $id . ') failed, result: ' . $e->getMessage());
 			$this->flashFailure('Modification of visitor failed, result: ' . $e->getMessage());
 			$result = false;
 		}
@@ -142,10 +142,10 @@ 
 		try {
 			$result = $this->getVisitorRepository()->delete($id);
 
-			$this->logInfo('Destroying of visitor('. $id .') successfull, result: ' . json_encode($result));
+			$this->logInfo('Destroying of visitor(' . $id . ') successfull, result: ' . json_encode($result));
 			$this->flashSuccess('Položka byla úspěšně smazána');
 		} catch(Exception $e) {
-			$this->logError('Destroying of visitor('. $id .') failed, result: ' .  $e->getMessage());
+			$this->logError('Destroying of visitor(' . $id . ') failed, result: ' . $e->getMessage());
 			$this->flashFailure('Destroying of visitor failed, result: ' . $e->getMessage());
 		}
 
@@ -181,7 +181,7 @@ 
 			$this->logInfo('E-mail was send successfully, result: ' . json_encode($result));
 			$this->flashSuccess('E-mail byl úspěšně odeslán');
 		} catch(Exception $e) {
-			$this->logError('Sending of e-mail failed, result: ' .  $e->getMessage());
+			$this->logError('Sending of e-mail failed, result: ' . $e->getMessage());
 			$this->flashFailure('Sending of e-mail failed, result: ' . $e->getMessage());
 		}
 
@@ -241,7 +241,7 @@ 
 					json_encode($id),
 					$e->getMessage(),
 				]);
-			$this->flashFailure('Zaplacení zálohy pro účastníka s id '.json_encode($id).' neprošlo: '.$e->getMessage());
+			$this->flashFailure('Zaplacení zálohy pro účastníka s id ' . json_encode($id) . ' neprošlo: ' . $e->getMessage());
 		}
 
 		$this->redirect(self::REDIRECT_DEFAULT);
@@ -257,10 +257,10 @@ 
 	{
 		try {
 			$result = $this->getVisitorRepository()->setChecked($id);
-			$this->logInfo('Check of visitor('. $id .') successfull, result: ' . json_encode($result));
+			$this->logInfo('Check of visitor(' . $id . ') successfull, result: ' . json_encode($result));
 			$this->flashSuccess('Položka byla úspěšně zkontrolována');
 		} catch(Exception $e) {
-			$this->logError('Check of visitor('. $id .') failed, result: ' .  $e->getMessage());
+			$this->logError('Check of visitor(' . $id . ') failed, result: ' . $e->getMessage());
 			$this->flashFailure('Check of visitor failed, result: ' . $e->getMessage());
 		}
 
@@ -277,10 +277,10 @@ 
 	{
 		try {
 			$result = $this->getVisitorRepository()->setUnchecked($id);
-			$this->logInfo('Uncheck of visitor('. $id .') successfull, result: ' . json_encode($result));
+			$this->logInfo('Uncheck of visitor(' . $id . ') successfull, result: ' . json_encode($result));
 			$this->flashSuccess('Položka byla nastavena jako nekontrolována');
 		} catch(Exception $e) {
-			$this->logError('Uncheck of visitor('. $id .') failed, result: ' .  $e->getMessage());
+			$this->logError('Uncheck of visitor(' . $id . ') failed, result: ' . $e->getMessage());
 			$this->flashFailure('Uncheck of visitor failed, result: ' . $e->getMessage());
 		}
 

app/repositories/ProgramRepository.php

Doc Comments +8 added lines, -8 removed lines

@@ -53,7 +53,7 @@ 
 
 	/**
 	 * @param  int  $id
-	 * @return Nette\Database\Table\ActiveRow
+	 * @return ActiveRow
 	 */
 	public function find(int $id): ActiveRow
 	{
@@ -80,7 +80,7 @@ 
 
 	/**
 	 * @param  int    $programId
-	 * @return array
+	 * @return ActiveRow
 	 */
 	public function findTutor(int $programId): ActiveRow
 	{
@@ -97,7 +97,7 @@ 
 	}
 
 	/**
-	 * @param  Nette\Utils\ArrayHash $program
+	 * @param  ArrayHash $program
 	 * @return boolean
 	 */
 	public function create(ArrayHash $program)
@@ -108,8 +108,8 @@ 
 	}
 
 	/**
-	 * @param  Nette\Utils\ArrayHash $program
-	 * @return boolean
+	 * @param  ArrayHash $program
+	 * @return integer|null
 	 */
 	public function update(int $id, ArrayHash $program)
 	{
@@ -120,7 +120,7 @@ 
 
 	/**
 	 * @param  int    $id
-	 * @return boolean
+	 * @return integer|null
 	 */
 	public function delete(int $id)
 	{
@@ -157,8 +157,8 @@ 
 	}
 
 	/**
-	 * @param  Nette\Utils\ArrayHash $program
-	 * @return Nette\Utils\ArrayHash
+	 * @param  ArrayHash $program
+	 * @return ArrayHash
 	 */
 	protected function transformDisplayInRegValue(ArrayHash $program): ArrayHash
 	{

Indentation +14 added lines, -14 removed lines

@@ -69,13 +69,13 @@ 
 		return $this->getProgramModel()->findByVisitorId($visitorId);
 	}
 
-    /**
-     * @param int $blockId
-     * @return array
-     */
-    public function findByBlockId(int $blockId): array
-    {
-        return $this->getProgramModel()->findByBlockId($blockId);
+	/**
+	 * @param int $blockId
+	 * @return array
+	 */
+	public function findByBlockId(int $blockId): array
+	{
+		return $this->getProgramModel()->findByBlockId($blockId);
 	}
 
 	/**
@@ -127,13 +127,13 @@ 
 		return $this->getProgramModel()->delete($id);
 	}
 
-    /**
-     * @param  int $programId
-     * @return int
-     */
-    public function countVisitors(int $programId): int
-    {
-        return $this->getProgramModel()->countProgramVisitors($programId);
+	/**
+	 * @param  int $programId
+	 * @return int
+	 */
+	public function countVisitors(int $programId): int
+	{
+		return $this->getProgramModel()->countProgramVisitors($programId);
 	}
 
 	/**

app/repositories/VisitorRepository.php

Doc Comments +4 added lines, -6 removed lines

@@ -174,7 +174,6 @@ 
 
 	/**
 	 * @param  integer $id
-	 * @param  array   $data
 	 * @return integer
 	 */
 	public function update($id, $values)
@@ -197,8 +196,7 @@ 
 	}
 
     /**
-     * @param  integer $id
-     * @param  array   $data
+     * @param string $guid
      * @return integer
      */
     public function updateByGuid($guid, $values)
@@ -223,7 +221,7 @@ 
 
 	/**
 	 * @param  integer $id
-	 * @return boolean
+	 * @return integer|null
 	 */
 	public function delete($id)
 	{
@@ -242,7 +240,7 @@ 
 
     /**
      * @param  int $id
-     * @return string
+     * @return integer|null
      * @throws \Exception
      */
 	public function payCostCharge($id)
@@ -252,7 +250,7 @@ 
 
     /**
      * @param  int $id
-     * @return string
+     * @return integer|null
      * @throws \Exception
      */
 	public function payAdvanceCharge($id)

Indentation +47 added lines, -47 removed lines

@@ -91,24 +91,24 @@ 
 		return $this->getVisitorModel()->find($id);
 	}
 
-    /**
-     * @param  int $id
-     * @return ArrayHash
-     */
-    public function findExpandedById(int $id): ArrayHash
-    {
-        $visitor = $this->findById($id);
-        $meals = $this->getMealModel()->findByVisitorId($id);
-        $programs = $this->assembleFormPrograms($id);
-
-        return ArrayHash::from(
-            array_merge(
-                $visitor->toArray(),
-                $meals,
-                $programs
-            )
-        );
-    }
+	/**
+	 * @param  int $id
+	 * @return ArrayHash
+	 */
+	public function findExpandedById(int $id): ArrayHash
+	{
+		$visitor = $this->findById($id);
+		$meals = $this->getMealModel()->findByVisitorId($id);
+		$programs = $this->assembleFormPrograms($id);
+
+		return ArrayHash::from(
+			array_merge(
+				$visitor->toArray(),
+				$meals,
+				$programs
+			)
+		);
+	}
 
 	/**
 	 * Return visitor by guid
@@ -196,30 +196,30 @@ 
 		return $id;
 	}
 
-    /**
-     * @param  integer $id
-     * @param  array   $data
-     * @return integer
-     */
-    public function updateByGuid($guid, $values)
-    {
-        $visitor = $this->filterFields($values, $this->getVisitorModel()->getColumns());
+	/**
+	 * @param  integer $id
+	 * @param  array   $data
+	 * @return integer
+	 */
+	public function updateByGuid($guid, $values)
+	{
+		$visitor = $this->filterFields($values, $this->getVisitorModel()->getColumns());
 
-        $visitor['birthday'] = $this->convertToDateTime($visitor['birthday']);
+		$visitor['birthday'] = $this->convertToDateTime($visitor['birthday']);
 
-        $visitor['code'] = $this->calculateCode4Bank(
-            $visitor['name'],
-            $visitor['surname'],
-            $visitor['birthday']->format('d. m. Y')
-        );
+		$visitor['code'] = $this->calculateCode4Bank(
+			$visitor['name'],
+			$visitor['surname'],
+			$visitor['birthday']->format('d. m. Y')
+		);
 
-        $meals = $this->filterFields($values, $this->getMealModel()->getColumns());
-        $programs = $this->filterProgramFields($values);
+		$meals = $this->filterFields($values, $this->getMealModel()->getColumns());
+		$programs = $this->filterProgramFields($values);
 
-        $guid = $this->getVisitorModel()->modifyByGuid($guid, $visitor, $meals, $programs);
+		$guid = $this->getVisitorModel()->modifyByGuid($guid, $visitor, $meals, $programs);
 
-        return $guid;
-    }
+		return $guid;
+	}
 
 	/**
 	 * @param  integer $id
@@ -240,21 +240,21 @@ 
 		return $this->getVisitorModel()->getCount();
 	}
 
-    /**
-     * @param  int $id
-     * @return string
-     * @throws \Exception
-     */
+	/**
+	 * @param  int $id
+	 * @return string
+	 * @throws \Exception
+	 */
 	public function payCostCharge($id)
 	{
 		return $this->getVisitorModel()->payCharge($id, 'cost');
 	}
 
-    /**
-     * @param  int $id
-     * @return string
-     * @throws \Exception
-     */
+	/**
+	 * @param  int $id
+	 * @return string
+	 * @throws \Exception
+	 */
 	public function payAdvanceCharge($id)
 	{
 		return $this->getVisitorModel()->payCharge($id, 'advance');

Spacing +2 added lines, -2 removed lines

@@ -283,7 +283,7 @@ 
 
 		$formPrograms = [];
 
-		foreach ($visitorPrograms as $visitorProgram) {
+		foreach($visitorPrograms as $visitorProgram) {
 			if($visitorProgram->program !== 0) {
 				$program = $this->getProgramRepository()->find($visitorProgram->program);
 				$formPrograms['blck_' . $program->block] = $visitorProgram->program;
@@ -328,7 +328,7 @@ 
 	 */
 	protected function convertToDateTime($datetime): DateTime
 	{
-		if (is_string($datetime)) {
+		if(is_string($datetime)) {
 			$datetime = new DateTime($datetime);
 		}
 

app/services/Emailer.php

Doc Comments +7 added lines, -3 removed lines

@@ -37,6 +37,7 @@ 
 	 * @param	string	subject
 	 * @param	string	message
 	 * @param	array	bcc
+	 * @param string $body
 	 * @return	bool	true | false (log the exception)
 	 */
 	public function sendMail($recipients, $subject, $body, array $bccMail = NULL)
@@ -97,7 +98,8 @@ 
 	 * @param	array	recipient mail and name
 	 * @param	string	guid
 	 * @param	string	program | block
-	 * @return	mixed	true | error information
+	 * @param string $type
+	 * @return	boolean	true | error information
 	 */
 	public function tutor($recipients, $guid, $type)
 	{
@@ -126,7 +128,8 @@ 
 	 * @param	array	recipient mail
 	 * @param	int		check hash code
 	 * @param	string	code for recognition of bank transaction
-	 * @return	mixed	true | error information
+	 * @param string $code4bank
+	 * @return	boolean	true | error information
 	 */
 	public function sendRegistrationSummary(array $recipientMail, $hash, $code4bank)
 	{
@@ -148,7 +151,8 @@ 
 	 *
 	 * @param	mixed	id numbers in row
 	 * @param	string	type of template
-	 * @return	array	subject and message
+	 * @param string $type
+	 * @return	boolean	subject and message
 	 */
 	public function sendPaymentInfo($recipients, $type)
 	{

Indentation +3 added lines, -3 removed lines

@@ -46,9 +46,9 @@
 
 		foreach($recipients as $recipient) {
 			$message->addTo(
-			    $recipient->email,
-                trim($recipient->name . ' ' . $recipient->surname)
-            );
+				$recipient->email,
+				trim($recipient->name . ' ' . $recipient->surname)
+			);
 		}
 		// add bcc
 		if(!empty($bccMail)) {

Upper-Lower-Casing +1 added lines, -1 removed lines

@@ -39,7 +39,7 @@
 	 * @param	array	bcc
 	 * @return	bool	true | false (log the exception)
 	 */
-	public function sendMail($recipients, $subject, $body, array $bccMail = NULL)
+	public function sendMail($recipients, $subject, $body, array $bccMail = null)
 	{
 		$message = new Message;
 		$message->setFrom('srazyvs@hkvs.cz', 'Srazy VS');

app/components/Forms/Factories/IVisitorFormFactory.php

Indentation +4 added lines, -4 removed lines

@@ -10,9 +10,9 @@
 interface IVisitorFormFactory
 {
 
-    /**
-     * @return \App\Components\Forms\VisitorForm
-     */
-    public function create(): VisitorForm;
+	/**
+	 * @return \App\Components\Forms\VisitorForm
+	 */
+	public function create(): VisitorForm;
 
 }

app/models/MealModel.php

Indentation +18 added lines, -18 removed lines

@@ -88,22 +88,22 @@ 
 			->update($data);
 	}
 
-    /**
-     * @param  int   $visitorId
-     * @param  array $values
-     * @return ActiveRow|bool
-     */
+	/**
+	 * @param  int   $visitorId
+	 * @param  array $values
+	 * @return ActiveRow|bool
+	 */
 	public function updateOrCreate(int $visitorId, array $values)
-    {
-        $result = $this->updateByVisitor($visitorId, $values);
+	{
+		$result = $this->updateByVisitor($visitorId, $values);
 
-        if(!$result) {
-            $values['visitor'] = $visitorId;
-            $result = $this->create($values);
-        }
+		if(!$result) {
+			$values['visitor'] = $visitorId;
+			$result = $this->create($values);
+		}
 
-        return $result;
-    }
+		return $result;
+	}
 
 	/**
 	 * Get meals data by visitor id
@@ -120,12 +120,12 @@ 
 			->fetch();
 
 		if(!$meals) {
-		    $meals = [];
-        } else {
-		    $meals = $meals->toArray();
-        }
+			$meals = [];
+		} else {
+			$meals = $meals->toArray();
+		}
 
-        return $meals;
+		return $meals;
 
 	}
 

Braces +1 added lines, -1 removed lines

@@ -94,7 +94,7 @@
      * @return ActiveRow|bool
      */
 	public function updateOrCreate(int $visitorId, array $values)
-    {
+	{
         $result = $this->updateByVisitor($visitorId, $values);
 
         if(!$result) {