ProgramRepository::assembleFormPrograms() - Code Metrics - Inspection of "Release v2.10.0" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 118c60...254398 )

by Litera

created 2017-12-30 07:59 UTC

ProgramRepository::assembleFormPrograms() A

↳ Parent: ProgramRepository

Complexity

Conditions	3
Paths	3

Size

Total Lines	15
Code Lines	8

Duplication

Lines	15
Ratio	100 %

Importance

Changes

Metric	Value
dl	15
loc	15
c	0
b	0
f	0
cc	3
eloc	8
nc	3
nop	1
rs	9.4285

<?php

namespace App\Repositories;

use App\Models\ProgramModel;
use App\Models\VisitorModel;
use Nette\Database\Table\ActiveRow;
use Nette\Utils\ArrayHash;

class ProgramRepository
{

	/**
	 * @var VisitorModel
	 */
	protected $visitorModel;

	/**
	 * @var ProgramModel
	 */
	protected $programModel;

	/**
	 * @param VisitorModel $visitorModel
	 * @param ProgramModel $programModel
	 */
	public function __construct(
		VisitorModel $visitorModel,
		ProgramModel $programModel
	) {
		$this->setVisitorModel($visitorModel);
		$this->setProgramModel($programModel);
	}

	/**
	 * @param int $meetingId
	 */
	public function setMeetingId(int $meetingId): self
	{
		$this->getProgramModel()->setMeetingId($meetingId);
		$this->getVisitorModel()->setMeetingId($meetingId);

		return $this;
	}

	/**
	 * @return array
	 */
	public function all(): array
	{
		return $this->getProgramModel()->all();
	}

	/**
	 * @param  int  $id
	 * @return Nette\Database\Table\ActiveRow
	 */
	public function find(int $id): ActiveRow
	{
		return $this->getProgramModel()->find($id);
	}

	/**
	 * @param  int  $visitorId
	 * @return array
	 */
	public function findByVisitorId(int $visitorId): array
	{
		return $this->getProgramModel()->findByVisitorId($visitorId);
	}

    /**
     * @param int $blockId
     * @return array
     */
    public function findByBlockId(int $blockId): array
    {
        return $this->getProgramModel()->findByBlockId($blockId);
	}

	/**
	 * @param  int    $programId
	 * @return array
	 */
	public function findTutor(int $programId): ActiveRow
	{
		return $this->getProgramModel()->getTutor($programId);
	}

	/**
	 * @param  int   $programId
	 * @return array
	 */
	public function findVisitors(int $programId): array
	{
		return $this->getProgramModel()->findProgramVisitors($programId);
	}

	/**
	 * @param  Nette\Utils\ArrayHash $program
	 * @return boolean
	 */
	public function create(ArrayHash $program)
	{
		$program = $this->transformDisplayInRegValue($program);

		return $this->getProgramModel()->create((array) $program);
	}

	/**
	 * @param  Nette\Utils\ArrayHash $program
	 * @return boolean
	 */
	public function update(int $id, ArrayHash $program)
	{
		$program = $this->transformDisplayInRegValue($program);

		return $this->getProgramModel()->update($id, (array) $program);
	}

	/**
	 * @param  int    $id
	 * @return boolean
	 */
	public function delete(int $id)
	{
		return $this->getProgramModel()->delete($id);
	}

    /**
     * @param  int $programId
     * @return int
     */
    public function countVisitors(int $programId): int
    {
        return $this->getProgramModel()->countProgramVisitors($programId);
	}

	/**
	 * @param  int    $visitorId
	 * @return array
	 */
	public function assembleFormPrograms(int $visitorId): array

	{
		$visitorPrograms = $this->getVisitorModel()->findVisitorPrograms($visitorId);

		$formPrograms = [];

		foreach ($visitorPrograms as $visitorProgram) {
			if($visitorProgram->program !== 0) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
				$program = $this->getProgramModel()->findByProgramId($visitorProgram->program);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
				$formPrograms['blck_' . $program->block] = $visitorProgram->program;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			}
		}

		return $formPrograms;
	}

	/**
	 * @param  Nette\Utils\ArrayHash $program
	 * @return Nette\Utils\ArrayHash
	 */
	protected function transformDisplayInRegValue(ArrayHash $program): ArrayHash
	{
		if(array_key_exists('display_in_reg', $program) && empty($program['display_in_reg'])) {
			$program['display_in_reg'] = '1';
		} else {
			$program['display_in_reg'] = '0';
		}

		return $program;
	}

	/**
	 * @return ProgramModel
	 */
	protected function getProgramModel()
	{
		return $this->programModel;
	}

	/**
	 * @param  ProgramModel $model
	 * @return $this
	 */
	protected function setProgramModel(ProgramModel $model): self
	{
		$this->programModel = $model;

		return $this;
	}

	/**
	 * @return VisitorModel
	 */
	protected function getVisitorModel(): VisitorModel
	{
		return $this->visitorModel;
	}

	/**
	 * @param  VisitorModel $model
	 * @return self
	 */
	protected function setVisitorModel(VisitorModel $model): self
	{
		$this->visitorModel = $model;

		return $this;
	}

}


Push — master ( 118c60...254398 )

ProgramRepository::assembleFormPrograms() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace App\Repositories;
4
5		use App\Models\ProgramModel;
6		use App\Models\VisitorModel;
7		use Nette\Database\Table\ActiveRow;
8		use Nette\Utils\ArrayHash;
9
10		class ProgramRepository
11		{
12
13		/**
14		* @var VisitorModel
15		*/
16		protected $visitorModel;
17
18		/**
19		* @var ProgramModel
20		*/
21		protected $programModel;
22
23		/**
24		* @param VisitorModel $visitorModel
25		* @param ProgramModel $programModel
26		*/
27		public function __construct(
28		VisitorModel $visitorModel,
29		ProgramModel $programModel
30		) {
31		$this->setVisitorModel($visitorModel);
32		$this->setProgramModel($programModel);
33		}
34
35		/**
36		* @param int $meetingId
37		*/
38		public function setMeetingId(int $meetingId): self
39		{
40		$this->getProgramModel()->setMeetingId($meetingId);
41		$this->getVisitorModel()->setMeetingId($meetingId);
42
43		return $this;
44		}
45
46		/**
47		* @return array
48		*/
49		public function all(): array
50		{
51		return $this->getProgramModel()->all();
52		}
53
54		/**
55		* @param int $id
56		* @return Nette\Database\Table\ActiveRow
57		*/
58		public function find(int $id): ActiveRow
59		{
60		return $this->getProgramModel()->find($id);
61		}
62
63		/**
64		* @param int $visitorId
65		* @return array
66		*/
67		public function findByVisitorId(int $visitorId): array
68		{
69		return $this->getProgramModel()->findByVisitorId($visitorId);
70		}
71
72		/**
73		* @param int $blockId
74		* @return array
75		*/
76		public function findByBlockId(int $blockId): array
77		{
78		return $this->getProgramModel()->findByBlockId($blockId);
79		}
80
81		/**
82		* @param int $programId
83		* @return array
84		*/
85		public function findTutor(int $programId): ActiveRow
86		{
87		return $this->getProgramModel()->getTutor($programId);
88		}
89
90		/**
91		* @param int $programId
92		* @return array
93		*/
94		public function findVisitors(int $programId): array
95		{
96		return $this->getProgramModel()->findProgramVisitors($programId);
97		}
98
99		/**
100		* @param Nette\Utils\ArrayHash $program
101		* @return boolean
102		*/
103		public function create(ArrayHash $program)
104		{
105		$program = $this->transformDisplayInRegValue($program);
106
107		return $this->getProgramModel()->create((array) $program);
108		}
109
110		/**
111		* @param Nette\Utils\ArrayHash $program
112		* @return boolean
113		*/
114		public function update(int $id, ArrayHash $program)
115		{
116		$program = $this->transformDisplayInRegValue($program);
117
118		return $this->getProgramModel()->update($id, (array) $program);
119		}
120
121		/**
122		* @param int $id
123		* @return boolean
124		*/
125		public function delete(int $id)
126		{
127		return $this->getProgramModel()->delete($id);
128		}
129
130		/**
131		* @param int $programId
132		* @return int
133		*/
134		public function countVisitors(int $programId): int
135		{
136		return $this->getProgramModel()->countProgramVisitors($programId);
137		}
138
139		/**
140		* @param int $visitorId
141		* @return array
142		*/
143	View Code Duplication	public function assembleFormPrograms(int $visitorId): array
		0 ignored issues – show Duplication introduced 2017-12-15 10:30 UTC Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
144		{
145		$visitorPrograms = $this->getVisitorModel()->findVisitorPrograms($visitorId);
146
147		$formPrograms = [];
148
149		foreach ($visitorPrograms as $visitorProgram) {
150		if($visitorProgram->program !== 0) {
		0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC Report Bug Copy Issue Report Accessing `program` on the interface `Nette\Database\IRow` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
151		$program = $this->getProgramModel()->findByProgramId($visitorProgram->program);
		0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC Report Bug Copy Issue Report Accessing `program` on the interface `Nette\Database\IRow` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history... Documentation Bug introduced 2017-12-26 16:53 UTC Report Bug Copy Issue Report The method `findByProgramId` does not exist on `object<App\Models\ProgramModel>`? Since you implemented `__call`, maybe consider adding a @method annotation. If you implement `__call` and you know which methods are available, you can improve IDE auto-completion and static analysis by adding a @method annotation to the class. This is often the case, when `__call` is implemented by a parent class and only the child class knows which methods exist: class ParentClass { private $data = array(); public function __call($method, array $args) { if (0 === strpos($method, 'get')) { return $this->data[strtolower(substr($method, 3))]; } throw new \LogicException(sprintf('Unsupported method: %s', $method)); } } /** * If this class knows which fields exist, you can specify the methods here: * * @method string getName() */ class SomeClass extends ParentClass { } Loading history...
152		$formPrograms['blck_' . $program->block] = $visitorProgram->program;
		0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC Report Bug Copy Issue Report Accessing `program` on the interface `Nette\Database\IRow` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
153		}
154		}
155
156		return $formPrograms;
157		}
158
159		/**
160		* @param Nette\Utils\ArrayHash $program
161		* @return Nette\Utils\ArrayHash
162		*/
163		protected function transformDisplayInRegValue(ArrayHash $program): ArrayHash
164		{
165		if(array_key_exists('display_in_reg', $program) && empty($program['display_in_reg'])) {
166		$program['display_in_reg'] = '1';
167		} else {
168		$program['display_in_reg'] = '0';
169		}
170
171		return $program;
172		}
173
174		/**
175		* @return ProgramModel
176		*/
177		protected function getProgramModel()
178		{
179		return $this->programModel;
180		}
181
182		/**
183		* @param ProgramModel $model
184		* @return $this
185		*/
186		protected function setProgramModel(ProgramModel $model): self
187		{
188		$this->programModel = $model;
189
190		return $this;
191		}
192
193		/**
194		* @return VisitorModel
195		*/
196		protected function getVisitorModel(): VisitorModel
197		{
198		return $this->visitorModel;
199		}
200
201		/**
202		* @param VisitorModel $model
203		* @return self
204		*/
205		protected function setVisitorModel(VisitorModel $model): self
206		{
207		$this->visitorModel = $model;
208
209		return $this;
210		}
211
212		}
213

literat / srazvs

Push — master ( 118c60...254398 )

ProgramRepository::assembleFormPrograms() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like