ProgramVisitorsControl - Code Metrics - Inspection of "Release v2.10.0" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 118c60...254398 )

by Litera

created 2017-12-30 07:59 UTC

ProgramVisitorsControl A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	53
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes

Metric	Value
dl	0
loc	53
c	0
b	0
f	0
rs	10
wmc	4
lcom	1
cbo	3

4 Methods

Rating	Name	Size	Complexity
A	__construct()	4	1
A	render()	9	1
A	getProgramRepository()	4	1
A	setProgramRepository()	6	1

<?php

namespace App\Components;

use App\Repositories\ProgramRepository;

class ProgramVisitorsControl extends BaseControl
{

	const TEMPLATE_NAME = 'ProgramVisitors';

	/**
	 * @var ProgramRepository
	 */
	private $programRepository;

	/**
	 * @param ProgramRepository $repository
	 */
	public function __construct(ProgramRepository $repository)
	{
		$this->setProgramRepository($repository);
	}

	/**
	 * @param  string $mealColumn
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @param  string $mealName
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return void
	 */
	public function render(int $programId)
	{
		$template = $this->getTemplate();
		$template->setFile($this->buildTemplatePath());
		$template->imgDir = IMG_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->programId = $programId;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->visitors = $this->getProgramRepository()->findVisitors($programId);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->render();
	}

	/**
	 * @return ProgramRepository
	 */
	protected function getProgramRepository(): ProgramRepository
	{
		return $this->programRepository;
	}

	/**
	 * @param  ProgramRepository $repository
	 * @return self
	 */
	protected function setProgramRepository(ProgramRepository $repository): self
	{
		$this->programRepository = $repository;

		return $this;
	}

}


Push — master ( 118c60...254398 )

ProgramVisitorsControl A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Components;
4
5			use App\Repositories\ProgramRepository;
6
7			class ProgramVisitorsControl extends BaseControl
8			{
9
10			const TEMPLATE_NAME = 'ProgramVisitors';
11
12			/**
13			* @var ProgramRepository
14			*/
15			private $programRepository;
16
17			/**
18			* @param ProgramRepository $repository
19			*/
20			public function __construct(ProgramRepository $repository)
21			{
22			$this->setProgramRepository($repository);
23			}
24
25			/**
26			* @param string $mealColumn
			0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC by Report Bug Copy Issue Report There is no parameter named `$mealColumn`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
27			* @param string $mealName
			0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC by Report Bug Copy Issue Report There is no parameter named `$mealName`. Was it maybe removed? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. Consider the following example. The parameter `$italy` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $island * @param array $italy */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was removed, but the annotation was not. Loading history...
28			* @return void
29			*/
30			public function render(int $programId)
31			{
32			$template = $this->getTemplate();
33			$template->setFile($this->buildTemplatePath());
34			$template->imgDir = IMG_DIR;
			0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC by Report Bug Copy Issue Report Accessing `imgDir` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
35			$template->programId = $programId;
			0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC by Report Bug Copy Issue Report Accessing `programId` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
36			$template->visitors = $this->getProgramRepository()->findVisitors($programId);
			0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC by Report Bug Copy Issue Report Accessing `visitors` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
37			$template->render();
38			}
39
40			/**
41			* @return ProgramRepository
42			*/
43			protected function getProgramRepository(): ProgramRepository
44			{
45			return $this->programRepository;
46			}
47
48			/**
49			* @param ProgramRepository $repository
50			* @return self
51			*/
52			protected function setProgramRepository(ProgramRepository $repository): self
53			{
54			$this->programRepository = $repository;
55
56			return $this;
57			}
58
59			}
60

literat / srazvs

Push — master ( 118c60...254398 )

ProgramVisitorsControl A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like