VisitorForm - Code Metrics - Inspection of "Release v2.10.0" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 118c60...254398 )

by Litera

created 2017-12-30 07:59 UTC

VisitorForm B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	464
Duplicated Lines	2.37 %

Coupling/Cohesion

Components	1
Dependencies	15

Importance

Changes

Metric	Value
dl	11
loc	464
c	0
b	0
f	0
rs	8.4332
wmc	34
lcom	1
cbo	15

27 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	1
A	render()	0	11	1
A	setDefaults()	0	6	1
B	createComponentVisitorForm()	0	96	1
A	processSave()	0	6	1
A	processReset()	0	6	1
B	buildProgramSwitcher()	0	26	3
A	buildMealSwitcher()	0	14	2
A	getProvinceModel()	0	4	1
A	setProvinceModel()	0	6	1
A	getProgramRepository()	0	4	1
A	setProgramRepository()	0	6	1
A	getBlockModel()	0	4	1
A	setBlockModel()	0	6	1
A	getMeetingModel()	0	4	1
A	setMeetingModel()	0	6	1
A	getMealFields()	0	4	1
A	setMealField()	0	8	2
A	getProgramFields()	0	4	1
A	setProgramField()	0	6	1
A	setProgramFields()	0	11	2
A	setMealFields()	0	10	2
A	fetchProgramBlocks()	0	4	1
A	fetchMeals()	0	4	1
A	getUserService()	0	4	1
A	setUserService()	0	6	1
A	filterFilledCapacity()	0	13	2

How to fix Duplicated Code

<?php

namespace App\Components\Forms;

use App\Repositories\ProgramRepository;
use App\Models\ProvinceModel;
use App\Models\BlockModel;
use App\Models\MealModel;
use App\Models\MeetingModel;
use Nette\Application\UI\Form;
use App\Services\SkautIS\UserService;
use Nette\Forms\Controls\SubmitButton;
use Nette\Utils\ArrayHash;

class VisitorForm extends BaseForm
{

	const TEMPLATE_NAME = 'VisitorForm';

	const MESSAGE_REQUIRED = 'Hodnota musí být vyplněna!';
	const MESSAGE_MAX_LENGTH = '%label nesmí mít více jak %d znaků!';

	/**
	 * @var Closure
	 */
	public $onVisitorSave;

    /**
     * @var Closure
     */
    public $onVisitorReset;

	/**
	 * @var ProvinceModel
	 */
	protected $provinceModel;

	/**
	 * @var ProgramRepository
	 */
	protected $programRepository;

	/**
	 * @var BlockModel
	 */
	protected $blockModel;

	/**
	 * @var  MeetingModel
	 */
	protected $meetingModel;

	/**
	 * @var array
	 */
	protected $mealFields = [];

	/**
	 * @var array
	 */
	protected $programFields = [];

    /**
     * VisitorForm constructor.
     * @param ProvinceModel     $province
     * @param ProgramRepository $program
     * @param BlockModel        $block
     * @param MeetingModel      $meeting
     */
	public function __construct(

		ProvinceModel $province,
		ProgramRepository $program,
		BlockModel $block,
		MeetingModel $meeting
	) {
		$this->setProvinceModel($province);
		$this->setProgramRepository($program);
		$this->setBlockModel($block);
		$this->setMeetingModel($meeting);
	}

	/**
	 * @return void
	 */
	public function render()
	{
		$this->setMealFields();
		$this->setProgramFields();

		$template = $this->getTemplate();
		$template->setFile($this->buildTemplatePath());
		$template->meals = $this->getMealFields();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->programs = $this->getProgramFields();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->render();
	}

	/**
	 * @param  array|ArrayHash $defaults
	 * @return self
	 */
	public function setDefaults($defaults): BaseForm
	{
		$this['visitorForm']->setDefaults($defaults);

		return $this;
	}

	/**
	 * @return Form
	 */
	public function createComponentVisitorForm(): Form
	{
		$provinces = $this->getProvinceModel()->all();

		$form = new Form;

		$form->addText('name', 'Jméno:', 30)
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addRule(Form::MAX_LENGTH, static::MESSAGE_MAX_LENGTH, 20)
			->getLabelPrototype()->setAttribute('class', 'required');
		$form->addText('surname', 'Příjmení:', 30)
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addRule(Form::MAX_LENGTH, static::MESSAGE_MAX_LENGTH, 30)
			->getLabelPrototype()->setAttribute('class', 'required');
		$form->addText('nick', 'Přezdívka:', 30)
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addRule(Form::MAX_LENGTH, static::MESSAGE_MAX_LENGTH, 20)
			->getLabelPrototype()->setAttribute('class', 'required');
		$form->addEmail('email', 'E-mail:')
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->setAttribute('size', 30)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->getLabelPrototype()->setAttribute('class', 'required');
        $form->addTbDatePicker('birthday', 'Datum narození:', null, 16)
            ->setRequired(static::MESSAGE_REQUIRED)
            ->setFormat('d.m.Y')
            ->setAttribute('placeholder', 'dd. mm. rrrr')
            ->setAttribute('id', 'birthday')
            ->setAttribute('class', 'datePicker')
            ->getLabelPrototype()->setAttribute('class', 'required');
		$form->addText('street', 'Ulice:', 30)
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addRule(Form::MAX_LENGTH, static::MESSAGE_MAX_LENGTH, 30)
			->getLabelPrototype()->setAttribute('class', 'required');
		$form->addText('city', 'Město:', 30)
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addRule(Form::MAX_LENGTH, static::MESSAGE_MAX_LENGTH, 64)
			->getLabelPrototype()->setAttribute('class', 'required');
		$form->addText('postal_code', 'PSČ:', 30)
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addRule(Form::PATTERN, 'Číslo musí být ve formátu nnnnn!', '[1-9]{1}[0-9]{4}')
			->setAttribute('placeholder', '12345')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->getLabelPrototype()->setAttribute('class', 'required');
		$form->addText('group_num', 'Číslo středika/přístavu:', 30)
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addRule(Form::PATTERN, 'Číslo musí být ve formátu nnn.nn!', '[1-9]{1}[0-9a-zA-Z]{2}\.[0-9a-zA-Z]{1}[0-9a-zA-Z]{1}')
			->setAttribute('placeholder', '214.02')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->getLabelPrototype()->setAttribute('class', 'required');
		$form->addText('group_name', 'Název střediska/přístavu:', 30)
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addRule(Form::MAX_LENGTH, static::MESSAGE_MAX_LENGTH, 50)
			->setAttribute('placeholder', '2. přístav Poutníci Kolín')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->getLabelPrototype()->setAttribute('class', 'required');
		$form->addText('troop_name', 'Název oddílu:', 30)
			->setAttribute('placeholder', '22. oddíl Galeje')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addCondition(Form::FILLED, true)
				->addRule(Form::MAX_LENGTH, static::MESSAGE_MAX_LENGTH, 50);

		$form->addSelect('province', 'Kraj:', $provinces)
			->setPrompt('zvolte kraj');

		$form = $this->buildMealSwitcher($form);

		$form->addTextArea('arrival', 'Informace o příjezdu:', 50, 3)
			->setAttribute('placeholder', 'Napište, prosím, stručně jakým dopravním prostředkem a v kolik hodin (přibližně) přijedete na místo srazu.');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$form->addTextArea('departure', 'Informace o odjezdu:', 50, 3)
			->setAttribute('placeholder', 'Napište, prosím, stručně jakým dopravním prostředkem a v kolik hodin (přibližně) sraz opustíte.');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$form->addTextArea('comment', 'Dotazy, přání, připomínky, stížnosti:', 50, 8);
		$form->addTextArea('question', 'Vaše nabídka:', 50, 8)
			->setAttribute('placeholder', 'Vaše nabídka na sdílení dobré praxe (co u vás umíte dobře a jste ochotni se o to podělit)');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$form->addTextArea('question2', 'Počet a typy lodí:', 50, 8)
			->setAttribute('placeholder', 'Počet a typy lodí, které sebou přivezete (vyplňte pokud ano)');
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $form->addText('bill', 'Zaplaceno:', 30)
            ->setDefaultValue(0);
        $form->addText('cost', 'Poplatek:', 30)
            ->setDefaultValue($this->getMeetingModel()->getPrice('cost'));

		$form = $this->buildProgramSwitcher($form);

		$form->addHidden('mid', $this->getMeetingId());
        $form->addHidden('meeting', $this->getMeetingId());
		$form->addHidden('backlink');

        $form->addSubmit('save', 'Uložit')
            ->setAttribute('class', 'btn-primary')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->onClick[] = [$this, 'processSave'];
        $form->addSubmit('reset', 'Storno')
            ->setAttribute('class', 'btn-reset')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            ->onClick[] = [$this, 'processReset'];


        $form = $this->setupRendering($form);

		$form->onSuccess[] = [$this, 'processForm'];

		return $form;
	}

    /**
     * @param  SubmitButton $button
     * @return void
     */
    public function processSave(SubmitButton $button)
    {
        $visitor = $button->getForm()->getValues();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->onVisitorSave($this, $visitor);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

    /**
     * @param  SubmitButton $button
     * @return void
     */
    public function processReset(SubmitButton $button)
    {
        $visitor = $button->getForm()->getValues();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

        $this->onVisitorReset($this, $visitor);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
    }

	/**
	 * @param  Form   $form
	 * @return Form
	 */
	protected function buildProgramSwitcher(Form $form): Form
	{
		$programBlocks = $this->fetchProgramBlocks();

		foreach ($programBlocks as $block) {

			$programsInBlock = $this->getProgramRepository()->findByBlockId($block->id);

			$programs = [
				0 => 'Nebudu přítomen'
			];

			foreach ($programsInBlock as $program) {
				$programs[$program->id] = $program->name;
			}

			$form->addRadioList(
				'blck_' . $block->id,
				$block->day . ', ' . $block->from .' - ' . $block->to .' : ' . $block->name,
				$programs
			)->setDefaultValue(0)
			->setDisabled($this->filterFilledCapacity($programs));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		}

		return $form;
	}

	/**
	 * @param  Form   $form
	 * @return Form
	 */
	protected function buildMealSwitcher(Form $form): Form
	{
		$yesNoArray = [
			'ne'  => 'ne',
			'ano' => 'ano',
		];

		foreach ($this->fetchMeals() as $name => $label) {
			$this->setMealField($name);
			$form->addSelect($name, $label . ':', $yesNoArray);
		}

		return $form;
	}

	/**
	 * @return ProvinceModel
	 */
	protected function getProvinceModel(): ProvinceModel
	{
		return $this->provinceModel;
	}

	/**
	 * @param  ProvinceModel $model
	 * @return self
	 */
	protected function setProvinceModel(ProvinceModel $model): self
	{
		$this->provinceModel = $model;

		return $this;
	}

	/**
	 * @return ProgramRepository
	 */
	protected function getProgramRepository(): ProgramRepository
	{
		return $this->programRepository;
	}

	/**
	 * @param  ProgramRepository $repository
	 * @return self
	 */
	protected function setProgramRepository(ProgramRepository $repository): self
	{
		$this->programRepository = $repository;

		return $this;
	}

	/**
	 * @return BlockModel
	 */
	protected function getBlockModel(): BlockModel
	{
		return $this->blockModel;
	}

	/**
	 * @param  BlockModel $model
	 * @return self
	 */
	protected function setBlockModel(BlockModel $model): self
	{
		$this->blockModel = $model;

		return $this;
	}

	/**
	 * @return MeetingModel
	 */
	protected function getMeetingModel(): MeetingModel
	{
		return $this->meetingModel;
	}

	/**
	 * @param  MeetingModel $model
	 * @return VisitorForm
	 */
	protected function setMeetingModel(MeetingModel $model): VisitorForm
	{
		$this->meetingModel = $model;

		return $this;
	}

	/**
	 * @return array
	 */
	protected function getMealFields(): array
	{
		return $this->mealFields;
	}

	/**
	 * @param  string $meal
	 * @return self
	 */
	protected function setMealField(string $meal): self
	{
		if(!in_array($meal, $this->mealFields)) {
			$this->mealFields[] = $meal;
		}

		return $this;
	}

	/**
	 * @return array
	 */
	protected function getProgramFields(): array
	{
		return $this->programFields;
	}

	/**
	 * @param  string $program
	 * @return self
	 */
	protected function setProgramField(string $program): self
	{
		$this->programFields[] = $program;

		return $this;
	}

	/**
	 * @return self
	 */
	protected function setProgramFields(): self
	{
		$programBlocks = $this->fetchProgramBlocks();

		foreach ($programBlocks as $block) {
			$programFieldName = 'blck_' . $block->id;
			$this->setProgramField($programFieldName);
		}

		return $this;
	}

	/**
	 * @return  self
	 */
	protected function setMealFields(): self
	{
		$meals = $this->fetchMeals();

		foreach ($meals as $name => $label) {
			$this->setMealField($name);
		}

		return $this;
	}

	/**
	 * @return Row
	 */
	protected function fetchProgramBlocks()
	{
		return $this->getBlockModel()->getProgramBlocks($this->getMeetingId());
	}

	/**
	 * @return array
	 */
	protected function fetchMeals()
	{
		return MealModel::$meals;
	}

	/**
	 * @return UserService
	 */
	protected function getUserService()
	{
		return $this->userService;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}

	/**
	 * @param  UserService $service
	 * @return $this
	 */
	protected function setUserService(UserService $service)
	{
		$this->userService = $service;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}

		return $this;
	}

	/**
	 * @param  array  $programs
	 * @return array
	 */
	protected function filterFilledCapacity(array $programs = []): array
	{
		return array_keys(
			array_filter($programs, function($name, $id) {
				if ($id) {
					$visitorsOnProgram = $this->getProgramRepository()->countVisitors($id);
					$programCapacity = $this->getProgramRepository()->find($id)->capacity;

					return $visitorsOnProgram >= $programCapacity;
				}
			}, ARRAY_FILTER_USE_BOTH)
		);
	}

}


Push — master ( 118c60...254398 )

VisitorForm B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

27 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Components\Forms;
4
5			use App\Repositories\ProgramRepository;
6			use App\Models\ProvinceModel;
7			use App\Models\BlockModel;
8			use App\Models\MealModel;
9			use App\Models\MeetingModel;
10			use Nette\Application\UI\Form;
11			use App\Services\SkautIS\UserService;
12			use Nette\Forms\Controls\SubmitButton;
13			use Nette\Utils\ArrayHash;
14
15			class VisitorForm extends BaseForm
16			{
17
18			const TEMPLATE_NAME = 'VisitorForm';
19
20			const MESSAGE_REQUIRED = 'Hodnota musí být vyplněna!';
21			const MESSAGE_MAX_LENGTH = '%label nesmí mít více jak %d znaků!';
22
23			/**
24			* @var Closure
25			*/
26			public $onVisitorSave;
27
28			/**
29			* @var Closure
30			*/
31			public $onVisitorReset;
32
33			/**
34			* @var ProvinceModel
35			*/
36			protected $provinceModel;
37
38			/**
39			* @var ProgramRepository
40			*/

literat / srazvs

Push — master ( 118c60...254398 )

VisitorForm B

Complexity

Size/Duplication

Coupling/Cohesion

Importance

27 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like