ProgramRepository::setMeetingId() - Code Metrics - Inspection of "Devel" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Pull Request — master (#140)

by Litera

created 2017-12-15 10:20 UTC

ProgramRepository::setMeetingId() A

↳ Parent: ProgramRepository

Complexity

Conditions	1
Paths	1

Size

Total Lines	7
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	7
c	0
b	0
f	0
cc	1
eloc	4
nc	1
nop	1
rs	9.4285

<?php

namespace App\Repositories;

use App\Models\ProgramModel;
use App\Models\VisitorModel;
use Nette\Database\Table\ActiveRow;
use Nette\Utils\ArrayHash;

class ProgramRepository
{

	/**
	 * @var VisitorModel
	 */
	protected $visitorModel;

	/**
	 * @var ProgramModel
	 */
	protected $programModel;

	/**
	 * @param VisitorModel $visitorModel
	 * @param ProgramModel $programModel
	 */
	public function __construct(
		VisitorModel $visitorModel,
		ProgramModel $programModel
	) {
		$this->setVisitorModel($visitorModel);
		$this->setProgramModel($programModel);
	}

	/**
	 * @param int $meetingId
	 */
	public function setMeetingId(int $meetingId): self
	{
		$this->getProgramModel()->setMeetingId($meetingId);
		$this->getVisitorModel()->setMeetingId($meetingId);

		return $this;
	}

	/**
	 * @return array
	 */
	public function all(): array
	{
		return $this->getProgramModel()->all();
	}

	/**
	 * @param  int  $id
	 * @return Nette\Database\Table\ActiveRow
	 */
	public function find(int $id): ActiveRow
	{
		return $this->getProgramModel()->find($id);
	}

	/**
	 * @param  int  $VisitorId
	 * @return array
	 */
	public function findByVisitorId(int $VisitorId): array

	{
		return $this->getProgramModels()->findByVisitorId($visitorId);

	}

	/**
	 * @param  int    $programId
	 * @return array
	 */
	public function findTutor(int $programId): ActiveRow
	{
		return $this->getProgramModel()->getTutor($programId);
	}

	/**
	 * @param  int   $programId
	 * @return array
	 */
	public function findVisitors(int $programId): array
	{
		return $this->getProgramModel()->findProgramVisitors($programId);
	}

	/**
	 * @param  Nette\Utils\ArrayHash $program
	 * @return boolean
	 */
	public function create(ArrayHash $program)
	{
		$program = $this->transformDisplayInRegValue($program);

		return $this->getProgramModel()->create((array) $program);
	}

	/**
	 * @param  Nette\Utils\ArrayHash $program
	 * @return boolean
	 */
	public function update(int $id, ArrayHash $program)
	{
		$program = $this->transformDisplayInRegValue($program);

		return $this->getProgramModel()->update($id, (array) $program);
	}

	/**
	 * @param  int    $id
	 * @return boolean
	 */
	public function delete(int $id)
	{
		return $this->getProgramModel()->delete($id);
	}

	/**
	 * @param  int    $visitorId
	 * @return array
	 */
	public function assembleFormPrograms(int $visitorId): array

	{
		$visitorPrograms = $this->getVisitorModel()->findVisitorPrograms($visitorId);

		$formPrograms = [];

		foreach ($visitorPrograms as $visitorProgram) {
			if($visitorProgram->program !== 0) {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
				$program = $this->getProgramModel()->findByProgramId($visitorProgram->program);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
				$formPrograms['blck_' . $program->block] = $visitorProgram->program;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			}
		}

		return $formPrograms;
	}

	/**
	 * @param  Nette\Utils\ArrayHash $program
	 * @return Nette\Utils\ArrayHash
	 */
	protected function transformDisplayInRegValue(ArrayHash $program): ArrayHash
	{
		if(array_key_exists('display_in_reg', $program) && empty($program['display_in_reg'])) {
			$program['display_in_reg'] = '1';
		} else {
			$program['display_in_reg'] = '0';
		}

		return $program;
	}

	/**
	 * @return ProgramModel
	 */
	protected function getProgramModel()
	{
		return $this->programModel;
	}

	/**
	 * @param  ProgramModel $model
	 * @return $this
	 */
	protected function setProgramModel(ProgramModel $model): self
	{
		$this->programModel = $model;

		return $this;
	}

	/**
	 * @return VisitorModel
	 */
	protected function getVisitorModel(): VisitorModel
	{
		return $this->visitorModel;
	}

	/**
	 * @param  VisitorModel $model
	 * @return VisitorService
	 */
	protected function setVisitorModel(VisitorModel $model): self
	{
		$this->visitorModel = $model;

		return $this;
	}

}


Pull Request — master (#140)

ProgramRepository::setMeetingId() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1		<?php
2
3		namespace App\Repositories;
4
5		use App\Models\ProgramModel;
6		use App\Models\VisitorModel;
7		use Nette\Database\Table\ActiveRow;
8		use Nette\Utils\ArrayHash;
9
10		class ProgramRepository
11		{
12
13		/**
14		* @var VisitorModel
15		*/
16		protected $visitorModel;
17
18		/**
19		* @var ProgramModel
20		*/
21		protected $programModel;
22
23		/**
24		* @param VisitorModel $visitorModel
25		* @param ProgramModel $programModel
26		*/
27		public function __construct(
28		VisitorModel $visitorModel,
29		ProgramModel $programModel
30		) {
31		$this->setVisitorModel($visitorModel);
32		$this->setProgramModel($programModel);
33		}
34
35		/**
36		* @param int $meetingId
37		*/
38		public function setMeetingId(int $meetingId): self
39		{
40		$this->getProgramModel()->setMeetingId($meetingId);
41		$this->getVisitorModel()->setMeetingId($meetingId);
42
43		return $this;
44		}
45
46		/**
47		* @return array
48		*/
49		public function all(): array
50		{
51		return $this->getProgramModel()->all();
52		}
53
54		/**
55		* @param int $id
56		* @return Nette\Database\Table\ActiveRow
57		*/
58		public function find(int $id): ActiveRow
59		{
60		return $this->getProgramModel()->find($id);
61		}
62
63		/**
64		* @param int $VisitorId
65		* @return array
66		*/
67		public function findByVisitorId(int $VisitorId): array
		0 ignored issues – show Unused Code introduced 2017-12-15 10:30 UTC by Report Bug Copy Issue Report The parameter `$VisitorId` is not used and could be removed. This check looks from parameters that have been defined for a function or method, but which are not used in the method body. Loading history...
68		{
69		return $this->getProgramModels()->findByVisitorId($visitorId);
		0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC by Report Bug Copy Issue Report The variable `$visitorId` does not exist. Did you mean `$VisitorId`? This check looks for variables that are accessed but have not been defined. It raises an issue if it finds another variable that has a similar name. The variable may have been renamed without also renaming all references. Loading history... Bug introduced 2017-12-15 10:30 UTC by Report Bug Copy Issue Report The method `getProgramModels()` does not exist on `App\Repositories\ProgramRepository`. Did you maybe mean `getProgramModel()`? This check marks calls to methods that do not seem to exist on an object. This is most likely the result of a method being renamed without all references to it being renamed likewise. Loading history...
70		}
71
72		/**
73		* @param int $programId
74		* @return array
75		*/
76		public function findTutor(int $programId): ActiveRow
77		{
78		return $this->getProgramModel()->getTutor($programId);
79		}
80
81		/**
82		* @param int $programId
83		* @return array
84		*/
85		public function findVisitors(int $programId): array
86		{
87		return $this->getProgramModel()->findProgramVisitors($programId);
88		}
89
90		/**
91		* @param Nette\Utils\ArrayHash $program
92		* @return boolean
93		*/
94		public function create(ArrayHash $program)
95		{
96		$program = $this->transformDisplayInRegValue($program);
97
98		return $this->getProgramModel()->create((array) $program);
99		}
100
101		/**
102		* @param Nette\Utils\ArrayHash $program
103		* @return boolean
104		*/
105		public function update(int $id, ArrayHash $program)
106		{
107		$program = $this->transformDisplayInRegValue($program);
108
109		return $this->getProgramModel()->update($id, (array) $program);
110		}
111
112		/**
113		* @param int $id
114		* @return boolean
115		*/
116		public function delete(int $id)
117		{
118		return $this->getProgramModel()->delete($id);
119		}
120
121		/**
122		* @param int $visitorId
123		* @return array
124		*/
125	View Code Duplication	public function assembleFormPrograms(int $visitorId): array
		0 ignored issues – show Duplication introduced 2017-12-15 10:30 UTC Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
126		{
127		$visitorPrograms = $this->getVisitorModel()->findVisitorPrograms($visitorId);
128
129		$formPrograms = [];
130
131		foreach ($visitorPrograms as $visitorProgram) {
132		if($visitorProgram->program !== 0) {
		0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC Report Bug Copy Issue Report Accessing `program` on the interface `Nette\Database\IRow` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
133		$program = $this->getProgramModel()->findByProgramId($visitorProgram->program);
		0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC Report Bug Copy Issue Report Accessing `program` on the interface `Nette\Database\IRow` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
134		$formPrograms['blck_' . $program->block] = $visitorProgram->program;
		0 ignored issues – show Bug introduced 2017-12-15 10:30 UTC Report Bug Copy Issue Report Accessing `program` on the interface `Nette\Database\IRow` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
135		}
136		}
137
138		return $formPrograms;
139		}
140
141		/**
142		* @param Nette\Utils\ArrayHash $program
143		* @return Nette\Utils\ArrayHash
144		*/
145		protected function transformDisplayInRegValue(ArrayHash $program): ArrayHash
146		{
147		if(array_key_exists('display_in_reg', $program) && empty($program['display_in_reg'])) {
148		$program['display_in_reg'] = '1';
149		} else {
150		$program['display_in_reg'] = '0';
151		}
152
153		return $program;
154		}
155
156		/**
157		* @return ProgramModel
158		*/
159		protected function getProgramModel()
160		{
161		return $this->programModel;
162		}
163
164		/**
165		* @param ProgramModel $model
166		* @return $this
167		*/
168		protected function setProgramModel(ProgramModel $model): self
169		{
170		$this->programModel = $model;
171
172		return $this;
173		}
174
175		/**
176		* @return VisitorModel
177		*/
178		protected function getVisitorModel(): VisitorModel
179		{
180		return $this->visitorModel;
181		}
182
183		/**
184		* @param VisitorModel $model
185		* @return VisitorService
186		*/
187		protected function setVisitorModel(VisitorModel $model): self
188		{
189		$this->visitorModel = $model;
190
191		return $this;
192		}
193
194		}
195

literat / srazvs

Pull Request — master (#140)

ProgramRepository::setMeetingId() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like