BasePresenter::logError() - Code Metrics - Inspection of "Devel" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Test Failed

Retried Inspection

Pull Request — master (#140)

by Litera

created 2017-12-15 10:20 UTC

BasePresenter::logError() A

↳ Parent: Project

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	2
nc	1
nop	2
dl	0
loc	4
rs	10
c	0
b	0
f	0

<?php

namespace App\Presenters;

use Nette,
	App\Model;
use Nette\Utils\Strings;
use Nette\Http\Request;
use App\Models\SunlightModel;
use Nette\Caching\Cache;
use App\Traits\Loggable;

/**
 * Base presenter for all application presenters.
 */
abstract class BasePresenter extends Nette\Application\UI\Presenter
{

	use Loggable;

	const FLASH_TYPE_OK    = 'success';
	const FLASH_TYPE_ERROR = 'error';

	/**
	 * @var string
	 */
	public $backlink = '';

	/** @var Model */
	protected $model;

	/** @var Nette\DI\Container */
	protected $container;

	/** @var Latte */
	protected $latte;

	/** @var Router */
	protected $router;

	/** @var string */
	protected $action;

	/** @var Nette\Http\Request */
	protected $request;

	/** @var integer */
	protected $meetingId;

	protected $days = [
		'pátek'		=> 'pátek',
		'sobota'	=> 'sobota',
		'neděle'	=> 'neděle',
	];

	protected $hours = [
		0 => "00","01","02","03","04","05","06","07","08","09","10","11","12","13","14","15","16","17","18","19","20","21","22","23"
	];

	protected $minutes = [
		00 => "00",
		05 => "05",
		10 => "10",
		15 => "15",
		20 => "20",
		25 => "25",
		30 => "30",
		35 => "35",
		40 => "40",
		45 => "45",
		50 => "50",
		55 => "55",
	];

	/**
	 * Startup
	 */
	protected function startup()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		parent::startup();

		$meetingId = $this->getHttpRequest()->getQuery('mid', '');

		$backlink = $this->getHttpRequest()->getQuery('backlink');
		if(!empty($backlink)) {
			$this->setBacklink($backlink);
		}

		if($meetingId){
			$_SESSION['meetingID'] = $meetingId;
		} elseif(!isset($_SESSION['meetingID'])) {
			$meeting = $this->getContainer()->getService('meeting');
			$_SESSION['meetingID'] = $meeting->getLastMeetingId();
		}

		$this->setMeetingId($_SESSION['meetingID']);

		$model = $this->getModel();
		if($model) {
			$model->setMeetingId($_SESSION['meetingID']);
		}

		$this->debugMode = $this->getContainer()->getParameters()['debugMode'];
	}


	/**
	 * Before render
	 * Prepare variables for template
	 */
	public function beforeRender()
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
	{
		parent::beforeRender();

		$template = $this->getTemplate();
		$meeting = $this->getContainer()->getService('meeting');

		$template->baseDir = ROOT_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->wwwDir = HTTP_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->cssDir = CSS_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->jsDir = JS_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->imgDir = IMG_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->catDir = CAT_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->blockDir = BLOCK_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->progDir = PROG_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->visitDir = VISIT_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->expDir = EXP_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->meetDir = MEET_DIR;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}

		$template->categories = $this->remember('categories:all', 10, function () {
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
			return $this->getContainer()->getService('category')->all();
		});

		if(isset($_SESSION[SESSION_PREFIX.'user'])) {
			$template->user = $this->getSunlight()->findUser($_SESSION[SESSION_PREFIX.'user']);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		}
		$template->meeting = $meeting->getPlaceAndYear($_SESSION['meetingID']);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->menuItems = $meeting->getMenuItems();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->meeting_heading	= $meeting->getRegHeading();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->meetingId = $this->getMeetingId();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->backlinkUrl = $this->getBacklinkUrl();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->backlink = $this->getBacklink();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		//$this->template->backlink = $this->getParameter("backlink");

		//$this->template->production = $this->context->parameters['environment'] === 'production' ? 1 : 0;
		//$this->template->version = $this->context->parameters['site']['version'];
	}

	/**
	 * template
	 * @var string
	 */
	protected $template = 'listing';

	/**
	 * template directory
	 * @var string
	 */
	protected $templateDir = '';

	/**
	 * category ID
	 * @var integer
	 */
	protected $itemId = NULL;

	/**
	 * action what to do
	 * @var string
	 */
	protected $cms = '';

	/**
	 * page where to return
	 * @var string
	 */
	protected $page = '';

	/**
	 * heading tetxt
	 * @var string
	 */
	protected $heading = '';

	/**
	 * action what to do next
	 * @var string
	 */
	protected $todo = '';

	/**
	 * data
	 * @var array
	 */
	protected $data = array();

	/**
	 * error handler
	 * @var string
	 */
	protected $error = '';

	/**
	 * database connection
	 * @var string
	 */
	protected $database = NULL;

	/**
	 * debug mode
	 * @var boolean
	 */
	protected $debugMode = false;

	protected $sunlight;

	/**
	 * Render check box
	 *
	 * @param	string	name
	 * @param	mixed	value
	 * @param	var		variable that match with value
	 * @return	string	html of chceck box
	 */
	protected function renderHtmlCheckBox($name, $value, $checked_variable)

	{
		if($checked_variable == $value) {
			$checked = 'checked';
		} else {
			$checked = '';
		}
		$html_checkbox = "<input name='".$name."' type='checkbox' value='".$value."' ".$checked." />";

		return $html_checkbox;
	}

	protected function parseTutorEmail($item)
	{
		$mails = explode(',', $item->email);
		$names = explode(',', $item->tutor);

		$i = 0;
		foreach ($mails as $mail) {
			$mail = trim($mail);
			$name = trim($names[$i]);

			$recipient[$mail] = ($name) ? $name : '';
foreach ($collection as $item) {
    $myArray['foo'] = $item->getFoo();

    if ($item->hasBar()) {
        $myArray['bar'] = $item->getBar();
    }

    // do something with $myArray
}
		}

		return $recipient;
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}
	}

	// zaheshovane udaje, aby se nedali jen tak ziskat data z databaze
	protected function formKeyHash($id, $meetingId)
	{
		return ((int)$id . $meetingId) * 116 + 39147;
	}

	/**
	 * @return Model
	 */
	protected function getModel()
	{
		return $this->model;
	}

	/**
	 * @param  Model $model
	 * @return $this
	 */
	protected function setModel($model)
	{
		$this->model = $model;
		return $this;
	}

	/**
	 * @return Container
	 */
	protected function getContainer()
	{
		return $this->context;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
	}

	/**
	 * @param  Container $container
	 * @return $this
	 */
	protected function setContainer($container)
	{
		$this->context = $container;
<?php

/**
 * @property int $x
 * @property int $y
 * @property string $text
 */
class MyLabel
{
    private $properties;

    private $allowedProperties = array('x', 'y', 'text');

    public function __get($name)
    {
        if (isset($properties[$name]) && in_array($name, $this->allowedProperties)) {
            return $properties[$name];
        } else {
            return null;
        }
    }

    public function __set($name, $value)
    {
        if (in_array($name, $this->allowedProperties)) {
            $properties[$name] = $value;
        } else {
            throw new \LogicException("Property $name is not defined.");
        }
    }

}
		return $this;
	}

	/**
	 * @return Router
	 */
	protected function getRouter()
	{
		return $this->router;
	}

	/**
	 * @param  Router $router
	 * @return $this
	 */
	protected function setRouter($router)
	{
		$this->router = $router;
		return $this;
	}

	/**
	 * @return Latte
	 */
	protected function getLatte()
	{
		return $this->latte;
	}

	/**
	 * @param  Latte $latte
	 * @return $this
	 */
	protected function setLatte($latte)
	{
		$this->latte = $latte;
		return $this;
	}

	/**
	 * @return string
	 */
	public function getAction($fullyQualified = false)
	{
		return $this->action;
	}

	/**
	 * @param  string $action
	 * @return $this
	 */
	public function setAction($action)
	{
		$this->action = $action;
		return $this;
	}

	/**
	 * @return SunlightModel
	 */
	public function getSunlight()
	{
		if(empty($this->sunlight)) {
			$this->setSunlight($this->getContainer()->getService('sunlight'));
		}

		return $this->sunlight;
	}

	/**
	 * @param  SunlightModel $sunlight
	 * @return $this
	 */
	public function setSunlight(SunlightModel $sunlight)
	{
		$this->sunlight = $sunlight;
		return $this;
	}

	/**
	 * @return integer
	 */
	protected function getMeetingId()
	{
		return $this->meetingId;
	}

	/**
	 * @param  integer  $meetingId
	 * @return $this
	 */
	protected function setMeetingId($meetingId)
	{
		$this->meetingId = $meetingId;
		return $this;
	}

	/**
	 * @param  string $guid
	 * @param  array  $data
	 * @return ActiveRow
	 */
	protected function updateByGuid($guid, array $data)
	{
		return $this->getModel()->updateBy('guid', $guid, $data);
	}

	public function remember($key, $minutes, \Closure $callback)
	{
		// If the item exists in the cache we will just return this immediately
		// otherwise we will execute the given Closure and cache the result
		// of that execution for the given number of minutes in storage.
		if (! is_null($data = $this->getCache()->load($key))) {
			$items = [];

			foreach($data as $item) {
				$object = new \stdClass();
				foreach ($item as $key => $value) {
					$object->$key = $value;
				}
				$items[] = $object;
			}

			return $items;
		}

		$data = $callback();
		$serialized = [];
		foreach ($data as $item) {
			$serialized[] = $item->toArray();
		}

		$this->getCache()->save(
			$key,
			$serialized,
			[
				Cache::EXPIRE => $minutes . ' minutes',
			]
		);

		return $data;
	}

	protected function getCache()
	{
		return $this->getContainer()->getService('cache');
	}

	/**
	 * @return string
	 */
	protected function getDebugMode()
	{
		return $this->debugMode;
	}

	/**
	 * @return string
	 */
	protected function getBacklink()
	{
		return $this->backlink;
	}

	/**
	 * @param  string $backlink
	 * @return $this
	 */
	protected function setBacklink($backlink)
	{
		$this->backlink = $backlink;

		return $this;
	}

	/**
	 * @return string
	 */
	protected function getBacklinkUrl()
	{
		if($this->getBacklink()) {
			return $this->link(
				$this->getBacklink(),
				[
					'backlink' => null
				]
			);
		}
	}

	/**
	 * Flashes success message
	 *
	 * @param  string $message Message
	 */
	protected function flashSuccess(string $message = '')
	{
		$this->flashMessage($message, self::FLASH_TYPE_OK);
	}

	/**
	 * Flashes error message
	 *
	 * @param  string $message Message
	 */
	protected function flashError(string $message = '')
	{
		$this->flashMessage($message, self::FLASH_TYPE_ERROR);
	}

}


Pull Request — master (#140)

BasePresenter::logError() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Presenters;
4
5			use Nette,
6			App\Model;
7			use Nette\Utils\Strings;
8			use Nette\Http\Request;
9			use App\Models\SunlightModel;
10			use Nette\Caching\Cache;
11			use App\Traits\Loggable;
12
13			/**
14			* Base presenter for all application presenters.
15			*/
16			abstract class BasePresenter extends Nette\Application\UI\Presenter
17			{
18
19			use Loggable;
20
21			const FLASH_TYPE_OK = 'success';
22			const FLASH_TYPE_ERROR = 'error';
23
24			/**
25			* @var string
26			*/
27			public $backlink = '';
28
29			/** @var Model */
30			protected $model;
31
32			/** @var Nette\DI\Container */
33			protected $container;
34
35			/** @var Latte */
36			protected $latte;
37
38			/** @var Router */
39			protected $router;
40

literat / srazvs

Pull Request — master (#140)

BasePresenter::logError() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like