NavbarRightControl::render() - Code Metrics - Inspection of "Feat 133 login page" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — devel (#146)

by Litera

created 2018-03-23 10:00 UTC

NavbarRightControl::render() A

↳ Parent: NavbarRightControl

Complexity

Conditions	1
Paths	1

Size

Total Lines	9
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	1
eloc	7
nc	1
nop	1
dl	0
loc	9
rs	9.6666
c	0
b	0
f	0

<?php

namespace App\Components;

use Nette\Security\User;

class NavbarRightControl extends BaseControl
{

	const TEMPLATE_NAME = 'NavbarRight';

	/**
	 * @var User
	 */
	private $user;

	/**
	 * @param User $user
	 */
	public function __construct(User $user)
	{
		$this->setUser($user);
	}

	/**
	 * @return void
	 */
	public function render($backlink)
	{
		$template = $this->getTemplate();
		$template->setFile(__DIR__ . './templates/'.self::TEMPLATE_NAME.'.'.self::TEMPLATE_EXT);
		$template->user = $this->getUser();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->page = $this->getPresenter()->getName();
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->backlink = $backlink;
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->render();
	}

	/**
	 * @return User
	 */
	protected function getUser(): User
	{
		return $this->user;
	}

	/**
	 * @param  User $user
	 * @return $this
	 */
	protected function setUser(User $user): self
	{
		$this->user = $user;

		return $this;
	}

}


Pull Request — devel (#146)

NavbarRightControl::render() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Components;
4
5			use Nette\Security\User;
6
7			class NavbarRightControl extends BaseControl
8			{
9
10			const TEMPLATE_NAME = 'NavbarRight';
11
12			/**
13			* @var User
14			*/
15			private $user;
16
17			/**
18			* @param User $user
19			*/
20			public function __construct(User $user)
21			{
22			$this->setUser($user);
23			}
24
25			/**
26			* @return void
27			*/
28			public function render($backlink)
29			{
30			$template = $this->getTemplate();
31			$template->setFile(__DIR__ . './templates/'.self::TEMPLATE_NAME.'.'.self::TEMPLATE_EXT);
32			$template->user = $this->getUser();
			0 ignored issues – show Bug introduced 2018-03-23 10:18 UTC by Report Bug Copy Issue Report Accessing `user` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
33			$template->page = $this->getPresenter()->getName();
			0 ignored issues – show Bug introduced 2018-03-23 10:18 UTC by Report Bug Copy Issue Report Accessing `page` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
34			$template->backlink = $backlink;
			0 ignored issues – show Bug introduced 2018-03-23 10:18 UTC by Report Bug Copy Issue Report Accessing `backlink` on the interface `Nette\Application\UI\ITemplate` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
35			$template->render();
36			}
37
38			/**
39			* @return User
40			*/
41			protected function getUser(): User
42			{
43			return $this->user;
44			}
45
46			/**
47			* @param User $user
48			* @return $this
49			*/
50			protected function setUser(User $user): self
51			{
52			$this->user = $user;
53
54			return $this;
55			}
56
57			}
58

literat / srazvs

Pull Request — devel (#146)

NavbarRightControl::render() A

Complexity

Size

Duplication

Importance

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like