MeetingModel - Code Metrics - Inspection of "Devel" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#102)

by Litera

created 2017-09-12 20:16 UTC

MeetingModel B

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	507
Duplicated Lines	1.38 %

Coupling/Cohesion

Components	2
Dependencies	5

Importance

Changes

Metric	Value
dl	7
loc	507
c	0
b	0
f	0
rs	8.2608
wmc	40
lcom	2
cbo	5

24 Methods

Rating	Name	Duplication	Size	Complexity
A	getPlaceAndYear()	0	10	1
A	getMenuItems()	0	11	1
A	getLastMeetingId()	0	9	1
B	__construct()	0	33	1
A	setHttpEncoding()	0	4	1
A	getInstance()	0	7	2
A	create()	0	7	1
A	update()	0	6	1
A	delete()	7	7	1
A	getData()	0	20	3
A	getPrice()	0	9	1
A	renderHtmlProvinceSelect()	0	20	3
B	getPublicPrograms()	0	28	3
B	renderData()	0	76	3
A	setRegistrationHandlers()	0	20	1
A	getRegOpening()	0	4	1
A	setRegOpening()	0	6	1
A	getRegClosing()	0	4	1
A	setRegClosing()	0	6	1
A	getRegHeading()	0	4	1
A	setRegHeading()	0	6	1
A	isRegOpen()	0	4	3
A	getProvinceNameById()	0	9	1
B	renderPublicProgramOverview()	0	53	6

How to fix Duplicated Code Complexity

Duplicated Code

Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.

Common duplication problems, and corresponding solutions are:

If you have the same expression in different places: Extract expression to a method
If you have the same method in different sub-classes: Extract method, and pull up field to the parent class
If you have the same code in unrelated classes: Consider extracting the code to a new class, and injecting that class

Complex Class

Tip: Before tackling complexity, make sure that you eliminate any duplication first. This often can reduce the size of classes significantly.

Complex classes like MeetingModel often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes. You can also have a look at the cohesion graph to spot any un-connected, or weakly-connected components.

Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.

While breaking up the class, it is a good idea to analyze how other classes use MeetingModel, and based on these observations, apply Extract Interface, too.

<?php

namespace App\Models;

use Nette\Database\Context;
use App\Models\ProgramModel;
use App\Models\BaseModel;

/**
 * Meeting
 *
 * class for handling meeting
 *
 * @created 2012-11-09
 * @author Tomas Litera <[email protected]>
 */
class MeetingModel extends BaseModel

{

	/** @var array days of weekend */
	private $weekendDays = array();

	/** @var array of form names */
	public $form_names = array();

	/** @var array of database programs table columns */
	public $dbColumns = array();

	/** @var datetime at what registration opens */
	public $regOpening = NULL;

	/** @var datetime at what registration ends*/
	public $regClosing = NULL;

	/** @var string registration heading text */
	public $regHeading = '';

	private $program;
	private $httpEncoding;
	private $dbTable;

	protected $table = 'kk_meetings';

	/** Constructor */
	public function __construct(Context $database, ProgramModel $program)
	{
		$this->weekendDays = array("pátek", "sobota", "neděle");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		$this->form_names = array(
			"place",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"start_date",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"end_date",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"open_reg",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"close_reg",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"contact",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"email",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"gsm",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"cost",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"advance",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"numbering"
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		);
		$this->dbColumns = array(
			"place",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"start_date",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"end_date",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"open_reg",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"close_reg",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"contact",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"email",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"gsm",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"cost",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"advance",
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			"numbering"
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		);
		$this->dbTable = "kk_meetings";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		$this->setDatabase($database);
		$this->program = $program;
	}

	public function setHttpEncoding($encoding)
	{
		$this->httpEncoding = $encoding;
	}

	/**
	 * Create new or return existing instance of class
	 *
	 * @return	mixed	instance of class
	 */
	public static function getInstance()
	{
		if(self::$instance === false) {
			self::$instance = new self();

		}
		return self::$instance;
	}

	/**
	 * Create a new record
	 *
	 * @param	mixed	array of data
	 * @return	boolean
	 */
	public function create(array $data)
	{
		$data['guid'] = md5(uniqid());
		$result = $this->getDatabase()->query('INSERT INTO ' . $this->getTable(), $data);

		return $result;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
	}

	/**
	 * Modify record
	 *
	 * @param	int		$id			ID of record
	 * @param	array	$db_data	array of data
/**
 * @param array $germany
 * @param array $island
 * @param array $italy
 */
function finale($germany, $island) {
    return "2:1";
}
	 * @return	bool
	 */
	public function update($id, array $data)
	{
		$result = $this->getDatabase()->table($this->getTable())->where('id', $id)->update($data);

		return $result;
	}

	/**
	 * Delete one or multiple record/s
	 *
	 * @param	int		ID/s of record
	 * @return	boolean
	 */
	public function delete($ids)

	{
		$data = array('deleted' => '1');
		$result = $this->getDatabase()->table($this->getTable())->where('id', $ids)->update($data);

		return $result;
	}

	/**
	 * Return meeting data
	 *
	 * @return	string	html table
	 */
	public function getData($meetingId = null)
	{
		if(isset($meetingId)) {
			$data = $this->getDatabase()
				->table($this->getTable())
				->where('deleted ? AND id ?', '0', $meetingId)
				->fetch();
		} else {
			$data = $this->getDatabase()
				->table($this->getTable())
				->where('deleted', '0')
				->fetchAll();
		}

		if(!$data) {
			return 0;
		} else {
			return $data;
		}
	}

	/**
	 * @param  string $priceType cost|advance
	 * @return integer
	 */
	public function getPrice($priceType)
	{
		return $this->getDatabase()
			->table($this->getTable())
			->select($priceType)
			->where('id', $this->getMeetingId())
			->limit(1)
			->fetchField();
	}

	/**
	 * Render HTML Provinces <select>
	 *
	 * @param	int	ID of selected province
	 * @return	string	html <select>
	 */
	public function renderHtmlProvinceSelect($selectedProvince)
	{
		$html_select = "<select style='width: 195px; font-size: 10px' name='province'>\n";

		$result = $this->getDatabase()
			->table('kk_provinces')
			->fetchAll();

		foreach($result as $data) {
			if($data['id'] == $selectedProvince) {
				$sel = "selected";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
			else $sel = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			$html_select .= "<option value='" . $data['id'] . "' " . $sel . ">" . $data['province_name'] . "</option>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		}

		$html_select .= "</select>\n";

		return $html_select;
	}

	/** Public program same as getPrograms*/
	public function getPublicPrograms($blockId)
	{
		$result = $this->getDatabase()
			->query('SELECT progs.id AS id,
						progs.name AS name,
						style
				FROM kk_programs AS progs
				LEFT JOIN kk_categories AS cat ON cat.id = progs.category
				WHERE block = ? AND progs.deleted = ?
				LIMIT 10',
				$blockId, '0')
			->fetchAll();

		if(!$result) {

			$html = '';
		} else {
			$html = "<table>\n";
			$html .= " <tr>\n";
			foreach($result as $data) {
				$html .= "<td class='category cat-".$data['style']."' style='text-align:center;'>\n";
				$html .= "<a class='programLink' rel='programDetail' href='#' rel='programDetail' title='" . $this->program->getDetail($data['id'], 'program', $this->httpEncoding) . "'>" . $data['name'] . "</a>\n";
				$html .= "</td>\n";
			}
			$html .= " </tr>\n";
			$html .= "</table>\n";
		}
		return $html;
	}

	public function renderPublicProgramOverview($meetingId)
	{
		$days = array("pátek", "sobota", "neděle");
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		$html = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

		foreach($days as $dayKey => $dayVal) {
			$html .= "<table>\n";
			$html .= " <tr>\n";
			$html .= "  <td class='day' colspan='2' >" . $dayVal . "</td>\n";
			$html .= " </tr>\n";

			$result = $this->getDatabase()
				->query('SELECT	blocks.id AS id,
							day,
							DATE_FORMAT(`from`, "%H:%i") AS `from`,
							DATE_FORMAT(`to`, "%H:%i") AS `to`,
							blocks.name AS name,
							program,
							display_progs,
							style
					FROM kk_blocks AS blocks
					LEFT JOIN kk_categories AS cat ON cat.id = blocks.category
					WHERE blocks.deleted = ? AND day = ? AND meeting = ?
					ORDER BY `from` ASC',
					'0', $dayVal, $meetingId)
				->fetchAll();

			if(!$result) {

				$html .= "<td class='emptyTable' style='width:400px;'>Nejsou žádná aktuální data.</td>\n";
			} else {
				foreach($result as $data) {
					$html .= "<tr>\n";
					$html .= "<td class='time'>" . $data['from'] . " - " . $data['to'] . "</td>\n";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
					if(($data['program'] == 1) && ($data['display_progs'] == 1)) {
						$html .= "<td class='category cat-" . $data['style'] . "' class='daytime'>\n";
						$html .= "<div>\n";
						$html .= "<a class='programLink rel='programDetail' href='#' rel='programDetail' title='" . $this->program->getDetail($data['id'], 'block', $this->httpEncoding) . "'>" . $data['name'] . "</a>\n";
						$html .= "</div>\n";
						$html .= $this->getPublicPrograms($data['id']);
						$html .= "</td>\n";
					} else {
						$html .= "<td class='category cat-" . $data['style'] . "'>";
						$html .= "<a class='programLink rel='programDetail' href='#' rel='programDetail' title='" . $this->program->getDetail($data['id'], 'block', $this->httpEncoding) . "'>" . $data['name'] . "</a>\n";
						$html .= "</td>\n";
					}
					$html .= "</tr>\n";
				}
			}
			$html .= "</table>\n";
		}

		return $html;
	}

	/**
	 * @deprecated
	 *
	 * Render data in a table
	 *
	 * @return	string	html of a table
	 */
	public function renderData()
	{
		$result = $this->database
			->table($this->dbTable)
			->select('id,
					place,
					DATE_FORMAT(start_date, "%d. %m. %Y") AS start_date,
					DATE_FORMAT(end_date, "%d. %m. %Y") AS end_date,
					DATE_FORMAT(open_reg, "%d. %m. %Y %H:%i:%s") AS open_reg,
					DATE_FORMAT(close_reg, "%d. %m. %Y %H:%i:%s") AS close_reg,
					contact,
					email,
					gsm')
			->where('deleted', '0')
			->limit(30)
			->fetchAll();

		$html_row = "";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;

		if(!$result) {

			$html_row .= "<tr class='radek1'>";
			$html_row .= "<td><img class='edit' src='" . IMG_DIR . "icons/edit2.gif' /></td>\n";
			$html_row .= "<td><img class='edit' src='" . IMG_DIR . "icons/delete2.gif' /></td>\n";
			$html_row .= "<td colspan='11' class='emptyTable'>Nejsou k dispozici žádné položky.</td>";
			$html_row .= "</tr>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
		} else {
			foreach($result as $data) {
				$html_row .= "<tr class='radek1'>";
				$html_row .= "\t\t\t<td><a href='process.php?id=".$data['id']."&cms=edit&page=meetings' title='Upravit'><img class='edit' src='".IMG_DIR."icons/edit.gif' /></a></td>\n";
				$html_row .= "\t\t\t<td><a href=\"javascript:confirmation('?id=".$data['id']."&amp;cms=del', 'sraz: ".$data['place']." ".$data['start_date']." -> Opravdu SMAZAT tento sraz? Jste si jisti?')\" title='Odstranit'><img class='edit' src='".IMG_DIR."icons/delete.gif' /></a></td>\n";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
				$html_row .= "\t\t\t<td class='text'>".$data['id']."</td>\n";
				$html_row .= "\t\t\t<td class='text'>".$data['place']."</td>\n";
				$html_row .= "\t\t\t<td class='text'>".$data['start_date']."</td>\n";
				$html_row .= "\t\t\t<td class='text'>".$data['end_date']."</td>\n";
				$html_row .= "\t\t\t<td class='text'>".$data['open_reg']."</td>\n";
				$html_row .= "\t\t\t<td class='text'>".$data['close_reg']."</td>\n";
				$html_row .= "\t\t\t<td class='text'>".$data['contact']."</td>\n";
				$html_row .= "\t\t\t<td class='text'>".$data['email']."</td>\n";
				$html_row .= "\t\t\t<td class='text'>".$data['gsm']."</td>\n";
				$html_row .= "</tr>";
<?php

$singleQuoted = 'Value';
$doubleQuoted = "\tSingle is $singleQuoted";

print $doubleQuoted;
			}
		}

		// table head
		$html_thead = "\t<tr>\n";
		$html_thead .= "\t\t<th></th>\n";
		$html_thead .= "\t\t<th></th>\n";
		$html_thead .= "\t\t<th class='tab1'>id</th>\n";
		$html_thead .= "\t\t<th class='tab1'>místo</th>\n";
		$html_thead .= "\t\t<th class='tab1'>začátek</th>\n";
		$html_thead .= "\t\t<th class='tab1'>konec</th>\n";
		$html_thead .= "\t\t<th class='tab1'>otevření registrace</th>\n";
		$html_thead .= "\t\t<th class='tab1'>uzavření registrace</th>\n";
		$html_thead .= "\t\t<th class='tab1'>kontakt</th>\n";
		$html_thead .= "\t\t<th class='tab1'>e-mail</th>\n";
		$html_thead .= "\t\t<th class='tab1'>telefon</th>\n";
		$html_thead .= "\t</tr>\n";

		// table foot
		$html_tfoot = $html_thead;

		// table
		$html_table = "<table id='MeetingsTable' class='list tablesorter'>\n";
		$html_table .= "\t<thead>\n";
		$html_table .= $html_thead;
		$html_table .= "\t</thead>\n";
		$html_table .= "\t<tfoot>\n";
		$html_table .= $html_tfoot;
		$html_table .= "\t</tfoot>\n";
		$html_table .= "\t<tbody>\n";
		$html_table .= $html_row;
		$html_table .= "\t</tbody>\n";
		$html_table .= "</table>\n";

		return $html_table;
	}

	/**
	 * @param  integer $meetingId
	 * @return $this
	 */
	public function setRegistrationHandlers($meetingId = 1)
	{
		$meeting = $this->getDatabase()
			->table($this->getTable())
			->select('id')
			->select('place')
			->select('DATE_FORMAT(start_date, "%Y") AS year')
			->select('UNIX_TIMESTAMP(open_reg) AS open_reg')
			->select('UNIX_TIMESTAMP(close_reg) AS close_reg')
			->where('id', $meetingId)
			->order('id DESC')
			->limit(1)
			->fetch();

		$this->setRegHeading($meeting->place . ' ' . $meeting->year);
		$this->setRegClosing($meeting->close_reg);
		$this->setRegOpening($meeting->open_reg);

		return $this;
	}

	/**
	 * @return string
	 */
	public function getRegOpening()
	{
		return $this->regOpening;
	}

	/**
	 * @param  string $value
	 * @return $this
	 */
	public function setRegOpening($value = '')
	{
		$this->regOpening = $value;


		return $this;
	}

	/**
	 * @return string
	 */
	public function getRegClosing()
	{
		return $this->regClosing;
	}

	/**
	 * @param  string $value
	 * @return $this
	 */
	public function setRegClosing($value = '')
	{
		$this->regClosing = $value;


		return $this;
	}

	/**
	 * @return string
	 */
	public function getRegHeading()
	{
		return $this->regHeading;
	}

	/**
	 * @param  string $value
	 * @return $this
	 */
	public function setRegHeading($value = '')
	{
		$this->regHeading = $value;

		return $this;
	}

	/**
	 * Is registration open?
	 *
	 * @return 	boolean
	 */
	public function isRegOpen($debug = false)
	{
		return (($this->getRegOpening() < time()) && (time() < $this->getRegClosing()) || $debug);
	}

	/**
	 * @param  integer $id
	 * @return string
	 */
	public function getProvinceNameById($id)
	{
		return $this->getDatabase()
			->table('kk_provinces')
			->select('province_name')
			->where('id', $id)
			->limit(1)
			->fetchField('province_name');
	}

	/**
	 * @param  integer|string $meetingId
	 * @return ActiveRow
	 */
	public function getPlaceAndYear($meetingId)
	{
		return $this->getDatabase()
			->table($this->getTable())
			->select('place')
			->select('DATE_FORMAT(start_date, "%Y") AS year')
			->where('id = ? AND deleted = ?', $meetingId, '0')
			->limit(1)
			->fetch();
	}

	/**
	 * @return ActiveRow
	 */
	public function getMenuItems()
	{
		return $this->getDatabase()
			->table($this->getTable())
			->select('id AS mid')
			->select('place')
			->select('DATE_FORMAT(start_date, "%Y") AS year')
			->where('deleted', '0')
			->order('id DESC')
			->fetchAll();
	}

	/**
	 * @return integer
	 */
	public function getLastMeetingId()
	{
		return $this->getDatabase()
			->table($this->getTable())
			->select('id')
			->order('id DESC')
			->limit(1)
			->fetchField();
	}

}


1			<?php
2
3			namespace App\Models;
4
5			use Nette\Database\Context;
6			use App\Models\ProgramModel;
7			use App\Models\BaseModel;
8
9			/**
10			* Meeting
11			*
12			* class for handling meeting
13			*
14			* @created 2012-11-09
15			* @author Tomas Litera <[email protected]>
16			*/
17			class MeetingModel extends BaseModel
			0 ignored issues – show Coding Style introduced 2017-03-07 23:06 UTC by Report Bug Copy Issue Report The property $form_names is not named in camelCase. This check marks property names that have not been written in camelCase. In camelCase names are written without any punctuation, the start of each new word being marked by a capital letter. Thus the name database connection string becomes `databaseConnectionString`. Loading history...
18			{
19
20			/** @var array days of weekend */
21			private $weekendDays = array();
22
23			/** @var array of form names */
24			public $form_names = array();
25
26			/** @var array of database programs table columns */
27			public $dbColumns = array();
28
29			/** @var datetime at what registration opens */
30			public $regOpening = NULL;
31
32			/** @var datetime at what registration ends*/
33			public $regClosing = NULL;
34
35			/** @var string registration heading text */
36			public $regHeading = '';
37
38			private $program;
39			private $httpEncoding;

literat / srazvs