BlockForm - Code Metrics - Inspection of "Refactor 143 block render html select" - literat/srazvs - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — devel (#144)

by Litera

created 2018-01-14 20:51 UTC

BlockForm A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	245
Duplicated Lines	4.9 %

Coupling/Cohesion

Components	1
Dependencies	11

Importance

Changes

Metric	Value
dl	12
loc	245
rs	10
c	0
b	0
f	0
wmc	14
lcom	1
cbo	11

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	7	1
A	render()	0	7	1
A	setDefaults()	0	8	1
A	createComponentBlockForm()	0	49	1
A	processForm()	0	6	1
A	processReset()	0	6	1
A	buildCategorySelect()	12	12	2
A	guardDefaults()	0	9	2
A	getBlockRepository()	0	4	1
A	setBlockRepository()	0	6	1
A	getCategoryRepository()	0	4	1
A	setCategoryRepository()	0	6	1

How to fix Duplicated Code

<?php

namespace App\Components\Forms;

use App\Entities\BlockEntity;
use App\Repositories\BlockRepository;
use App\Repositories\CategoryRepository;
use Nette\Application\UI\Form;
use Nette\Forms\Controls\SubmitButton;

class BlockForm extends BaseForm
{

	const TEMPLATE_NAME = 'BlockForm';

	const MESSAGE_REQUIRED = 'Hodnota musí být vyplněna!';
	const MESSAGE_MAX_LENGTH = '%label nesmí mít více jak %d znaků!';

	/**
	 * @var Closure
	 */
	public $onBlockSave;

	/**
	 * @var Closure
	 */
	public $onBlockReset;

	/**
	 * @var BlockRepository
	 */
	protected $blockRepository;

	/**
	 * @var CategoryRepository
	 */
	protected $categoryRepository;

	/**
	 * @var array
	 */
	protected $days = [
		'pátek'  => 'pátek',
		'sobota' => 'sobota',
		'neděle' => 'neděle',
	];

	/**
	 * @var array
	 */
	protected $hours = [
		0 => "00","01","02","03","04","05","06","07","08","09",
			 "10","11","12","13","14","15","16","17","18","19",
			 "20","21","22","23"
	];

	/**
	 * @var array
	 */
	protected $minutes = [
		00 => "00",
		05 => "05",
		10 => "10",
		15 => "15",
		20 => "20",
		25 => "25",
		30 => "30",
		35 => "35",
		40 => "40",
		45 => "45",
		50 => "50",
		55 => "55",
	];

	/**
	 * @param BlockRepository    $blockRepository
	 * @param CategoryRepository $categoryRepository
	 */
	public function __construct(
		BlockRepository $blockRepository,
		CategoryRepository $categoryRepository
	) {
		$this->setBlockRepository($blockRepository);
		$this->setCategoryRepository($categoryRepository);
	}

	/**
	 * @return void
	 */
	public function render()
	{
		$template = $this->getTemplate();
		$template->setFile($this->buildTemplatePath());
		$template->backlink = 'Block:listing';
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
		$template->render();
	}

	/**
	 * @param  array $defaults
	 * @return self
	 */
	public function setDefaults(BlockEntity $defaults): self
	{
        $defaults = $this->guardDefaults($defaults);

		$this['blockForm']->setDefaults($defaults->toArray());

		return $this;
	}

	/**
	 * @return Form
	 */
	public function createComponentBlockForm(): Form
	{
		$form = new Form;

		$form->addText('name', 'Název:')
			->setRequired(static::MESSAGE_REQUIRED)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->addRule(Form::MAX_LENGTH, static::MESSAGE_MAX_LENGTH, 50)
			->setAttribute('size', 50)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->getLabelPrototype()->setAttribute('class', 'required');
		$form->addSelect('day', 'Den:', $this->days)
			->setRequired();
		$form->addSelect('start_hour', null, $this->hours)
			->setDefaultValue(date('G'));
		$form->addSelect('start_minute', null, $this->minutes);
		$form->addSelect('end_hour', null, $this->hours)
			->setDefaultValue(date('G', strtotime('+1 hour')));
		$form->addSelect('end_minute', null, $this->minutes);
		$form->addTextArea('description', 'Popis:')
			->setAttribute('rows', 10)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->setAttribute('cols', 80);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$form->addText('tutor', 'Lektor:')
			->setAttribute('size', 30);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$form->addText('email', 'E-mail:')
			->setAttribute('size', 30);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$form->addText('capacity', 'Kapacita:')
			->setDefaultValue(0)
			->setAttribute('size', 10)
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->setAttribute('placeholder', 0);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
		$form->addCheckbox('program')
		    ->setDefaultValue(1);
		$form->addCheckbox('display_progs')
			->setDefaultValue(0);
		$form->addSelect('category', 'Kategorie:', $this->buildCategorySelect());

		$form->addHidden('id');
		$form->addHidden('guid');
		$form->addHidden('backlink');

		$form->addSubmit('save', 'Uložit')
			->setAttribute('class', 'btn-primary')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->onClick[] = [$this, 'processForm'];
		$form->addSubmit('reset', 'Storno')
			->setAttribute('class', 'btn-reset')
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
			->onClick[] = [$this, 'processReset'];

		$form = $this->setupRendering($form);

		return $form;
	}

	/**
	 * @param  SubmitButton $button
	 * @return void
	 */
	public function processForm(SubmitButton $button)
	{
		$block = $button->getForm()->getValues();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

		$this->onBlockSave($this, $block);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * @param  SubmitButton $button
	 * @return void
	 */
	public function processReset(SubmitButton $button)
	{
		$block = $button->getForm()->getValues();
interface User
{
    /** @return string */
    public function getPassword();
}

class MyUser implements User
{
    public function getPassword()
    {
        // return something
    }

    public function getDisplayName()
    {
        // return some name.
    }
}

class AuthSystem
{
    public function authenticate(User $user)
    {
        $this->logger->info(sprintf('Authenticating %s.', $user->getDisplayName()));
        // do something.
    }
}

		$this->onBlockReset($this, $block);
class ParentClass {
    private $data = array();

    public function __call($method, array $args) {
        if (0 === strpos($method, 'get')) {
            return $this->data[strtolower(substr($method, 3))];
        }

        throw new \LogicException(sprintf('Unsupported method: %s', $method));
    }
}

/**
 * If this class knows which fields exist, you can specify the methods here:
 *
 * @method string getName()
 */
class SomeClass extends ParentClass { }
	}

	/**
	 * @return array
	 */
	protected function buildCategorySelect(): array

	{
		$categories = $this->getCategoryRepository()->findAll();

		$selectContent = [];

		foreach($categories as $category) {
			$selectContent[$category->id] = $category->name;
		}

		return $selectContent;
	}

    /**
     * @param  BlockEntity $defaults
     * @return BlockEntity
     */
	protected function guardDefaults(BlockEntity $defaults): BlockEntity
    {
        if(!array_key_exists($defaults->category, $this->buildCategorySelect()) )
        {
            $defaults->category = 0;
        }

        return $defaults;
    }

	/**
	 * @return BlockRepository
	 */
	public function getBlockRepository(): BlockRepository
	{
		return $this->blockRepository;
	}

	/**
	 * @param BlockRepository $blockRepository
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
	 *
	 * @return self
	 */
	public function setBlockRepository(BlockRepository $repository): self
	{
		$this->blockRepository = $repository;

		return $this;
	}

	/**
	 * @return CategoryRepository
	 */
	public function getCategoryRepository(): CategoryRepository
	{
		return $this->categoryRepository;
	}

	/**
	 * @param CategoryRepository $categoryRepository
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
	 *
	 * @return self
	 */
	public function setCategoryRepository(CategoryRepository $repository): self
	{
		$this->categoryRepository = $repository;

		return $this;
	}
}


Pull Request — devel (#144)

BlockForm A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

1			<?php
2
3			namespace App\Components\Forms;
4
5			use App\Entities\BlockEntity;
6			use App\Repositories\BlockRepository;
7			use App\Repositories\CategoryRepository;
8			use Nette\Application\UI\Form;
9			use Nette\Forms\Controls\SubmitButton;
10
11			class BlockForm extends BaseForm
12			{
13
14			const TEMPLATE_NAME = 'BlockForm';
15
16			const MESSAGE_REQUIRED = 'Hodnota musí být vyplněna!';
17			const MESSAGE_MAX_LENGTH = '%label nesmí mít více jak %d znaků!';
18
19			/**
20			* @var Closure
21			*/
22			public $onBlockSave;
23
24			/**
25			* @var Closure
26			*/
27			public $onBlockReset;
28
29			/**
30			* @var BlockRepository
31			*/
32			protected $blockRepository;
33
34			/**
35			* @var CategoryRepository
36			*/
37			protected $categoryRepository;
38
39			/**
40			* @var array

literat / srazvs

Pull Request — devel (#144)

BlockForm A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

12 Methods

How to fix Duplicated Code

Duplicated Code

Available Fixes

Available Fixes

Available Fixes

Duplication Side-by-Side

Filter issues like