App\Presenters\AuthPresenter

Complexity

Total Complexity

17

Size/Duplication

Total Lines	189
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	7

Importance

Changes	2
Bugs	0	Features	0

13 Methods

Rating	Name	Duplication	Size	Complexity
A	getAuthService()	0	4	1
A	setAuthService()	0	6	1
A	getUserService()	0	4	1
A	setUserService()	0	6	1
A	__construct()	0	7	1
A	startup()	0	4	1
A	actionLogin()	0	4	1
A	actionLogout()	0	4	1
A	actionSkautis()	0	4	1
A	skautisLogin()	0	4	1
A	skautisLogout()	0	4	1
B	handleSkautisLogin()	0	33	5
A	handleSkautisLogout()	0	15	1

<?php

namespace App\Presenters;

use Skautis;
use SkautisAuth;
use App\Services\SkautIS\AuthService;
use App\Services\SkautIS\UserService;
use Tracy\Debugger;

/**
 * SkautIS Auth presenters.
 */
class AuthPresenter extends BasePresenter
{

	/**
	 * @var AuthService
	 */
	protected $authService;

	/**
	 * @var UserService
	 */
	protected $userService;

	/**
	 * @var User
	 */
	protected $user;

	/**
	 * @param AuthService $authService
	 * @param UserService $userService
	 */
	public function __construct(
		AuthService $authService,
		UserService $userService
	) {
		$this->setAuthService($authService);
		$this->setUserService($userService);
	}

	/**
	 * @return void
	 */
	protected function startup()
	{
		parent::startup();
	}

	/**
	 * @param  string $id
	 * @return void
	 */
	public function actionLogin($id)
	{
		$this->{$id . 'Login'}();
	}

	/**
	 * @param  string $id
	 * @return void
	 */
	public function actionLogout($id)
	{
		$this->{$id . 'Logout'}();
	}

	/**
	 * @param  string $id
	 * @return void
	 */
	public function actionSkautis($id)
	{
		$this->{'handleSkautis' . $id}();
	}

	/**
	 * Redirects to login page
	 *
	 * @param  	string  $backlink
	 * @return  void
	 */
	protected function skautisLogin($backlink = null)
	{
		$this->redirectUrl($this->getAuthService()->getLoginUrl($backlink));
	}

	/**
	 * Handle log out from SkautIS
	 * SkautIS redirects to this action after log out
	 *
	 * @param   void
	 * @return  void
	 */
	protected function skautisLogout()
	{
		$this->redirectUrl($this->getAuthService()->getLogoutUrl());
	}

	/**
	 * Handle SkautIS login process
	 *
	 * @param   string  $ReturnUrl
	 * @return  void
	 */
	protected function handleSkautisLogin($ReturnUrl = NULL)

The parameter $ReturnUrl is not named in camelCase.

	{
		$post = $this->getHttpRequest()->post;

Accessing post on the interface Nette\Http\IRequest suggest that you code against a concrete implementation. How about adding an instanceof check?

		//$post = $this->router->getPost();
		// if token is not set - get out from here - must log in
		if (!isset($post['skautIS_Token'])) {
			$this->redirect(":Login:");
		}
		//Debugger::log("AuthP: ".$post['skautIS_Token']." / ". $post['skautIS_IDRole'] . " / " . $post['skautIS_IDUnit'], "auth");
		try {
			$this->getAuthService()->setInit($post);
			//$this->container->getService('authService')->setInit($post);

			if (!$this->getUserService()->isLoggedIn()) {
			//if (!$this->container->getService('userService')->isLoggedIn()) {
				throw new \Skautis\Wsdl\AuthenticationException("Nemáte platné přihlášení do skautISu");
			}
			$me = $this->getUserService()->getPersonalDetail();
			//$me = $this->container->getService('userService')->getPersonalDetail();

			$this->getUser()->setExpiration('+ 29 minutes'); // nastavíme expiraci
			$this->getUser()->setAuthenticator(new SkautisAuth\SkautisAuthenticator());
			$this->getUser()->login($me);

			if (isset($ReturnUrl)) {
				$this->context->application->restoreRequest($ReturnUrl);

The property $context is declared private in Nette\Application\UI\Presenter. Since you implemented __get(), maybe consider adding a @property or @property-read annotation. This makes it easier for IDEs to provide auto-completion.

			}
		} catch (\Skautis\Wsdl\AuthenticationException $e) {
			$this->flashMessage($e->getMessage(), "danger");
			$this->redirect(":Auth:Login");
		}
		$this->presenter->redirect(':Registration:');
	}

	/**
	 * Log out from SkautIS
	 *
	 * @param   void
	 * @return  void
	 */
	protected function handleSkautisLogout()
	{
		$this->getUserService()->logout(TRUE);

The method logout does not exist on object<App\Services\SkautIS\UserService>? Since you implemented __call, maybe consider adding a @method annotation.

		$this->getUserService()->resetLoginData();
		$this->presenter->flashMessage("Byl jsi úspěšně odhlášen ze SkautISu.");
		/*
		if ($this->request->post['skautIS_Logout']) {
			$this->presenter->flashMessage("Byl jsi úspěšně odhlášen ze SkautISu.");
		} else {
			$this->presenter->flashMessage("Odhlášení ze skautISu se nezdařilo", "danger");
		}
		*/
		$this->redirect(":Login:");
		//$this->redirectUrl($this->service->getLogoutUrl());
	}

	/**
	 * @return AuthService
	 */
	protected function getAuthService()
	{
		return $this->authService;
	}

	/**
	 * @param  AuthService $service
	 * @return $this
	 */
	protected function setAuthService(AuthService $service)
	{
		$this->authService = $service;

		return $this;
	}

	/**
	 * @return UserService
	 */
	protected function getUserService()
	{
		return $this->userService;
	}

	/**
	 * @param  UserService $service
	 * @return $this
	 */
	protected function setUserService(UserService $service)
	{
		$this->userService = $service;

		return $this;
	}

}