litefeel / writing-on-github

lib/client/persist.php

<?php
/**
 * API Persist client.
 * @package Writing_On_GitHub
 */

/**
 * Class Writing_On_GitHub_Persist_Client
 */
class Writing_On_GitHub_Persist_Client extends Writing_On_GitHub_Base_Client {

    /**
     * Get the data for the current user.
     *
     * @return array
     */
    protected function export_user() {
        $user_id = get_current_user_id();
        $user = get_userdata( $user_id );

        if ( $user ) {
            return array(
                'name'  => $user->display_name,
                'email' => $user->user_email,
            );
        }

        return false;

The expression return false returns the type false which is incompatible with the documented return type array.

    }

    /**
     * Delete the file.
     *
     * @return array
     */
    public function delete_file( $path, $sha, $message ) {
        $body = new stdClass();
        $body->message = $message;
        $body->sha = $sha;
        $body->branch = $this->branch();

        if ( $author = $this->export_user() ) {
            $body->author = $author;
        }

        return $this->call( 'DELETE', $this->content_endpoint( $path ), $body );

The expression return $this->call('DELETE', $this->content_endpoint($path), $body) returns the type WP_Error|stdClass which is incompatible with the documented return type array.

$body of type stdClass is incompatible with the type array expected by parameter $body of Writing_On_GitHub_Base_Client::call().

    }

    /**
     * Create the file.
     *
     * @return array
     */
    public function create_file( $blob, $message ) {
        $body = $blob->to_body();
        $body->message = $message;
        $body->branch = $this->branch();
        unset($body->sha);

        if ( $author = $this->export_user() ) {
            $body->author = $author;
        }

        return $this->call( 'PUT', $this->content_endpoint( $blob->path() ), $body );

The expression return $this->call('PUT', $this->content_endpoint($blob->path()), $body) returns the type WP_Error|stdClass which is incompatible with the documented return type array.

    }

    /**
     * Update the file.
     *
     * @return array
     */
    public function update_file( $blob, $message ) {
        $body = $blob->to_body();
        $body->message = $message;
        $body->branch = $this->branch();

        if ( $author = $this->export_user() ) {
            $body->author = $author;
        }

        return $this->call( 'PUT', $this->content_endpoint( $blob->path() ), $body );

The expression return $this->call('PUT', $this->content_endpoint($blob->path()), $body) returns the type WP_Error|stdClass which is incompatible with the documented return type array.

    }
}