Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Writing_On_GitHub_Database often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Writing_On_GitHub_Database, and based on these observations, apply Extract Interface, too.
| 1 | <?php |
||
| 10 | class Writing_On_GitHub_Database { |
||
| 11 | |||
| 12 | /** |
||
| 13 | * Application container. |
||
| 14 | * |
||
| 15 | * @var Writing_On_GitHub |
||
| 16 | */ |
||
| 17 | protected $app; |
||
| 18 | |||
| 19 | /** |
||
| 20 | * Currently whitelisted post types. |
||
| 21 | * |
||
| 22 | * @var array |
||
| 23 | */ |
||
| 24 | protected $whitelisted_post_types = array( 'post', 'page' ); |
||
| 25 | |||
| 26 | /** |
||
| 27 | * Currently whitelisted post statuses. |
||
| 28 | * |
||
| 29 | * @var array |
||
| 30 | */ |
||
| 31 | protected $whitelisted_post_statuses = array( 'publish' ); |
||
| 32 | |||
| 33 | /** |
||
| 34 | * Instantiates a new Database object. |
||
| 35 | * |
||
| 36 | * @param Writing_On_GitHub $app Application container. |
||
| 37 | */ |
||
| 38 | public function __construct( Writing_On_GitHub $app ) { |
||
| 41 | |||
| 42 | /** |
||
| 43 | * Queries the database for all of the supported posts. |
||
| 44 | * |
||
| 45 | * @param bool $force |
||
| 46 | * |
||
| 47 | * @return Writing_On_GitHub_Post[]|WP_Error |
||
| 48 | */ |
||
| 49 | public function fetch_all_supported( $force = false ) { |
||
| 81 | |||
| 82 | /** |
||
| 83 | * Queries a post and returns it if it's supported. |
||
| 84 | * |
||
| 85 | * @param int $post_id Post ID to fetch. |
||
| 86 | * |
||
| 87 | * @return WP_Error|Writing_On_GitHub_Post |
||
| 88 | */ |
||
| 89 | public function fetch_by_id( $post_id ) { |
||
| 107 | |||
| 108 | /** |
||
| 109 | * Save an post to database |
||
| 110 | * and associates their author as well as their latest |
||
| 111 | * |
||
| 112 | * @param Writing_On_GitHub_Post $post [description] |
||
| 113 | * @return WP_Error|true |
||
| 114 | */ |
||
| 115 | public function save_post( Writing_On_GitHub_Post $post ) { |
||
| 159 | |||
| 160 | protected function post_args( $post ) { |
||
| 212 | |||
| 213 | private function get_post_id_by_filename( $filename, $pattern ) { |
||
| 228 | |||
| 229 | /** |
||
| 230 | * Deletes a post from the database based on its GitHub path. |
||
| 231 | * |
||
| 232 | * @param string $path Path of Post to delete. |
||
| 233 | * |
||
| 234 | * @return string|WP_Error |
||
| 235 | */ |
||
| 236 | public function delete_post_by_path( $path ) { |
||
| 296 | |||
| 297 | public function delete_post( $post_id ) { |
||
| 322 | |||
| 323 | /** |
||
| 324 | * Returns the list of post type permitted. |
||
| 325 | * |
||
| 326 | * @return array |
||
| 327 | */ |
||
| 328 | protected function get_whitelisted_post_types() { |
||
| 331 | |||
| 332 | /** |
||
| 333 | * Returns the list of post status permitted. |
||
| 334 | * |
||
| 335 | * @return array |
||
| 336 | */ |
||
| 337 | protected function get_whitelisted_post_statuses() { |
||
| 340 | |||
| 341 | /** |
||
| 342 | * Formats a whitelist array for a query. |
||
| 343 | * |
||
| 344 | * @param array $whitelist Whitelisted posts to format into query. |
||
| 345 | * |
||
| 346 | * @return string Whitelist formatted for query |
||
| 347 | */ |
||
| 348 | protected function format_for_query( $whitelist ) { |
||
| 355 | |||
| 356 | /** |
||
| 357 | * Verifies that both the post's status & type |
||
| 358 | * are currently whitelisted |
||
| 359 | * |
||
| 360 | * @param Writing_On_GitHub_Post $post Post to verify. |
||
| 361 | * |
||
| 362 | * @return boolean True if supported, false if not. |
||
| 363 | */ |
||
| 364 | protected function is_post_supported( Writing_On_GitHub_Post $post ) { |
||
| 384 | |||
| 385 | /** |
||
| 386 | * Retrieves the commit user for a provided display name |
||
| 387 | * |
||
| 388 | * Searches for a user with provided display name or returns |
||
| 389 | * the default user saved in the database. |
||
| 390 | * |
||
| 391 | * @param string $display_name User display name to search for. |
||
| 392 | * |
||
| 393 | * @return WP_Error|WP_User |
||
| 394 | */ |
||
| 395 | protected function fetch_commit_user( $display_name ) { |
||
| 431 | |||
| 432 | // /** |
||
| 433 | // * Sets the author latest revision |
||
| 434 | // * of the provided post ID to the provided user. |
||
| 435 | // * |
||
| 436 | // * @param int $post_id Post ID to update revision author. |
||
| 437 | // * @param int $user_id User ID for revision author. |
||
| 438 | // * |
||
| 439 | // * @return string|WP_Error |
||
| 440 | // */ |
||
| 441 | // protected function set_revision_author( $post_id, $user_id ) { |
||
| 442 | // $revision = wp_get_post_revisions( $post_id ); |
||
| 443 | |||
| 444 | // if ( ! $revision ) { |
||
| 445 | // $new_revision = wp_save_post_revision( $post_id ); |
||
| 446 | |||
| 447 | // if ( ! $new_revision || is_wp_error( $new_revision ) ) { |
||
| 448 | // return new WP_Error( 'db_error', 'There was a problem saving a new revision.' ); |
||
| 449 | // } |
||
| 450 | |||
| 451 | // // `wp_save_post_revision` returns the ID, whereas `get_post_revision` returns the whole object |
||
| 452 | // // in order to be consistent, let's make sure we have the whole object before continuing. |
||
| 453 | // $revision = get_post( $new_revision ); |
||
| 454 | |||
| 455 | // if ( ! $revision ) { |
||
| 456 | // return new WP_Error( 'db_error', 'There was a problem retrieving the newly recreated revision.' ); |
||
| 457 | // } |
||
| 458 | // } else { |
||
| 459 | // $revision = array_shift( $revision ); |
||
| 460 | // } |
||
| 461 | |||
| 462 | // return $this->set_post_author( $revision->ID, $user_id ); |
||
| 463 | // } |
||
| 464 | |||
| 465 | /** |
||
| 466 | * Updates the user ID for the provided post ID. |
||
| 467 | * |
||
| 468 | * Bypassing triggering any hooks, including creating new revisions. |
||
| 469 | * |
||
| 470 | * @param int $post_id Post ID to update. |
||
| 471 | * @param int $user_id User ID to update to. |
||
| 472 | * |
||
| 473 | * @return string|WP_Error |
||
| 474 | */ |
||
| 475 | protected function set_post_author( $post_id, $user_id ) { |
||
| 508 | |||
| 509 | // * |
||
| 510 | // * Update the provided post's blob sha. |
||
| 511 | // * |
||
| 512 | // * @param Writing_On_GitHub_Post $post Post to update. |
||
| 513 | // * @param string $sha Sha to update to. |
||
| 514 | // * |
||
| 515 | // * @return bool|int |
||
| 516 | |||
| 517 | // public function set_post_sha( $post, $sha ) { |
||
| 518 | // return update_post_meta( $post->id, '_wogh_sha', $sha ); |
||
| 519 | // } |
||
| 520 | } |
||
| 521 |