Writing_On_GitHub_Import::compare() - Code Metrics - Inspection of "5" - litefeel/writing-on-github - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — ci ( 38d7bc...9f72b5 )

by litefeel

created 2017-08-10 08:41 UTC

Writing_On_GitHub_Import::compare() D

↳ Parent: Writing_On_GitHub_Import

Complexity

Conditions	18
Paths	241

Size

Total Lines	73
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	0
CRAP Score	342

Importance

Changes

Metric	Value
dl	0
loc	73
ccs	0
cts	47
cp	0
rs	4.2411
c	0
b	0
f	0
cc	18
eloc	39
nc	241
nop	2
crap	342

How to fix Long Method Complexity

<?php
/**
 * GitHub Import Manager
 *
 * @package Writing_On_GitHub
 */

/**
 * Class Writing_On_GitHub_Import
 */
class Writing_On_GitHub_Import {

	/**
	 * Application container.
	 *
	 * @var Writing_On_GitHub
	 */
	protected $app;

	/**
	 * Initializes a new import manager.
	 *
	 * @param Writing_On_GitHub $app Application container.
	 */
	public function __construct( Writing_On_GitHub $app ) {
		$this->app = $app;
	}

    /**
     * Imports a payload.
     * @param  Writing_On_GitHub_Payload $payload
     *
     * @return string|WP_Error
     */
	public function payload( Writing_On_GitHub_Payload $payload ) {


		$result = $this->app->api()->fetch()->compare( $payload->get_before_commit_id() );

		if ( is_wp_error( $result ) ) {
            /* @var WP_Error $result */
			return $result;
		}

		$result = $this->import_files( $result );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		if ( is_wp_error( $result ) ) {
			return $files;
		}

		return __( 'Payload processed', 'writing-on-github' );
	}

	/**
	 * import blob by files
	 * @param  Writing_On_GitHub_File_Info[] $files
     *
	 * @return string|WP_Error

	 */
	protected function import_files( $files ) {

		$error 		= false;
		$delete_ids = false;

		$result = $this->compare( $files, $delete_ids );

		if ( is_wp_error( $result ) ) {
			return $result;
		}

		if ( $delete_ids ) {
			foreach ($delete_ids as $id) {

				$result = $this->app->database()->delete_post( $id );
				if ( is_wp_error( $result ) ) {
					if ( $error ) {
						$error->add( $result->get_error_code(), $result->get_error_message() );
					} else {
						$error = $result;
					}
				}
			}
		}

		return $error;
	}

	/**
	 * Imports the latest commit on the master branch.
	 *
	 * @return string|WP_Error
	 */
	public function master() {

		$result = $this->app->api()->fetch()->tree_recursive();

		if ( is_wp_error( $result ) ) {
            /* @var WP_Error $result */
			return $result;
		}

		$result = $this->import_files( $result );
/**
 * @return array|string
 */
function returnsDifferentValues($x) {
    if ($x) {
        return 'foo';
    }

    return array();
}

$x = returnsDifferentValues($y);
if (is_array($x)) {
    // $x is an array.
}

		if ( is_wp_error( $result ) ) {
			return $result;
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
		}

		return __( 'Payload processed', 'writing-on-github' );
	}

    /**
     * Do compare
     * @param  Writing_On_GitHub_File_Info[]|WP_Error $files
     * @param  int[] &$delete_ids
     *
     * @return string|WP_Error

     */
	protected function compare( $files, &$delete_ids ) {

		if ( is_wp_error( $files ) ) {
            /* @var WP_Error $files */
			return $files;
		}

		$posts = array();
		$new   = array();

		$idsmap = array();

		foreach ( $files as $file ) {
			if ( ! $this->importable_file( $file ) ) {
				continue;
			}

			$blob = $this->app->api()->fetch()->blob( $file );
			// network error ?
			if ( ! $blob instanceof Writing_On_GitHub_Blob ) {
				continue;
			}

			if ( $this->importable_raw_file( $blob ) ) {
				$this->import_raw_file( $blob, $file->status == 'removed' );
				continue;
			}

			if ( ! $this->importable_blob( $blob ) ) {
				continue;
			}

			$post = $this->blob_to_post( $blob );

			if ( $file->status == 'removed' ) {

				if ( $blob->id() ) {
					$idsmap[$blob->id()] = true;

				}
			} elseif ( $post != false ) {

				$posts[] = $post;
				if ( $post->is_new() ) {
					$new[] = $post;
				}
			}
		}

		foreach ( $posts as $post ) {
			if ( $post->id() && isset( $idsmap[ $post->id() ] ) ) {
				unset( $idsmap[ $post->id() ] );
			}
		}
		$delete_ids = array();
		foreach ( $idsmap as $id => $value ) {
			$delete_ids[] = $id;
		}

		// $this->app->database()->save_posts( $posts, $commit->author_email() );

		$result = $this->app->database()->save_posts( $posts );

		if ( is_wp_error( $result ) ) {
			return $result;
		}

		if ( ! empty( $new ) ) {
			$result = $this->app->export()->new_posts( $new );

			if ( is_wp_error( $result ) ) {
				return $result;
			}
		}

		return $posts;
	}

	/**
	 * Checks whether the provided blob should be imported.
	 *
	 * @param Writing_On_GitHub_File_Info $file
	 *
	 * @return bool
	 */
	protected function importable_file( Writing_On_GitHub_File_Info $file ) {

		// only _pages and _posts
		if ( strncasecmp($file->path, '_pages/', strlen('_pages/') ) != 0 &&

			 strncasecmp($file->path, '_posts/', strlen('_posts/') ) != 0 &&

			 strncasecmp($file->path, 'images/', strlen('images/') ) != 0 ) {

			return false;
		}



		// if ( ! $file->has_frontmatter() ) {
		// 	return false;
		// }

		return true;
	}

	/**
	 * Checks whether the provided blob should be imported.
	 *
	 * @param Writing_On_GitHub_Blob $blob Blob to validate.
	 *
	 * @return bool
	 */
	protected function importable_blob( Writing_On_GitHub_Blob $blob ) {
		// global $wpdb;

		// // Skip the repo's readme.
		// if ( 'readme' === strtolower( substr( $blob->path(), 0, 6 ) ) ) {
		// 	return false;
		// }

		// // If the blob sha already matches a post, then move on.
		// if ( ! is_wp_error( $this->app->database()->fetch_by_sha( $blob->sha() ) ) ) {
		// 	return false;
		// }

		if ( ! $blob->has_frontmatter() ) {

			return false;
		}

		return true;
	}

	protected function importable_raw_file( Writing_On_GitHub_Blob $blob ) {
		if ( $blob->has_frontmatter() ) {
			return false;
		}

		// only images
		if ( strncasecmp($blob->path(), 'images/', strlen('images/') ) != 0) {

			return false;
		}

		return true;
	}

	/**
	 * Imports a raw file content into file system.
	 * @param  Writing_On_GitHub_Blob $blob
	 * @param  bool                   $is_remove
	 */
	protected function import_raw_file( Writing_On_GitHub_Blob $blob, $is_remove ) {
		$arr = wp_upload_dir();
		$path = $arr['basedir'] . '/writing-on-github/' . $blob->path();
		if ( $is_remove ) {
			if ( file_exists($path) ) {

				unlink($path);

			}
		} else {
			$dirname = dirname($path);

			if ( ! file_exists($dirname) ) {

				wp_mkdir_p($dirname);

			}

			file_put_contents($path, $blob->content());

		}
	}

	/**
	 * Imports a single blob content into matching post.
	 *
	 * @param Writing_On_GitHub_Blob $blob Blob to transform into a Post.
	 *
	 * @return Writing_On_GitHub_Post|false
	 */
	protected function blob_to_post( Writing_On_GitHub_Blob $blob ) {

		$args = array( 'post_content' => $blob->content_import() );
		$meta = $blob->meta();

		$id = false;

		if ( ! empty( $meta ) ) {
			if ( array_key_exists( 'layout', $meta ) ) {
				$args['post_type'] = $meta['layout'];
				unset( $meta['layout'] );
			}

			if ( array_key_exists( 'published', $meta ) ) {
				$args['post_status'] = true === $meta['published'] ? 'publish' : 'draft';
				unset( $meta['published'] );
			}

			if ( array_key_exists( 'post_title', $meta ) ) {
				$args['post_title'] = $meta['post_title'];
				unset( $meta['post_title'] );
			}

			if ( array_key_exists( 'post_name', $meta ) ) {
				$args['post_name'] = $meta['post_name'];
				unset( $meta['post_name'] );
			}

			if ( array_key_exists( 'ID', $meta ) ) {
				$id = $args['ID'] = $meta['ID'];
				$blob->set_id($id);

				unset( $meta['ID'] );
			}
		}

		$meta['_wogh_sha'] = $blob->sha();

		if ( $id ) {
			$old_sha = get_post_meta( $id, '_wogh_sha', true );
			$old_github_path = get_post_meta( $id, '_wogh_github_path', true );

			// dont save post when has same sha
			if ( $old_sha  && $old_sha == $meta['_wogh_sha'] &&
				 $old_github_path && $old_github_path == $blob->path() ) {
				return false;
			}
		}

		$post = new Writing_On_GitHub_Post( $args, $this->app->api() );
		$post->set_old_github_path( $blob->path() );
		$post->set_meta( $meta );
		$blob->set_id( $post->id() );

		return $post;
	}
}


1		<?php
2		/**
3		* GitHub Import Manager
4		*
5		* @package Writing_On_GitHub
6		*/
7
8		/**
9		* Class Writing_On_GitHub_Import
10		*/
11		class Writing_On_GitHub_Import {
12
13		/**
14		* Application container.
15		*
16		* @var Writing_On_GitHub
17		*/
18		protected $app;
19
20		/**
21		* Initializes a new import manager.
22		*
23		* @param Writing_On_GitHub $app Application container.
24		*/
25		public function __construct( Writing_On_GitHub $app ) {
26		$this->app = $app;
27		}
28
29		/**
30		* Imports a payload.
31		* @param Writing_On_GitHub_Payload $payload
32		*
33		* @return string\|WP_Error
34		*/
35	View Code Duplication	public function payload( Writing_On_GitHub_Payload $payload ) {
		0 ignored issues – show Duplication introduced 2017-08-08 01:39 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
36
37		$result = $this->app->api()->fetch()->compare( $payload->get_before_commit_id() );
38
39		if ( is_wp_error( $result ) ) {

litefeel / writing-on-github

Push — ci ( 38d7bc...9f72b5 )

Writing_On_GitHub_Import::compare() D

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like