Duplicate code is one of the most pungent code smells. A rule that is often used is to re-structure code once it is duplicated in three or more places.
Common duplication problems, and corresponding solutions are:
Complex classes like Writing_On_GitHub_Database often do a lot of different things. To break such a class down, we need to identify a cohesive component within that class. A common approach to find such a component is to look for fields/methods that share the same prefixes, or suffixes.
Once you have determined the fields that belong together, you can apply the Extract Class refactoring. If the component makes sense as a sub-class, Extract Subclass is also a candidate, and is often faster.
While breaking up the class, it is a good idea to analyze how other classes use Writing_On_GitHub_Database, and based on these observations, apply Extract Interface, too.
1 | <?php |
||
10 | class Writing_On_GitHub_Database { |
||
11 | |||
12 | /** |
||
13 | * Application container. |
||
14 | * |
||
15 | * @var Writing_On_GitHub |
||
16 | */ |
||
17 | protected $app; |
||
18 | |||
19 | /** |
||
20 | * Currently whitelisted post types. |
||
21 | * |
||
22 | * @var array |
||
23 | */ |
||
24 | protected $whitelisted_post_types = array( 'post', 'page' ); |
||
25 | |||
26 | /** |
||
27 | * Currently whitelisted post statuses. |
||
28 | * |
||
29 | * @var array |
||
30 | */ |
||
31 | protected $whitelisted_post_statuses = array( 'publish' ); |
||
32 | |||
33 | /** |
||
34 | * Instantiates a new Database object. |
||
35 | * |
||
36 | * @param Writing_On_GitHub $app Application container. |
||
37 | */ |
||
38 | public function __construct( Writing_On_GitHub $app ) { |
||
41 | |||
42 | /** |
||
43 | * Queries the database for all of the supported posts. |
||
44 | * |
||
45 | * @param bool $force |
||
46 | * |
||
47 | * @return Writing_On_GitHub_Post[]|WP_Error |
||
48 | */ |
||
49 | public function fetch_all_supported( $force = false ) { |
||
81 | |||
82 | /** |
||
83 | * Queries a post and returns it if it's supported. |
||
84 | * |
||
85 | * @param int $post_id Post ID to fetch. |
||
86 | * |
||
87 | * @return WP_Error|Writing_On_GitHub_Post |
||
88 | */ |
||
89 | public function fetch_by_id( $post_id ) { |
||
107 | |||
108 | /** |
||
109 | * Saves an array of Post objects to the database |
||
110 | * and associates their author as well as their latest |
||
111 | * |
||
112 | * @param Writing_On_GitHub_Post[] $posts Array of Posts to save. |
||
113 | * |
||
114 | * @return string|WP_Error |
||
115 | */ |
||
116 | public function save_posts( array $posts ) { |
||
176 | |||
177 | protected function post_args( $post ) { |
||
229 | |||
230 | private function get_post_id_by_filename( $filename, $pattern ) { |
||
245 | |||
246 | /** |
||
247 | * Deletes a post from the database based on its GitHub path. |
||
248 | * |
||
249 | * @param string $path Path of Post to delete. |
||
250 | * |
||
251 | * @return string|WP_Error |
||
252 | */ |
||
253 | public function delete_post_by_path( $path ) { |
||
313 | |||
314 | public function delete_post( $post_id ) { |
||
339 | |||
340 | /** |
||
341 | * Returns the list of post type permitted. |
||
342 | * |
||
343 | * @return array |
||
344 | */ |
||
345 | protected function get_whitelisted_post_types() { |
||
348 | |||
349 | /** |
||
350 | * Returns the list of post status permitted. |
||
351 | * |
||
352 | * @return array |
||
353 | */ |
||
354 | protected function get_whitelisted_post_statuses() { |
||
357 | |||
358 | /** |
||
359 | * Formats a whitelist array for a query. |
||
360 | * |
||
361 | * @param array $whitelist Whitelisted posts to format into query. |
||
362 | * |
||
363 | * @return string Whitelist formatted for query |
||
364 | */ |
||
365 | protected function format_for_query( $whitelist ) { |
||
372 | |||
373 | /** |
||
374 | * Verifies that both the post's status & type |
||
375 | * are currently whitelisted |
||
376 | * |
||
377 | * @param Writing_On_GitHub_Post $post Post to verify. |
||
378 | * |
||
379 | * @return boolean True if supported, false if not. |
||
380 | */ |
||
381 | protected function is_post_supported( Writing_On_GitHub_Post $post ) { |
||
401 | |||
402 | /** |
||
403 | * Retrieves the commit user for a provided display name |
||
404 | * |
||
405 | * Searches for a user with provided display name or returns |
||
406 | * the default user saved in the database. |
||
407 | * |
||
408 | * @param string $display_name User display name to search for. |
||
409 | * |
||
410 | * @return WP_Error|WP_User |
||
411 | */ |
||
412 | protected function fetch_commit_user( $display_name ) { |
||
448 | |||
449 | // /** |
||
450 | // * Sets the author latest revision |
||
451 | // * of the provided post ID to the provided user. |
||
452 | // * |
||
453 | // * @param int $post_id Post ID to update revision author. |
||
454 | // * @param int $user_id User ID for revision author. |
||
455 | // * |
||
456 | // * @return string|WP_Error |
||
457 | // */ |
||
458 | // protected function set_revision_author( $post_id, $user_id ) { |
||
459 | // $revision = wp_get_post_revisions( $post_id ); |
||
460 | |||
461 | // if ( ! $revision ) { |
||
462 | // $new_revision = wp_save_post_revision( $post_id ); |
||
463 | |||
464 | // if ( ! $new_revision || is_wp_error( $new_revision ) ) { |
||
465 | // return new WP_Error( 'db_error', 'There was a problem saving a new revision.' ); |
||
466 | // } |
||
467 | |||
468 | // // `wp_save_post_revision` returns the ID, whereas `get_post_revision` returns the whole object |
||
469 | // // in order to be consistent, let's make sure we have the whole object before continuing. |
||
470 | // $revision = get_post( $new_revision ); |
||
471 | |||
472 | // if ( ! $revision ) { |
||
473 | // return new WP_Error( 'db_error', 'There was a problem retrieving the newly recreated revision.' ); |
||
474 | // } |
||
475 | // } else { |
||
476 | // $revision = array_shift( $revision ); |
||
477 | // } |
||
478 | |||
479 | // return $this->set_post_author( $revision->ID, $user_id ); |
||
480 | // } |
||
481 | |||
482 | /** |
||
483 | * Updates the user ID for the provided post ID. |
||
484 | * |
||
485 | * Bypassing triggering any hooks, including creating new revisions. |
||
486 | * |
||
487 | * @param int $post_id Post ID to update. |
||
488 | * @param int $user_id User ID to update to. |
||
489 | * |
||
490 | * @return string|WP_Error |
||
491 | */ |
||
492 | protected function set_post_author( $post_id, $user_id ) { |
||
525 | |||
526 | // * |
||
527 | // * Update the provided post's blob sha. |
||
528 | // * |
||
529 | // * @param Writing_On_GitHub_Post $post Post to update. |
||
530 | // * @param string $sha Sha to update to. |
||
531 | // * |
||
532 | // * @return bool|int |
||
533 | |||
534 | // public function set_post_sha( $post, $sha ) { |
||
535 | // return update_post_meta( $post->id, '_wogh_sha', $sha ); |
||
536 | // } |
||
537 | } |
||
538 |