EmailDriver::__construct() - Code Metrics - Inspection of "Refactor loggers" - linpax/microphp-framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 856966...11e739 )

by Oleg

created 2016-05-13 07:45 UTC

EmailDriver::__construct() A

↳ Parent: EmailDriver

Complexity

Conditions	4
Paths	8

Size

Total Lines	8
Code Lines	5

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
rs	9.2
cc	4
eloc	5
nc	8
nop	2

<?php /** MicroEmailDriver */

namespace Micro\Logger\Driver;

use Micro\Base\IContainer;
use Micro\Mail\Message;

/**
 * EmailDriver logger class file.
 *
 * Sender email for logger
 *
 * @author Oleg Lunegov <[email protected]>
 * @link https://github.com/linpax/microphp-framework
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Logger\Driver
 * @version 1.0
 * @since 1.0
 */
class EmailDriver extends LoggerDriver
{
    /** @var string $from email for sender attribute */
    private $from;
    /** @var string $type message attribute */
    private $type = 'text/plain';
    /** @var string $to message recipient */
    private $to;
    /** @var string $subject message theme */
    private $subject;


    /**
     * Constructor is a initialize logger
     *
     * @access public
     *
     * @param IContainer $container Container
     * @param array $params configuration params
     *
     * @throws \Micro\Base\Exception
     * @result void
     */
    public function __construct(IContainer $container, array $params = [])
    {
        parent::__construct($container, $params);

        $this->from = !empty($params['from']) ? $params['from'] : getenv('SERVER_ADMIN');
        $this->to = !empty($params['to']) ? $params['to'] : $this->from;
        $this->subject = $params['subject'] ?: getenv('SERVER_NAME').' log message';
    }

    /**
     * Send message in log
     *
     * @access public
     *
     * @param integer $level level number
     * @param string $message message to write
     *
     * @result void
     * @throws \Micro\Base\Exception
     */
    public function sendMessage($level, $message)
    {
        $mail = new Message($this->from);

        $mail->setTo($this->to);
        $mail->setText(ucfirst($level).': '.$message, $this->type);

        $this->container->mail->send($mail);
interface SomeInterface { }
class SomeClass implements SomeInterface {
    public $a;
}

function someFunction(SomeInterface $object) {
    if ($object instanceof SomeClass) {
        $a = $object->a;
    }
}
    }
}


1			<?php /** MicroEmailDriver */
2
3			namespace Micro\Logger\Driver;
4
5			use Micro\Base\IContainer;
6			use Micro\Mail\Message;
7
8			/**
9			* EmailDriver logger class file.
10			*
11			* Sender email for logger
12			*
13			* @author Oleg Lunegov <[email protected]>
14			* @link https://github.com/linpax/microphp-framework
15			* @copyright Copyright © 2013 Oleg Lunegov
16			* @license /LICENSE
17			* @package Micro
18			* @subpackage Logger\Driver
19			* @version 1.0
20			* @since 1.0
21			*/
22			class EmailDriver extends LoggerDriver
23			{
24			/** @var string $from email for sender attribute */
25			private $from;
26			/** @var string $type message attribute */
27			private $type = 'text/plain';
28			/** @var string $to message recipient */
29			private $to;
30			/** @var string $subject message theme */
31			private $subject;
32
33
34			/**
35			* Constructor is a initialize logger
36			*
37			* @access public
38			*
39			* @param IContainer $container Container
40			* @param array $params configuration params
41			*
42			* @throws \Micro\Base\Exception
43			* @result void
44			*/
45			public function __construct(IContainer $container, array $params = [])
46			{
47			parent::__construct($container, $params);
48
49			$this->from = !empty($params['from']) ? $params['from'] : getenv('SERVER_ADMIN');
50			$this->to = !empty($params['to']) ? $params['to'] : $this->from;
51			$this->subject = $params['subject'] ?: getenv('SERVER_NAME').' log message';
52			}
53
54			/**
55			* Send message in log
56			*
57			* @access public
58			*
59			* @param integer $level level number
60			* @param string $message message to write
61			*
62			* @result void
63			* @throws \Micro\Base\Exception
64			*/
65			public function sendMessage($level, $message)
66			{
67			$mail = new Message($this->from);
68
69			$mail->setTo($this->to);
70			$mail->setText(ucfirst($level).': '.$message, $this->type);
71
72			$this->container->mail->send($mail);
			0 ignored issues – show Bug introduced 2016-03-10 20:06 UTC by Report Bug Copy Issue Report Accessing `mail` on the interface `Micro\Base\IContainer` suggest that you code against a concrete implementation. How about adding an `instanceof` check? If you access a property on an interface, you most likely code against a concrete implementation of the interface. Available Fixes Adding an additional type check: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeInterface $object) { if ($object instanceof SomeClass) { $a = $object->a; } } Changing the type hint: interface SomeInterface { } class SomeClass implements SomeInterface { public $a; } function someFunction(SomeClass $object) { $a = $object->a; } Loading history...
73			}
74			}
75

linpax / microphp-framework

Push — master ( 856966...11e739 )

EmailDriver::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like