Micro\Auth\Drivers\FileAcl

Complexity

Total Complexity

14

Size/Duplication

Total Lines	97
Duplicated Lines	10.31 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	9	5
B	check()	0	19	7
A	assigned()	10	10	1
A	rolePerms()	0	4	1

<?php /** MicroFileACL */

namespace Micro\Auth\Drivers;

use Micro\Db\IConnection;
use Micro\Mvc\Models\Query;

/**
 * File ACL class file.
 *
 * ACL security with files.
 *
 * @author Oleg Lunegov <testuser@mail.linpax.org>
 * @link https://github.com/linpax/microphp-framework
 * @copyright Copyright (c) 2013 Oleg Lunegov
 * @license https://github.com/linpax/microphp-framework/blob/master/LICENSE
 * @package Micro
 * @subpackage Auth\Drivers
 * @version 1.0
 * @since 1.0
 */
class FileAcl extends Acl
{
    /** @var array $roles configured roles */
    protected $roles;
    /** @var array $perms configured perms */
    protected $perms;
    /** @var array $rolePermsCompare compare of permissions in roles */
    protected $rolePermsCompare;


    /**
     * Configured ACL with files
     *
     * @access public
     *
     * @param IConnection $db
     * @param array $params configuration array
     *
     * @result void
     */
    public function __construct(IConnection $db, array $params = [])
    {
        parent::__construct($db, $params);

        $roles = !empty($params['roles']) ? $params['roles'] : [];
        $this->roles = !empty($roles['roles']) ? $roles['roles'] : [];
        $this->perms = !empty($roles['perms']) ? $roles['perms'] : [];
        $this->rolePermsCompare = !empty($roles['role_perms']) ? $roles['role_perms'] : [];
    }

    /**
     * Check user access to permission
     *
     * @access public
     *
     * @param integer $userId user id
     * @param string $permission checked permission
     * @param array $data not used, added for compatible!
     *
     * @return bool
     * @throws \Micro\Base\Exception
     */
    public function check($userId, $permission, array $data = [])
    {
        $permissionId = in_array($permission, $this->perms, true);
        /** @var array $assigned */
        $assigned = $this->assigned($userId);
        if (!$assigned) {

The expression $assigned of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return false;
        }

        foreach ($assigned AS $assign) {
            if ($assign['perm'] && $assign['perm'] === $permissionId) {
                return true;
            } elseif ($assign['role'] && in_array($permissionId, $this->rolePerms($assign['role']), true)) {
                return true;
            }
        }

        return false;
    }

    /**
     * Get assigned elements
     *
     * @access public
     *
     * @param integer $userId user ID
     *
     * @return mixed
     * @throws \Micro\Base\Exception
     */
    public function assigned($userId)

This method seems to be duplicated in your project.

    {
        $query = new Query($this->db);
        $query->select = '*';
        $query->table = 'acl_user';
        $query->addWhere('`user`='.$userId);
        $query->single = false;

        return $query->run();
    }

    /**
     * Get permissions in role
     *
     * @access private
     *
     * @param integer $role role name
     *
     * @return array
     */
    protected function rolePerms($role)
    {
        return $this->rolePermsCompare[$role];
    }
}