Dispatcher::signal() - Code Metrics - Inspection of "fix dispatcher" - linpax/microphp-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( e9d652...51f80a )

by Oleg

created 2016-07-25 19:29 UTC

Dispatcher::signal() B

↳ Parent: Dispatcher

Complexity

Conditions	5
Paths	3

Size

Total Lines	17
Code Lines	8

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	1	Features	0

Metric	Value
c	1
b	1
f	0
dl	0
loc	17
rs	8.8571
cc	5
eloc	8
nc	3
nop	2

<?php /** MicroDispatcher */

namespace Micro\Base;

use Micro\Web\IResponse;

/**
 * Dispatcher class file.
 *
 * @author Oleg Lunegov <[email protected]>
 * @link https://github.com/linpax/microphp-framework
 * @copyright Copyright (c) 2013 Oleg Lunegov
 * @license https://github.com/linpax/microphp-framework/blob/master/LICENSE
 * @package Micro
 * @subpackage Base
 * @version 1.0
 * @since 1.0
 */
class Dispatcher implements IDispatcher
{
    /** @var array $listeners Listeners objects on events */
    protected $listeners = [];


    /**
     * Add listener on event
     *
     * @access public
     *
     * @param string $listener listener name
     * @param array $event ['Object', 'method'] or callable
     * @param int|null $prior priority
     *
     * @return bool
     */
    public function addListener($listener, $event, $prior = null)
    {
        if (!is_callable($event)) {
            return false;
        }

        if (!array_key_exists($listener, $this->listeners)) {
            $this->listeners[$listener] = [];
        }

        if (!$prior) {
0   == false // true
0   == null  // true
123 == false // false
123 == null  // false

// It is often better to use strict comparison
0 === false // false
0 === null  // false
            $this->listeners[$listener][] = $event;
        } else {
            array_splice($this->listeners[$listener], $prior, 0, $event);
        }

        return true;
    }

    /**
     * Send signal to run event
     *
     * @access public
     *
     * @param string $listener listener name
     * @param array $params Signal parameters
     *
     * @return mixed
     */
    public function signal($listener, array $params = [])
    {
        $result = null;

        if (array_key_exists($listener, $this->listeners) && 0 !== count($this->listeners[$listener])) {
            /** @noinspection ForeachSourceInspection */
            foreach ($this->listeners[$listener] as $listen) {
                $result = call_user_func($listen, $params);

                if ($result instanceof IResponse) {
                    return $result;
                }
            }
        }

        return $result;
    }
}


1			<?php /** MicroDispatcher */
2
3			namespace Micro\Base;
4
5			use Micro\Web\IResponse;
6
7			/**
8			* Dispatcher class file.
9			*
10			* @author Oleg Lunegov <[email protected]>
11			* @link https://github.com/linpax/microphp-framework
12			* @copyright Copyright (c) 2013 Oleg Lunegov
13			* @license https://github.com/linpax/microphp-framework/blob/master/LICENSE
14			* @package Micro
15			* @subpackage Base
16			* @version 1.0
17			* @since 1.0
18			*/
19			class Dispatcher implements IDispatcher
20			{
21			/** @var array $listeners Listeners objects on events */
22			protected $listeners = [];
23
24
25			/**
26			* Add listener on event
27			*
28			* @access public
29			*
30			* @param string $listener listener name
31			* @param array $event ['Object', 'method'] or callable
32			* @param int\|null $prior priority
33			*
34			* @return bool
35			*/
36			public function addListener($listener, $event, $prior = null)
37			{
38			if (!is_callable($event)) {
39			return false;
40			}
41
42			if (!array_key_exists($listener, $this->listeners)) {
43			$this->listeners[$listener] = [];
44			}
45
46			if (!$prior) {
			0 ignored issues – show Bug Best Practice introduced 2016-03-10 20:06 UTC by Report Bug Copy Issue Report The expression `$prior` of type `integer\|null` is loosely compared to `false`; this is ambiguous if the integer can be zero. You might want to explicitly use `=== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `integer` values, zero is a special case, in particular the following results might be unexpected: 0 == false // true 0 == null // true 123 == false // false 123 == null // false // It is often better to use strict comparison 0 === false // false 0 === null // false Loading history...
47			$this->listeners[$listener][] = $event;
48			} else {
49			array_splice($this->listeners[$listener], $prior, 0, $event);
50			}
51
52			return true;
53			}
54
55			/**
56			* Send signal to run event
57			*
58			* @access public
59			*
60			* @param string $listener listener name
61			* @param array $params Signal parameters
62			*
63			* @return mixed
64			*/
65			public function signal($listener, array $params = [])
66			{
67			$result = null;
68
69			if (array_key_exists($listener, $this->listeners) && 0 !== count($this->listeners[$listener])) {
70			/** @noinspection ForeachSourceInspection */
71			foreach ($this->listeners[$listener] as $listen) {
72			$result = call_user_func($listen, $params);
73
74			if ($result instanceof IResponse) {
75			return $result;
76			}
77			}
78			}
79
80			return $result;
81			}
82			}
83

linpax / microphp-framework

Push — master ( e9d652...51f80a )

Dispatcher::signal() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like