DbConnection::insert() - Code Metrics - Inspection of "refactoring" - linpax/microphp-framework - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 9f36d5...158df7 )

by Oleg

created 2016-05-29 16:56 UTC

DbConnection::insert() B

↳ Parent: DbConnection

Complexity

Conditions	8
Paths	6

Size

Total Lines	21
Code Lines	15

Duplication

Lines	0
Ratio	0 %

Importance

Changes	2
Bugs	1	Features	0

Metric	Value
c	2
b	1
f	0
dl	0
loc	21
rs	7.1428
cc	8
eloc	15
nc	6
nop	3

<?php /** MicroDataBaseConnection */

namespace Micro\Db;

use Micro\Base\Exception;

/**
 * Connection class file.
 *
 * @author Oleg Lunegov <[email protected]>
 * @link https://github.com/linpax/microphp-framework
 * @copyright Copyright &copy; 2013 Oleg Lunegov
 * @license /LICENSE
 * @package Micro
 * @subpackage Db
 * @version 1.0
 * @since 1.0
 */
class DbConnection extends Connection
{
    /** @var \PDO|null $conn Connection to DB */
    protected $conn;


    /**
     * Construct for this class
     *
     * @access public
     *
     * @param array $config
     * @param array $options
     *
     * @result void
     * @throws Exception
     */
    public function __construct(array $config = [], array $options = [])
    {
        parent::__construct();

        try {
            $this->conn = new \PDO($config['connectionString'], $config['username'], $config['password'],
                    $options
                );
        } catch (\PDOException $e) {
            if (!array_key_exists('ignoreFail', $config) || !$config['ignoreFail']) {
                throw new Exception('Connect to DB failed: '.$e->getMessage());
            }
        }
    }

    /**
     * Destructor for this class
     *
     * @access public
     * @return void
     */
    public function __destruct()
    {
        $this->conn = null;
    }

    /**
     * @inheritdoc
     */
    public function rawQuery($query = '', array $params = [], $fetchType = \PDO::FETCH_ASSOC, $fetchClass = 'Model')
    {
        $sth = $this->conn->prepare($query);

        if ($fetchType === \PDO::FETCH_CLASS) {
            /** @noinspection PhpMethodParametersCountMismatchInspection */
            $sth->setFetchMode($fetchType, ucfirst($fetchClass), ['new' => false]);
        } else {
            $sth->setFetchMode($fetchType);
        }

        foreach ($params AS $name => $value) {
            $sth->bindValue($name, $value);
        }

        $sth->execute();

        return $sth->fetchAll();
    }

    /**
     * @inheritdoc
     */
    public function listDatabases()
    {
        $sth = $this->conn->query('SHOW DATABASES;');

        $result = [];
        foreach ($sth->fetchAll() AS $row) {
            $result[] = $row[0];
        }

        return $result;
    }

    /**
     * @inheritdoc
     */
    public function infoDatabase($dbName)
    {
        $sth = $this->conn->query("SHOW TABLE STATUS FROM {$dbName};");

        $result = [];
        foreach ($sth->fetchAll() AS $row) {
            $result[] = [
                'name' => $row['Name'],
                'engine' => $row['Engine'],
                'rows' => $row['Rows'],
                'length' => $row['Avg_row_length'],
                'increment' => $row['Auto_increment'],
                'collation' => $row['Collation']
            ];
        }

        return $result;
    }

    /**
     * @inheritdoc
     */
    public function tableExists($table)
    {
        return in_array($table, $this->listTables(), false);
    }

    /**
     * @inheritdoc
     */
    public function listTables()
    {
        return $this->conn->query('SHOW TABLES;')->fetchAll(\PDO::FETCH_COLUMN, 0);
    }

    /**
     * @inheritdoc
     */
    public function createTable($name, array $elements = [], $params = '')
    {
        return $this->conn->exec(
            sprintf('SELECT TABLE IF NOT EXISTS `%s` (%s) %s;', $name, implode(',', $elements), $params)
        );
    }

    /**
     * @inheritdoc
     */
    public function clearTable($name)
    {
        return $this->conn->exec("TRUNCATE {$name};");
    }

    /**
     * @inheritdoc
     */
    public function removeTable($name)
    {
        return $this->conn->exec("DROP TABLE {$name};");
    }

    /**
     * @inheritdoc
     */
    public function fieldExists($field, $table)
    {
        foreach ($this->listFields($table) AS $tbl) {
            if ($tbl['field'] === $field) {
                return true;
            }
        }

        return false;
    }

    /**
     * @inheritdoc
     */
    public function listFields($table)
    {
        $sth = $this->conn->query("SHOW COLUMNS FROM {$table};");

        $result = [];
        foreach ($sth->fetchAll(\PDO::FETCH_ASSOC) as $row) {
            $result[] = [
                'field' => $row['Field'],
                'type' => $row['Type'],
                'null' => $row['Null'],
                'key' => $row['Key'],
                'default' => $row['Default'],
                'extra' => $row['Extra']
            ];
        }

        return $result;
    }

    /**
     * @inheritdoc
     */
    public function fieldInfo($field, $table)
    {
        return $this->conn->query("SELECT {$field} FROM {$table} LIMIT 1;")->getColumnMeta(0);
    }

    /**
     * @inheritdoc
     */
    public function switchDatabase($dbName)
    {
        if ($this->conn->exec("USE {$dbName};") !== false) {
            return true;
        } else {
            return false;
        }
    }

    /**
     * @inheritdoc
     */
    public function insert($table, array $line = [], $multi = false)
    {
        $fields = '`'.implode('`, `', array_keys($multi ? $line[0] : $line)).'`';
        $values = ':'.implode(', :', array_keys($multi ? $line[0] : $line));

        $id = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
        $dbh = null;
        if ($multi) {
            $this->conn->beginTransaction();
            foreach ($line AS $l) {
                $dbh = $this->conn->prepare("INSERT INTO {$table} ({$fields}) VALUES ({$values});")->execute($l);
            }
            $id = $dbh ? $this->conn->lastInsertId() : false;
            $this->conn->commit();
        } else {
            $dbh = $this->conn->prepare("INSERT INTO {$table} ({$fields}) VALUES ({$values});")->execute($line);
            $id = $dbh ? $this->conn->lastInsertId() : false;
        }

        return $id ?: false;
    }

    /**
     * @inheritdoc
     */
    public function update($table, array $elements = [], $conditions = '')
    {
        $keys = array_keys($elements);
        if (0 === count($keys)) {
            return false;
        }

        $valStr = [];
        foreach ($keys as $key) {
            $valStr[] = '`'.$key.'` = :'.$key;
        }
        $valStr = implode(',', $valStr);

        if ($conditions) {
            $conditions = 'WHERE '.$conditions;
        }

        return $this->conn->prepare("UPDATE {$table} SET {$valStr} {$conditions};")->execute($elements);
    }

    /**
     * @inheritdoc
     */
    public function delete($table, $conditions, array $ph = [])
    {
        return $this->conn->prepare("DELETE FROM {$table} WHERE {$conditions};")->execute($ph);
    }

    /**
     * @inheritdoc
     */
    public function exists($table, array $params = [])
    {
        $keys = [];
        foreach ($params AS $key => $val) {
            $keys[] = '`'.$table.'`.`'.$key.'`="'.$val.'"';
        }

        $sth = $this->conn->prepare('SELECT * FROM `' . $table . '` WHERE ' . implode(' AND ', $keys) . ' LIMIT 1;');
        $sth->execute();

        return (bool)$sth->rowCount();
    }

    /**
     * @inheritdoc
     */
    public function count($subQuery = '', $table = '')
    {
        if ($subQuery) {
            $sth = $this->conn->prepare("SELECT COUNT(*) FROM ({$subQuery}) AS m;");
        } elseif ($table) {
            $sth = $this->conn->prepare("SELECT COUNT(*) FROM {$table} AS m;");
        } else {
            return false;
        }
        if ($sth->execute()) {
            return $sth->fetchColumn();
        }

        return false;
    }
}


1			<?php /** MicroDataBaseConnection */
2
3			namespace Micro\Db;
4
5			use Micro\Base\Exception;
6
7			/**
8			* Connection class file.
9			*
10			* @author Oleg Lunegov <[email protected]>
11			* @link https://github.com/linpax/microphp-framework
12			* @copyright Copyright © 2013 Oleg Lunegov
13			* @license /LICENSE
14			* @package Micro
15			* @subpackage Db
16			* @version 1.0
17			* @since 1.0
18			*/
19			class DbConnection extends Connection
20			{
21			/** @var \PDO\|null $conn Connection to DB */
22			protected $conn;
23
24
25			/**
26			* Construct for this class
27			*
28			* @access public
29			*
30			* @param array $config
31			* @param array $options
32			*
33			* @result void
34			* @throws Exception
35			*/
36			public function __construct(array $config = [], array $options = [])
37			{
38			parent::__construct();
39
40			try {
41			$this->conn = new \PDO($config['connectionString'], $config['username'], $config['password'],
42			$options
43			);
44			} catch (\PDOException $e) {
45			if (!array_key_exists('ignoreFail', $config) \|\| !$config['ignoreFail']) {
46			throw new Exception('Connect to DB failed: '.$e->getMessage());
47			}
48			}
49			}
50
51			/**
52			* Destructor for this class
53			*
54			* @access public
55			* @return void
56			*/
57			public function __destruct()
58			{
59			$this->conn = null;
60			}
61
62			/**
63			* @inheritdoc
64			*/
65			public function rawQuery($query = '', array $params = [], $fetchType = \PDO::FETCH_ASSOC, $fetchClass = 'Model')
66			{
67			$sth = $this->conn->prepare($query);
68
69			if ($fetchType === \PDO::FETCH_CLASS) {
70			/** @noinspection PhpMethodParametersCountMismatchInspection */
71			$sth->setFetchMode($fetchType, ucfirst($fetchClass), ['new' => false]);
72			} else {
73			$sth->setFetchMode($fetchType);
74			}
75
76			foreach ($params AS $name => $value) {
77			$sth->bindValue($name, $value);
78			}
79
80			$sth->execute();
81
82			return $sth->fetchAll();
83			}
84
85			/**
86			* @inheritdoc
87			*/
88			public function listDatabases()
89			{
90			$sth = $this->conn->query('SHOW DATABASES;');
91
92			$result = [];
93			foreach ($sth->fetchAll() AS $row) {
94			$result[] = $row[0];
95			}
96
97			return $result;
98			}
99
100			/**
101			* @inheritdoc
102			*/
103			public function infoDatabase($dbName)
104			{
105			$sth = $this->conn->query("SHOW TABLE STATUS FROM {$dbName};");
106
107			$result = [];
108			foreach ($sth->fetchAll() AS $row) {
109			$result[] = [
110			'name' => $row['Name'],
111			'engine' => $row['Engine'],
112			'rows' => $row['Rows'],
113			'length' => $row['Avg_row_length'],
114			'increment' => $row['Auto_increment'],
115			'collation' => $row['Collation']
116			];
117			}
118
119			return $result;
120			}
121
122			/**
123			* @inheritdoc
124			*/
125			public function tableExists($table)
126			{
127			return in_array($table, $this->listTables(), false);
128			}
129
130			/**
131			* @inheritdoc
132			*/
133			public function listTables()
134			{
135			return $this->conn->query('SHOW TABLES;')->fetchAll(\PDO::FETCH_COLUMN, 0);
136			}
137
138			/**
139			* @inheritdoc
140			*/
141			public function createTable($name, array $elements = [], $params = '')
142			{
143			return $this->conn->exec(
144			sprintf('SELECT TABLE IF NOT EXISTS `%s` (%s) %s;', $name, implode(',', $elements), $params)
145			);
146			}
147
148			/**
149			* @inheritdoc
150			*/
151			public function clearTable($name)
152			{
153			return $this->conn->exec("TRUNCATE {$name};");
154			}
155
156			/**
157			* @inheritdoc
158			*/
159			public function removeTable($name)
160			{
161			return $this->conn->exec("DROP TABLE {$name};");
162			}
163
164			/**
165			* @inheritdoc
166			*/
167			public function fieldExists($field, $table)
168			{
169			foreach ($this->listFields($table) AS $tbl) {
170			if ($tbl['field'] === $field) {
171			return true;
172			}
173			}
174
175			return false;
176			}
177
178			/**
179			* @inheritdoc
180			*/
181			public function listFields($table)
182			{
183			$sth = $this->conn->query("SHOW COLUMNS FROM {$table};");
184
185			$result = [];
186			foreach ($sth->fetchAll(\PDO::FETCH_ASSOC) as $row) {
187			$result[] = [
188			'field' => $row['Field'],
189			'type' => $row['Type'],
190			'null' => $row['Null'],
191			'key' => $row['Key'],
192			'default' => $row['Default'],
193			'extra' => $row['Extra']
194			];
195			}
196
197			return $result;
198			}
199
200			/**
201			* @inheritdoc
202			*/
203			public function fieldInfo($field, $table)
204			{
205			return $this->conn->query("SELECT {$field} FROM {$table} LIMIT 1;")->getColumnMeta(0);
206			}
207
208			/**
209			* @inheritdoc
210			*/
211			public function switchDatabase($dbName)
212			{
213			if ($this->conn->exec("USE {$dbName};") !== false) {
214			return true;
215			} else {
216			return false;
217			}
218			}
219
220			/**
221			* @inheritdoc
222			*/
223			public function insert($table, array $line = [], $multi = false)
224			{
225			$fields = '`'.implode('`, `', array_keys($multi ? $line[0] : $line)).'`';
226			$values = ':'.implode(', :', array_keys($multi ? $line[0] : $line));
227
228			$id = null;
			0 ignored issues – show Unused Code introduced 2016-03-10 20:06 UTC by Report Bug Copy Issue Report `$id` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
229			$dbh = null;
230			if ($multi) {
231			$this->conn->beginTransaction();
232			foreach ($line AS $l) {
233			$dbh = $this->conn->prepare("INSERT INTO {$table} ({$fields}) VALUES ({$values});")->execute($l);
234			}
235			$id = $dbh ? $this->conn->lastInsertId() : false;
236			$this->conn->commit();
237			} else {
238			$dbh = $this->conn->prepare("INSERT INTO {$table} ({$fields}) VALUES ({$values});")->execute($line);
239			$id = $dbh ? $this->conn->lastInsertId() : false;
240			}
241
242			return $id ?: false;
243			}
244
245			/**
246			* @inheritdoc
247			*/
248			public function update($table, array $elements = [], $conditions = '')
249			{
250			$keys = array_keys($elements);
251			if (0 === count($keys)) {
252			return false;
253			}
254
255			$valStr = [];
256			foreach ($keys as $key) {
257			$valStr[] = '`'.$key.'` = :'.$key;
258			}
259			$valStr = implode(',', $valStr);
260
261			if ($conditions) {
262			$conditions = 'WHERE '.$conditions;
263			}
264
265			return $this->conn->prepare("UPDATE {$table} SET {$valStr} {$conditions};")->execute($elements);
266			}
267
268			/**
269			* @inheritdoc
270			*/
271			public function delete($table, $conditions, array $ph = [])
272			{
273			return $this->conn->prepare("DELETE FROM {$table} WHERE {$conditions};")->execute($ph);
274			}
275
276			/**
277			* @inheritdoc
278			*/
279			public function exists($table, array $params = [])
280			{
281			$keys = [];
282			foreach ($params AS $key => $val) {
283			$keys[] = '`'.$table.'`.`'.$key.'`="'.$val.'"';
284			}
285
286			$sth = $this->conn->prepare('SELECT * FROM `' . $table . '` WHERE ' . implode(' AND ', $keys) . ' LIMIT 1;');
287			$sth->execute();
288
289			return (bool)$sth->rowCount();
290			}
291
292			/**
293			* @inheritdoc
294			*/
295			public function count($subQuery = '', $table = '')
296			{
297			if ($subQuery) {
298			$sth = $this->conn->prepare("SELECT COUNT(*) FROM ({$subQuery}) AS m;");
299			} elseif ($table) {
300			$sth = $this->conn->prepare("SELECT COUNT(*) FROM {$table} AS m;");
301			} else {
302			return false;
303			}
304			if ($sth->execute()) {
305			return $sth->fetchColumn();
306			}
307
308			return false;
309			}
310			}
311

linpax / microphp-framework

Push — master ( 9f36d5...158df7 )

DbConnection::insert() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like