Asset::publish() - Code Metrics - Inspection of "small fixes" - linpax/microphp-framework - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 9f0ecb...4a849c )

by Oleg

created 2016-07-25 19:08 UTC

Asset::publish() C

↳ Parent: Asset

Complexity

Conditions	12
Paths	105

Size

Total Lines	38
Code Lines	18

Duplication

Lines	24
Ratio	63.16 %

Importance

Changes	3
Bugs	2	Features	0

Metric	Value
c	3
b	2
f	0
dl	24
loc	38
rs	5.0768
cc	12
eloc	18
nc	105
nop	0

How to fix Complexity

<?php /** MicroAsset */

namespace Micro\Web;

use Micro\Base\Autoload;
use Micro\Base\Exception;
use Micro\Base\Injector;
use Micro\Base\KernelInjector;
use Micro\File\FileHelper;
use Micro\Mvc\Views\IView;

/**
 * Asset class file.
 *
 * @author Oleg Lunegov <[email protected]>
 * @link https://github.com/linpax/microphp-framework
 * @copyright Copyright (c) 2013 Oleg Lunegov
 * @license https://github.com/linpax/microphp-framework/blob/master/LICENSE
 * @package Micro
 * @subpackage Web
 * @version 1.0
 * @since 1.0
 */
class Asset
{
    /** @var string $sourcePath Full-path to source asset dir */
    public $sourcePath;

    /** @var bool $isHead Is a publish into head block */
    public $isHead = true;
    /** @var array $js JavaScript files links */
    public $js = [];
    /** @var array $css CSS files links */
    public $css = [];
    /** @var array $required Required assets */
    public $required = [];
    /** @var array $excludes Excludes extensions */
    public $excludes = [];

    /** @var IView $view View for install current asset */
    protected $view;
    /** @var string $hash Unique directory to publish into assets dir */
    protected $hash;
    /** @var string $publishPath Publish path */
    protected $publishPath;
    /** @var array $published Published required extends */
    private $published = [];


    /**
     * Constructor asset
     *
     * @access public
     *
     * @param IView $view
     *
     * @result void
     * @throws \Micro\Base\Exception
     */
    public function __construct(IView $view)
    {
        $this->view = $view;

        if (!$this->sourcePath) {
            $this->sourcePath = dirname(Autoload::getClassPath(get_class($this)));
        }

        $this->hash = md5($this->sourcePath);

        $this->publishPath = '/'.(($dir = (new Injector)->param('assetsDirName')) ? $dir : 'assets').'/'.$this->hash;

        $web = (new KernelInjector)->build()->getWebDir();

        if (!file_exists($this->sourcePath)) {
            throw new Exception('Asset dir not exists: '.$this->sourcePath);
        }

        if (!is_dir($web.$this->publishPath) && (!mkdir($web.$this->publishPath, 0777) && !is_dir($web.$this->publishPath))) {
            throw new Exception('Could not access to publish dir: '.$this->publishPath);
        }

        FileHelper::recurseCopyIfEdited($this->sourcePath, $web.$this->publishPath, $this->excludes);
    }

    /**
     * Send asset into view
     *
     * @access public
     * @return void
     */
    public function publish()
    {
        foreach ($this->required AS $require) {
            if (!in_array($require, $this->published, true) && class_exists($require)) {
                $this->published[] = $require;

                /** @var Asset $require */
                $require = new $require($this->view);
                $require->publish();
            }
        }

        if ($this->js) {

            if (is_string($this->js)) {
                $this->js = [$this->js];
            }

            if (0 !== count($this->js)) {
                /** @noinspection ForeachSourceInspection */
                foreach ($this->js AS $script) {
                    $this->view->registerScriptFile($this->publishPath . $script, $this->isHead);
                }
            }
        }

        if ($this->css) {

            if (is_string($this->css)) {
                $this->css = [$this->css];
            }

            if (0 !== count($this->css)) {
                /** @noinspection ForeachSourceInspection */
                foreach ($this->css AS $style) {
                    $this->view->registerCssFile($this->publishPath . $style, $this->isHead);
                }
            }
        }
    }
}


1		<?php /** MicroAsset */
2
3		namespace Micro\Web;
4
5		use Micro\Base\Autoload;
6		use Micro\Base\Exception;
7		use Micro\Base\Injector;
8		use Micro\Base\KernelInjector;
9		use Micro\File\FileHelper;
10		use Micro\Mvc\Views\IView;
11
12		/**
13		* Asset class file.
14		*
15		* @author Oleg Lunegov <[email protected]>
16		* @link https://github.com/linpax/microphp-framework
17		* @copyright Copyright (c) 2013 Oleg Lunegov
18		* @license https://github.com/linpax/microphp-framework/blob/master/LICENSE
19		* @package Micro
20		* @subpackage Web
21		* @version 1.0
22		* @since 1.0
23		*/
24		class Asset
25		{
26		/** @var string $sourcePath Full-path to source asset dir */
27		public $sourcePath;
28
29		/** @var bool $isHead Is a publish into head block */
30		public $isHead = true;
31		/** @var array $js JavaScript files links */
32		public $js = [];
33		/** @var array $css CSS files links */
34		public $css = [];
35		/** @var array $required Required assets */
36		public $required = [];
37		/** @var array $excludes Excludes extensions */
38		public $excludes = [];
39
40		/** @var IView $view View for install current asset */
41		protected $view;
42		/** @var string $hash Unique directory to publish into assets dir */
43		protected $hash;
44		/** @var string $publishPath Publish path */
45		protected $publishPath;
46		/** @var array $published Published required extends */
47		private $published = [];
48
49
50		/**
51		* Constructor asset
52		*
53		* @access public
54		*
55		* @param IView $view
56		*
57		* @result void
58		* @throws \Micro\Base\Exception
59		*/
60		public function __construct(IView $view)
61		{
62		$this->view = $view;
63
64		if (!$this->sourcePath) {
65		$this->sourcePath = dirname(Autoload::getClassPath(get_class($this)));
66		}
67
68		$this->hash = md5($this->sourcePath);
69
70		$this->publishPath = '/'.(($dir = (new Injector)->param('assetsDirName')) ? $dir : 'assets').'/'.$this->hash;
71
72		$web = (new KernelInjector)->build()->getWebDir();
73
74		if (!file_exists($this->sourcePath)) {
75		throw new Exception('Asset dir not exists: '.$this->sourcePath);
76		}
77
78		if (!is_dir($web.$this->publishPath) && (!mkdir($web.$this->publishPath, 0777) && !is_dir($web.$this->publishPath))) {
79		throw new Exception('Could not access to publish dir: '.$this->publishPath);
80		}
81
82		FileHelper::recurseCopyIfEdited($this->sourcePath, $web.$this->publishPath, $this->excludes);
83		}
84
85		/**
86		* Send asset into view
87		*
88		* @access public
89		* @return void
90		*/
91		public function publish()
92		{
93		foreach ($this->required AS $require) {
94		if (!in_array($require, $this->published, true) && class_exists($require)) {
95		$this->published[] = $require;
96
97		/** @var Asset $require */
98		$require = new $require($this->view);
99		$require->publish();
100		}
101		}
102
103	View Code Duplication	if ($this->js) {
		0 ignored issues – show Bug Best Practice introduced 2016-03-10 20:06 UTC by Report Bug Copy Issue Report The expression `$this->js` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history... Duplication introduced 2016-03-10 20:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
104		if (is_string($this->js)) {
105		$this->js = [$this->js];
106		}
107
108		if (0 !== count($this->js)) {
109		/** @noinspection ForeachSourceInspection */
110		foreach ($this->js AS $script) {
111		$this->view->registerScriptFile($this->publishPath . $script, $this->isHead);
112		}
113		}
114		}
115
116	View Code Duplication	if ($this->css) {
		0 ignored issues – show Bug Best Practice introduced 2016-03-10 20:06 UTC by Report Bug Copy Issue Report The expression `$this->css` of type `array` is implicitly converted to a boolean; are you sure this is intended? If so, consider using `! empty($expr)` instead to make it clear that you intend to check for an array without elements. This check marks implicit conversions of arrays to boolean values in a comparison. While in PHP an empty array is considered to be equal (but not identical) to false, this is not always apparent. Consider making the comparison explicit by using `empty(..)` or `! empty(...)` instead. Loading history... Duplication introduced 2016-03-10 20:06 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
117		if (is_string($this->css)) {
118		$this->css = [$this->css];
119		}
120
121		if (0 !== count($this->css)) {
122		/** @noinspection ForeachSourceInspection */
123		foreach ($this->css AS $style) {
124		$this->view->registerCssFile($this->publishPath . $style, $this->isHead);
125		}
126		}
127		}
128		}
129		}
130

linpax / microphp-framework

Push — master ( 9f0ecb...4a849c )

Asset::publish() C

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like