Micro\Mvc\Controllers\Controller

Complexity

Total Complexity

20

Size/Duplication

Total Lines	108
Duplicated Lines	0 %

Coupling/Cohesion

Components	0
Dependencies	4

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
B	__construct()	0	15	5
D	applyFilters()	0	34	10
B	getActionClassByName()	0	16	5

<?php /** MicroController */

namespace Micro\Mvc\Controllers;

use Micro\Base\Exception;
use Micro\Mvc\Module;
use Micro\Web\ResponseInjector;
use Psr\Http\Message\ResponseInterface;

/**
 * Class Controller
 *
 * @author Oleg Lunegov <testuser@mail.linpax.org>
 * @link https://github.com/linpax/microphp-framework
 * @copyright Copyright (c) 2013 Oleg Lunegov
 * @license https://github.com/linpax/microphp-framework/blob/master/LICENSE
 * @package Micro
 * @subpackage Mvc\Controllers
 * @version 1.0
 * @since 1.0
 * @abstract
 */
abstract class Controller implements IController
{
    /** @var Module $module */
    public $module;
    /** @var ResponseInterface $response Response HTTP data */
    public $response;


    /**
     * Constructor controller
     *
     * @access public
     *
     * @param string $modules
     *
     * @result void
     * @throws Exception
     */
    public function __construct($modules = '')
    {
        // if module defined
        if ($modules) {
            $className = '\\App'.$modules.'\\'.ucfirst(basename(str_replace('\\', '/', $modules))).'Module';

            if (class_exists($className) && is_subclass_of($className, '\Micro\Mvc\Module')) {
                $this->module = new $className();
            }
        }

        if (!$this->response = (new ResponseInjector)->build()) {
            throw new Exception('Component `response` not configured');
        }
    }

    /**
     * Apply filters
     *
     * @access public
     *
     * @param string $action current action name
     * @param bool $isPre is pre or post
     * @param array $filters defined filters
     * @param string $data data to parse
     *
     * @return null|string
     * @throws Exception|\InvalidArgumentException
     */
    public function applyFilters($action, $isPre = true, array $filters = [], $data = null)
    {
        if (!$filters) {

The expression $filters of type array is implicitly converted to a boolean; are you sure this is intended? If so, consider using empty($expr) instead to make it clear that you intend to check for an array without elements.

            return $data;
        }

        foreach ($filters as $filter) {
            if (empty($filter['class']) || !class_exists($filter['class'])) {
                continue;
            }

            if (empty($filter['actions']) || !in_array($action, $filter['actions'], true)) {
                continue;
            }

            /** @var \Micro\Filter\IFilter $_filter */
            $_filter = new $filter['class']($action);
            /** @var ResponseInterface $response */
            $response = $isPre ? $_filter->pre($filter) : $_filter->post($filter + ['data' => $data]);

The expression $isPre ? $_filter->pre($filter) : $_filter->post($filter + array('data' => $data)); of type mixed adds the type Psr\Http\Message\ResponseInterface to the return on line 102 which is incompatible with the return type declared by the interface Micro\Mvc\Controllers\IController::applyFilters of type null|string.

            if (!$response) {
                if (!empty($_filter->result['redirect'])) {

Accessing result on the interface Micro\Filter\IFilter suggest that you code against a concrete implementation. How about adding an instanceof check?

                    /** @var ResponseInterface $redirect */
                    $redirect = (new ResponseInjector)->build();
                    return $redirect->withHeader('Location', $_filter->result['redirect']);

Accessing result on the interface Micro\Filter\IFilter suggest that you code against a concrete implementation. How about adding an instanceof check?

The return type of return $redirect->withHeader('Location', $_filter->result['redirect']); (Psr\Http\Message\ResponseInterface) is incompatible with the return type declared by the interface Micro\Mvc\Controllers\IController::applyFilters of type null|string.

                }
                throw new Exception($_filter->result['message']);

Accessing result on the interface Micro\Filter\IFilter suggest that you code against a concrete implementation. How about adding an instanceof check?

            }
            /** @noinspection CallableParameterUseCaseInTypeContextInspection */
            $data = $response;
        }

        return $data;
    }

    /**
     * Get action class by name
     *
     * @access public
     *
     * @param string $name action name
     *
     * @return bool
     */
    public function getActionClassByName($name)
    {
        if (method_exists($this, 'actions')) {
            $actions = $this->actions();

The method actions() does not exist on Micro\Mvc\Controllers\Controller. Did you maybe mean action()?

            if (
                !empty($actions[$name]) &&
                class_exists($actions[$name]) &&
                is_subclass_of($actions[$name], '\Micro\Mvc\Action')
            ) {
                return $actions[$name];
            }
        }

        return false;
    }
}