Micro\Auth\Drivers\FileRbac

Complexity

Total Complexity

6

Size/Duplication

Total Lines	57
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	8	2
A	assign()	0	11	3
A	rawRoles()	0	4	1

<?php /** MicroFileRBAC */

namespace Micro\Auth\Drivers;

use Micro\Db\Adapter;

/**
 * File RBAC class file.
 *
 * RBAC security with files.
 *
 * @author Oleg Lunegov <testuser@mail.linpax.org>
 * @link https://github.com/linpax/microphp-framework
 * @copyright Copyright (c) 2013 Oleg Lunegov
 * @license https://github.com/linpax/microphp-framework/blob/master/LICENSE
 * @package Micro
 * @subpackage Auth\Drivers
 * @version 1.0
 * @since 1.0
 */
class FileRbac extends Rbac

There is at least one abstract method in this class. Maybe declare it as abstract, or implement the remaining methods: getDriver, setDriver

{
    /** @var array $roles RBAC role tree */
    private $roles = [];


    /**
     * Redefine constructor for RBAC
     *
     * @access public
     *
     * @param Adapter $connection
     *
     * @result void
     */
    public function __construct(Adapter $connection)
    {
        parent::__construct($connection);

        if (!empty($params['roles'])) {

The variable $params seems to never exist, and therefore empty should always return true. Did you maybe rename this variable?

            $this->roles = $this->tree($params['roles']);
        }
    }

    /**
     * Assign RBAC element into user
     *
     * @access public
     *
     * @param integer $userId user id
     * @param string $name element name
     *
     * @return bool
     */
    public function assign($userId, $name)
    {
        if ($this->searchRoleRecursive($this->roles, $name)) {
            $exists = $this->db->exists('rbac_user', ['user' => $userId, 'role' => $name]);
            if (!$exists) {
                return $this->db->insert('rbac_user', ['role' => $name, 'user' => $userId]);
            }
        }

        return false;
    }

    /**
     * Get raw roles
     *
     * @access public
     * @return mixed
     */
    public function rawRoles()
    {
        return $this->roles;
    }
}