Linna\Filter\Rules\Escape

Complexity

Total Complexity

15

Size/Duplication

Total Lines	78
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
C	htmlEscape()	0	22	9
A	sanitize()	0	3	1
B	ordutf8()	0	30	5

<?php

/**
 * Linna Filter
 *
 * @author Sebastian Rapetti <sebastian.rapetti@alice.it>
 * @copyright (c) 2017, Sebastian Rapetti
 * @license http://opensource.org/licenses/MIT MIT License
 */
declare(strict_types = 1);

namespace Linna\Filter\Rules;

/**
 * Return html entities.
 */
class Escape
{
    /**
     * Sanitize.
     *
     * @param mixed $value
     */
    public function sanitize(&$value)
    {
        $value = $this->htmlEscape($value);
    }
    
    /**
     * Return numerical part of the HTML encoding of the Unicode character.
     *
     * @param string $char
     * @return int
     */
    private function ordutf8(string $char) : int
    {
        $code = ord(substr($char, 0, 1));

It seems like substr($char, 0, 1) can also be of type false; however, parameter $string of ord() does only seem to accept string, maybe add an additional type check?

        if ($code > 127) {

            //110xxxxx
            $bytes = 2;
            $count = 0;

            if ($code > 223) {
                //1110xxxx
                $bytes = 3;
                $count = 32;
            }

            if ($code > 239) {
                //11110xxx
                $bytes = 4;
                $count = 48;
            }

            $temp = $code - 192 - $count;

            for ($i = 1; $i < $bytes; $i++) {
                $code = $temp = $temp * 64 + ord(substr($char, $i, 1)) - 128;
            }
        }

        return $code;
    }

    /**
     * Convert char to html entities.
     *
     * @param string $string
     * @return string
     */
    private function htmlEscape(string $string) : string
    {
        $chars = preg_split('//u', $string, 0, PREG_SPLIT_NO_EMPTY);
        $escaped = '';

        foreach ($chars as $key => $char) {
            $ord = $this->ordutf8($char, $key);

The call to Linna\Filter\Rules\Escape::ordutf8() has too many arguments starting with $key.

            if (
                ($ord > 32 && $ord < 48) ||
                ($ord > 57 && $ord < 65) ||
                ($ord > 90 && $ord < 97) ||
                ($ord > 122)
            ) {
                $escaped .= "&#{$ord};";
                continue;
            }

            $escaped .= $char;
        }

        return $escaped;
    }
}