Linna\Filter\Rules\Date

Complexity

Total Complexity

8

Size/Duplication

Total Lines	88
Duplicated Lines	0 %

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	getDateTimeObject()	0	3	1
B	parseDate()	0	28	4
A	validate()	0	17	3

<?php

/**
 * Linna Filter
 *
 * @author Sebastian Rapetti <sebastian.rapetti@alice.it>
 * @copyright (c) 2018, Sebastian Rapetti
 * @license http://opensource.org/licenses/MIT MIT License
 */
declare(strict_types = 1);

namespace Linna\Filter\Rules;

use Linna\Filter\AbstractDate;
use DateTime;

/**
 * Check if one date is valid.
 */
class Date extends AbstractDate
{
    /**
     * @var array Arguments expected.
     */
    private $arguments = ['string'];

The private property $arguments is not used, and could be removed.

    /**
     * @var string Valid date.
     */
    private $date;

    /**
     *
     * @var DateTime Valid date in DateTime object.
     */
    private $dateTimeObject;

    /**
     * Validate.
     *
     * @return bool
     */
    public function validate($received, string $format): bool
    {
        if ($this->parseDate($received, $format)) {
            return true;
        }
        
        $this->date = $received;
        
        $dateReceived = DateTime::createFromFormat($format, $received);
        
        if ($this->dateHaveNoTime($format)) {
            $dateReceived->setTime(0, 0, 0);
        }
        
        $this->dateTimeObject = $dateReceived;

It seems like $dateReceived can also be of type false. However, the property $dateTimeObject is declared as type DateTime. Maybe add an additional type check?

        
        return false;
    }

    /**
     * Parse date.
     *
     * @param type $received

The type Linna\Filter\Rules\type was not found. Maybe you did not declare it correctly or list all dependencies?

     * @param string $format
     *
     * @return bool
     */
    private function parseDate($received, string $format) : bool
    {
        $date = date_parse_from_format($format, $received);

        //set to zero the date
        $month = $day = null;
        
        //set to zero errors
        $warning_count = $error_count = null;
        
        extract($date, EXTR_IF_EXISTS);
        
        settype($month, 'bool');
        settype($day, 'bool');

        if (!$month) {
            return true;
        }

        if (!$day) {
            return true;
        }

        if ($warning_count + $error_count) {
            return true;
        }
        
        return false;
    }
    
    /**
     * Return DateTime object.
     *
     * @return DateTime
     */
    public function getDateTimeObject(): DateTime
    {
        return $this->dateTimeObject;
    }
}