CatalogService::lists() - Code Metrics - Inspection of "Добавлены новые типы и параметры для списков, а та..." - linkprofit-cpa/amocrm-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#5)

unknown

created 2018-05-14 15:12 UTC

CatalogService::lists() A

↳ Parent: CatalogService

Complexity

Conditions	2
Paths	2

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	6
CRAP Score	2.0625

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
ccs	6
cts	8
cp	0.75
rs	9.4285
cc	2
eloc	7
nc	2
nop	1
crap	2.0625

<?php

namespace linkprofit\AmoCRM\services;

use linkprofit\AmoCRM\entities\Catalog;
use linkprofit\AmoCRM\entities\EntityInterface;

/**
 * Class CatalogService
 *
 * @package linkprofit\AmoCRM\services
 */
class CatalogService extends BaseService
{
    /**
     * @var Catalog[]
     */
    protected $entities = [];

    /**
     * @param Catalog $catalog
     */
    public function add(EntityInterface $catalog)
    {
        if ($catalog instanceof Catalog) {
            $this->entities[] = $catalog;
        }
    }

    /**
     * @param null $id
     *
     * @return array|bool
     */
    public function lists($id = null)
    {
        $link = $this->getLink();

        if ($id !== null) {
            $link .= '?id' . $id;
        }

        $this->request->performRequest($link, [], 'application/json', 'GET');
        $this->response = $this->request->getResponse();

        return $this->parseResponseToEntities();
    }

    /**
     * @param $array
     * 
     * @return Catalog
     */
    public function parseArrayToEntity($array)
    {
        $catalog = new Catalog();
        $catalog->set($array);

        return $catalog;
    }

    /**
     * @return string
     */
    protected function getLink()
    {
        return 'https://' . $this->request->getSubdomain() . '.amocrm.ru/api/v2/catalogs';
    }

}

1		<?php
2
3		namespace linkprofit\AmoCRM\services;
4
5		use linkprofit\AmoCRM\entities\Catalog;
6		use linkprofit\AmoCRM\entities\EntityInterface;
7
8		/**
9		* Class CatalogService
10		*
11		* @package linkprofit\AmoCRM\services
12		*/
13		class CatalogService extends BaseService
14		{
15		/**
16		* @var Catalog[]
17		*/
18		protected $entities = [];
19
20		/**
21		* @param Catalog $catalog
22		*/
23	4	public function add(EntityInterface $catalog)
24		{
25	4	if ($catalog instanceof Catalog) {
26	4	$this->entities[] = $catalog;
27	4	}
28	4	}
29
30		/**
31		* @param null $id
32		*
33		* @return array\|bool
34		*/
35	1	public function lists($id = null)
36		{
37	1	$link = $this->getLink();
38
39	1	if ($id !== null) {
40		$link .= '?id' . $id;
41		}
42
43	1	$this->request->performRequest($link, [], 'application/json', 'GET');
44	1	$this->response = $this->request->getResponse();
45
46	1	return $this->parseResponseToEntities();
47		}
48
49		/**
50		* @param $array
51		*
52		* @return Catalog
53		*/
54	4	public function parseArrayToEntity($array)
55		{
56	4	$catalog = new Catalog();
57	4	$catalog->set($array);
58
59	4	return $catalog;
60		}
61
62		/**
63		* @return string
64		*/
65	4	protected function getLink()
66		{
67	4	return 'https://' . $this->request->getSubdomain() . '.amocrm.ru/api/v2/catalogs';
68		}
69
70		}

linkprofit-cpa / amocrm-api

Pull Request — dev (#5)

CatalogService::lists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like