PipelineService::composeListLink() - Code Metrics - Inspection of "обновил функционал CustomerService" - linkprofit-cpa/amocrm-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — dev ( 4a164e...157791 )

by Konstantin

created 2018-07-18 12:09 UTC

PipelineService::composeListLink() A

↳ Parent: PipelineService

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	8
Ratio	100 %

Code Coverage

Tests	0
CRAP Score	2

Importance

Changes

Metric	Value
dl	8
loc	8
ccs	0
cts	4
cp	0
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	2

<?php

namespace linkprofit\AmoCRM\services;

use linkprofit\AmoCRM\entities\EntityInterface;
use linkprofit\AmoCRM\entities\Pipeline;
use linkprofit\AmoCRM\RequestHandler;
use linkprofit\AmoCRM\traits\IdentifiableList;

/**
 * Class PipelineService
 * @package linkprofit\AmoCRM\services
 */
class PipelineService extends BaseService

{
    use IdentifiableList;

    /**
     * @var Pipeline[]
     */
    protected $entities = [];

    /**
     * @param Pipeline $pipeline
     */
    public function add(EntityInterface $pipeline)
    {
        if ($pipeline instanceof Pipeline) {
            $this->entities[] = $pipeline;
        }
    }

    /**
     * @param $link
     *
     * @return string
     */
    protected function composeListLink($link)
    {
        $query = $this->addIdToQuery();

        $link .= '?' . http_build_query($query);

        return $link;
    }

    /**
     * @param $array
     * @return Pipeline
     */
    public function parseArrayToEntity($array)
    {
        $pipeline = new Pipeline();
        $pipeline->set($array);

        return $pipeline;
    }

    /**
     * @return string
     */
    protected function getLink()
    {
        return 'https://' . $this->request->getSubdomain() . '.amocrm.ru/private/api/v2/json/pipelines/set';
    }
}

1			<?php
2
3			namespace linkprofit\AmoCRM\services;
4
5			use linkprofit\AmoCRM\entities\EntityInterface;
6			use linkprofit\AmoCRM\entities\Pipeline;
7			use linkprofit\AmoCRM\RequestHandler;
8			use linkprofit\AmoCRM\traits\IdentifiableList;
9
10			/**
11			* Class PipelineService
12			* @package linkprofit\AmoCRM\services
13			*/
14		View Code Duplication	class PipelineService extends BaseService
			0 ignored issues – show Duplication introduced 2018-03-23 11:23 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
15			{
16			use IdentifiableList;
17
18			/**
19			* @var Pipeline[]
20			*/
21			protected $entities = [];
22
23			/**
24			* @param Pipeline $pipeline
25			*/
26	4		public function add(EntityInterface $pipeline)
27			{
28	4		if ($pipeline instanceof Pipeline) {
29	4		$this->entities[] = $pipeline;
30			}
31	4		}
32
33			/**
34			* @param $link
35			*
36			* @return string
37			*/
38			protected function composeListLink($link)
39			{
40			$query = $this->addIdToQuery();
41
42			$link .= '?' . http_build_query($query);
43
44			return $link;
45			}
46
47			/**
48			* @param $array
49			* @return Pipeline
50			*/
51	4		public function parseArrayToEntity($array)
52			{
53	4		$pipeline = new Pipeline();
54	4		$pipeline->set($array);
55
56	4		return $pipeline;
57			}
58
59			/**
60			* @return string
61			*/
62	4		protected function getLink()
63			{
64	4		return 'https://' . $this->request->getSubdomain() . '.amocrm.ru/private/api/v2/json/pipelines/set';
65			}
66			}

linkprofit-cpa / amocrm-api

Push — dev ( 4a164e...157791 )

PipelineService::composeListLink() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like