CatalogService::lists() - Code Metrics - Inspection of "Lists refactoring" - linkprofit-cpa/amocrm-api - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — dev (#10)

by Konstantin

created 2018-05-17 16:50 UTC

CatalogService::lists() A

↳ Parent: CatalogService

Complexity

Conditions	2
Paths	2

Size

Total Lines	8
Code Lines	4

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	3
CRAP Score	2.2559

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	8
ccs	3
cts	5
cp	0.6
rs	9.4285
cc	2
eloc	4
nc	2
nop	1
crap	2.2559

<?php

namespace linkprofit\AmoCRM\services;

use linkprofit\AmoCRM\entities\Catalog;
use linkprofit\AmoCRM\entities\EntityInterface;
use linkprofit\AmoCRM\traits\IdentifiableList;
use linkprofit\AmoCRM\traits\PaginableList;

/**
 * Class CatalogService
 *
 * @package linkprofit\AmoCRM\services
 */
class CatalogService extends BaseService implements ListableService
{
    use IdentifiableList, PaginableList;

    /**
     * @var Catalog[]
     */
    protected $entities = [];

    /**
     * @param Catalog $catalog
     */
    public function add(EntityInterface $catalog)
    {
        if ($catalog instanceof Catalog) {
            $this->entities[] = $catalog;
        }
    }

    /**
     * @return array|bool
     */
    public function getList()
    {
        $link = $this->getLink() . '?';

        $link = $this->addIdToLink($link);
        $link = $this->addPaginationToLink($link);

        $this->request->performRequest($link, [], 'application/json', 'GET');
        $this->response = $this->request->getResponse();

        return $this->parseResponseToEntities();
    }

    /**
     * @deprecated
     *
     * @param int|null
     *
     * @return array|bool
     */
    public function lists($id = null)
    {
        if ($id !== null) {
            $this->setId($id);
        }

        return $this->getList();
    }

    /**
     * @param $array
     *
     * @return Catalog
     */
    public function parseArrayToEntity($array)
    {
        $catalog = new Catalog();
        $catalog->set($array);

        return $catalog;
    }

    /**
     * @return string
     */
    protected function getLink()
    {
        return 'https://' . $this->request->getSubdomain() . '.amocrm.ru/api/v2/catalogs';
    }

}

1		<?php
2
3		namespace linkprofit\AmoCRM\services;
4
5		use linkprofit\AmoCRM\entities\Catalog;
6		use linkprofit\AmoCRM\entities\EntityInterface;
7		use linkprofit\AmoCRM\traits\IdentifiableList;
8		use linkprofit\AmoCRM\traits\PaginableList;
9
10		/**
11		* Class CatalogService
12		*
13		* @package linkprofit\AmoCRM\services
14		*/
15		class CatalogService extends BaseService implements ListableService
16		{
17		use IdentifiableList, PaginableList;
18
19		/**
20		* @var Catalog[]
21		*/
22		protected $entities = [];
23
24		/**
25		* @param Catalog $catalog
26		*/
27	5	public function add(EntityInterface $catalog)
28		{
29	5	if ($catalog instanceof Catalog) {
30	5	$this->entities[] = $catalog;
31	5	}
32	5	}
33
34		/**
35		* @return array\|bool
36		*/
37	2	public function getList()
38		{
39	2	$link = $this->getLink() . '?';
40
41	2	$link = $this->addIdToLink($link);
42	2	$link = $this->addPaginationToLink($link);
43
44	2	$this->request->performRequest($link, [], 'application/json', 'GET');
45	2	$this->response = $this->request->getResponse();
46
47	2	return $this->parseResponseToEntities();
48		}
49
50		/**
51		* @deprecated
52		*
53		* @param int\|null
54		*
55		* @return array\|bool
56		*/
57	1	public function lists($id = null)
58		{
59	1	if ($id !== null) {
60		$this->setId($id);
61		}
62
63	1	return $this->getList();
64		}
65
66		/**
67		* @param $array
68		*
69		* @return Catalog
70		*/
71	5	public function parseArrayToEntity($array)
72		{
73	5	$catalog = new Catalog();
74	5	$catalog->set($array);
75
76	5	return $catalog;
77		}
78
79		/**
80		* @return string
81		*/
82	5	protected function getLink()
83		{
84	5	return 'https://' . $this->request->getSubdomain() . '.amocrm.ru/api/v2/catalogs';
85		}
86
87		}

linkprofit-cpa / amocrm-api

Pull Request — dev (#10)

CatalogService::lists() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like