linkeys-app / signed-url

src/Middleware/CheckLinkValid.php

<?php

namespace Linkeys\UrlSigner\Middleware;

use Closure;
use Illuminate\Database\Eloquent\ModelNotFoundException;
use Illuminate\Support\Facades\Event;
use Linkeys\UrlSigner\Contracts\Models\Link;
use Linkeys\UrlSigner\Events\LinkClicked;
use Linkeys\UrlSigner\Exceptions\ClickLimit\LinkClickLimitReachedException;
use Linkeys\UrlSigner\Exceptions\ClickLimit\LinkGroupClickLimitReachedException;
use Linkeys\UrlSigner\Exceptions\Expiry\LinkExpiredException;
use Linkeys\UrlSigner\Exceptions\Expiry\LinkGroupExpiredException;
use Linkeys\UrlSigner\Exceptions\LinkNotFoundException;
use Linkeys\UrlSigner\Support\LinkRepository\LinkRepository;
use Symfony\Component\HttpFoundation\Request;

class CheckLinkValid
{

        public function handle(Request $request, Closure $next)
    {

        $link = $request->get(\Linkeys\UrlSigner\Models\Link::class);

        if($link->clickLimitReached()) {
            throw new LinkClickLimitReachedException;
        }
        if($link->group && $link->group->clickLimitReached()) {
            throw new LinkGroupClickLimitReachedException;
        }
        if($link->expired()) {
            throw new LinkExpiredException;
        }

        if($link->group && $link->group->expired() && $link->expiry === null) {
            throw new LinkGroupExpiredException;
        }

        Event::dispatch(new LinkClicked($link));

It seems like $link can also be of type null; however, parameter $link of Linkeys\UrlSigner\Events\LinkClicked::__construct() does only seem to accept Linkeys\UrlSigner\Contracts\Models\Link, maybe add an additional type check?

        return $next($request);
    }

}