Group::serializeDate() - Code Metrics - Inspection of "Fix date serialisation" - linkeys-app/signed-url - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( 036d62...640fb3 )

by Toby

created 2020-05-02 09:15 UTC

Group::serializeDate() A

↳ Parent: Group

Complexity

Conditions	1
Paths	1

Size

Total Lines	3
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes

Metric	Value
eloc	1
c	0
b	0
f	0
dl	0
loc	3
ccs	2
cts	2
cp	1
rs	10
cc	1
nc	1
nop	1
crap	1

<?php

namespace Linkeys\UrlSigner\Models;

use Carbon\Carbon;
use Illuminate\Database\Eloquent\Model;
use Linkeys\UrlSigner\Contracts\Models\Group as GroupModelContract;
use Linkeys\UrlSigner\Support\ExpiryNormaliser\NormaliserManagerContract;

class Group extends Model implements GroupModelContract
{

    public $fillable = [
        'expiry',
        'click_limit'
    ];

    protected $dates = [
        'expiry'
    ];

    public function __construct(array $attributes = [])
    {
        parent::__construct($attributes);
        $this->table = config('links.tables.groups');
    }

    /**
     * Prepare a date for array / JSON serialization.
     *
     * @param  \DateTimeInterface  $date
     * @return string
     */
    protected function serializeDate(\DateTimeInterface $date)
    {
        return $date->format('Y-m-d H:i:s');
    }

    public function links()
    {
        return $this->hasMany(Link::class);
    }


    public function setExpiryAttribute($expiry)
    {
        $normaliser = resolve(NormaliserManagerContract::class);
        $normalisedExpiry = $normaliser->normalise($expiry);
        $this->attributes['expiry'] = $normalisedExpiry;
    }

    public function clickLimitReached()
    {
        if($this->click_limit === null) {

            return false;
        }
        return $this->click_limit <= $this->links->sum('clicks');
    }

    public function expired()
    {
        if($this->expiry === null) {

            return false;
        }
        return !(new Carbon($this->expiry))->isFuture();
    }

}

1		<?php
2
3		namespace Linkeys\UrlSigner\Models;
4
5		use Carbon\Carbon;
6		use Illuminate\Database\Eloquent\Model;
7		use Linkeys\UrlSigner\Contracts\Models\Group as GroupModelContract;
8		use Linkeys\UrlSigner\Support\ExpiryNormaliser\NormaliserManagerContract;
9
10		class Group extends Model implements GroupModelContract
11		{
12
13		public $fillable = [
14		'expiry',
15		'click_limit'
16		];
17
18		protected $dates = [
19		'expiry'
20		];
21
22	33	public function __construct(array $attributes = [])
23		{
24	33	parent::__construct($attributes);
25	33	$this->table = config('links.tables.groups');
26	33	}
27
28		/**
29		* Prepare a date for array / JSON serialization.
30		*
31		* @param \DateTimeInterface $date
32		* @return string
33		*/
34	3	protected function serializeDate(\DateTimeInterface $date)
35		{
36	3	return $date->format('Y-m-d H:i:s');
37		}
38
39	7	public function links()
40		{
41	7	return $this->hasMany(Link::class);
42		}
43
44
45	24	public function setExpiryAttribute($expiry)
46		{
47	24	$normaliser = resolve(NormaliserManagerContract::class);
48	24	$normalisedExpiry = $normaliser->normalise($expiry);
49	24	$this->attributes['expiry'] = $normalisedExpiry;
50	24	}
51
52	10	public function clickLimitReached()
53		{
54	10	if($this->click_limit === null) {
		0 ignored issues – show Bug introduced 2019-06-30 12:12 UTC by Report Bug Copy Issue Report The property `click_limit` does not seem to exist on `Linkeys\UrlSigner\Models\Group`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
55	6	return false;
56		}
57	4	return $this->click_limit <= $this->links->sum('clicks');
58		}
59
60	6	public function expired()
61		{
62	6	if($this->expiry === null) {
		0 ignored issues – show Bug introduced 2019-06-30 12:12 UTC by Report Bug Copy Issue Report The property `expiry` does not seem to exist on `Linkeys\UrlSigner\Models\Group`. Are you sure there is no database migration missing? Checks if undeclared accessed properties appear in database migrations and if the creating migration is correct. Loading history...
63	1	return false;
64		}
65	5	return !(new Carbon($this->expiry))->isFuture();
66		}
67
68		}

linkeys-app / signed-url

GitHub Access Token became invalid

Push — master ( 036d62...640fb3 )

Group::serializeDate() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like