BusinessContact::asTurtleFragment() - Code Metrics - Inspection of "ready for 7.1.0" - linkeddatacenter/BOTK-core - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 2f2064...ba7592 )

by Enrico

created 2017-08-13 21:16 UTC

BusinessContact::asTurtleFragment() C

↳ Parent: BusinessContact

Complexity

Conditions	13
Paths	37

Size

Total Lines	60
Code Lines	39

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	23
CRAP Score	13.2597

Importance

Changes

Metric	Value
dl	0
loc	60
ccs	23
cts	26
cp	0.8846
rs	6.3453
c	0
b	0
f	0
cc	13
eloc	39
nc	37
nop	0
crap	13.2597

How to fix Long Method Complexity

<?php
namespace BOTK\Model;


/**
 * An ibrid class that merge the semantic of schema:organization, schema:place and schema:geo, 
 * it is similar to schema:LocalBusiness.
 * Allows the bulk setup of properties
 */
class BusinessContact extends Thing 
{

	protected static $DEFAULT_OPTIONS = array (
		'taxID'				=> array(	
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_TOKEN',
			'flags'  	=> FILTER_REQUIRE_SCALAR,
			),
		'alternateName'		=> array(
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_PERSON_NAME',
			'flags'  	=> FILTER_FORCE_ARRAY,
			),
		'givenName'				=> array(
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_PERSON_NAME',
			'flags'  	=> FILTER_REQUIRE_SCALAR,
			),
		'familyName'				=> array(
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_PERSON_NAME',
			'flags'  	=> FILTER_REQUIRE_SCALAR,
			),
		'additionalName'			=> array(
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_PERSON_NAME',
			'flags'  	=> FILTER_REQUIRE_SCALAR,
			),
		'jobTitle'	=> array(
			'filter'    => FILTER_DEFAULT,
			'flags'  	=> FILTER_FORCE_ARRAY,
			),
		'honorificPrefix'	=> array(
			'filter'    => FILTER_DEFAULT,
			'flags'  	=> FILTER_FORCE_ARRAY,
			),
		'honorificSuffix'	=> array(
			'filter'    => FILTER_DEFAULT,
			'flags'  	=> FILTER_FORCE_ARRAY,
			),
		'gender'	=> array(	
			'filter'    => FILTER_CALLBACK,
			'options'    => '\BOTK\Filters::FILTER_SANITIZE_GENDER',
			'flags'  	=> FILTER_REQUIRE_SCALAR,
			),
		'worksFor'	=> array(		
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_VALIDATE_URI',
			'flags'  	=> FILTER_REQUIRE_SCALAR,
			),
		'telephone'			=> array(	
			'filter'    => FILTER_CALLBACK,	
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_TELEPHONE',
			'flags'  	=> FILTER_FORCE_ARRAY,
			),
		'email'				=> array(	
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_EMAIL',
			'flags'  	=> FILTER_FORCE_ARRAY,
			),
		'spokenLanguage'			=> array(	
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_LANGUAGE',
			'flags'  	=> FILTER_FORCE_ARRAY,
			),
		'hasOptInOptOutDate'				=> array(	
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_DATETIME',
			'flags'  	=> FILTER_REQUIRE_SCALAR,
			),
		'privacyFlag'		=> array(	
			'filter'    => FILTER_CALLBACK,
			'options' 	=> '\BOTK\Filters::FILTER_SANITIZE_BOOLEAN',
			'flags'  	=> FILTER_REQUIRE_SCALAR,
			),
		);

	
	public function asTurtleFragment()
	{
		static $uriVars = array(
			'gender' => 'schema:gender',
			'worksFor' => 'schema:worksFor',
		);
		static $stringVars = array(
			'taxID' => 'schema:taxID',
			'givenName' => 'schema:givenName',
			'familyName' => 'schema:familyName',
			'additionalName' => 'schema:additionalName',
			'telephone' => 'schema:telephone',
			'faxNumber' => 'schema:faxNumber',
			'jobTitle' => 'schema:jobTitle',
			'honorificPrefix' => 'schema:honorificPrefix',
			'honorificSuffix' => 'schema:honorificSuffix',
			'email' => 'schema:email',
			'spokenLanguage' => 'schema:spokenLanguage',
		);
		
		
		if(is_null($this->rdf)) {
			
			// make a default for altenatename (can be empty) before calling parent::asTurtleFragment
			if(empty($this->data['alternateName'])){
				$this->data['alternateName'] ='';
				if(!empty($this->data['givenName'])) { $this->data['alternateName'].= $this->data['givenName'].' ';}						
				if(!empty($this->data['additionalName'])) { $this->data['alternateName'].= $this->data['additionalName'].' ';}		
				if(!empty($this->data['familyName'])) { $this->data['alternateName'].= $this->data['familyName'].' ';}
			}			
			$this->rdf = parent::asTurtleFragment();
		
			$personUri = $this->getUri();
			
	 		// serialize schema:LocalBusiness	
			$this->rdf .= "<$personUri> ";	
			foreach ( $uriVars as $uriVar => $property) {
				if(!empty($this->data[$uriVar])){
					$this->addFragment("$property <%s>;", $this->data[$uriVar],false);	
				}
			}
			foreach ($stringVars as $stringVar => $property) {
				if(!empty($this->data[$stringVar])){
					$this->addFragment("$property \"%s\";", $this->data[$stringVar]);	
				}
			}
			!empty($this->data['hasOptInOptOutDate'])&& $this->addFragment('botk:hasOptInOptOutDate "%s"^^xsd:dateTime;', $this->data['hasOptInOptOutDate']);
			!empty($this->data['privacyFlag'])	&& $this->addFragment('botk:privacyFlag %s ;', $this->data['privacyFlag']);			
			$this->addFragment('a schema:Person.', $personUri);
					
			if(!empty($this->data['aggregateRatingValue'])){
				$ratingUri=$this->data['base'].'rating_'.$this->data['aggregateRatingValue'].
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
				$this->rdf .= "<$personUri> schema:aggregateRating <$ratingUri>.<$ratingUri> schema:ratingValue \"{$this->data['aggregateRatingValue']}\"^^xsd:float.";
function someFunction() {
    $x = 5;
    echo $x;
}
				$this->tripleCount +=2;
			}

		}

		return $this->rdf;
	}

}

1		<?php
2		namespace BOTK\Model;
3
4
5		/**
6		* An ibrid class that merge the semantic of schema:organization, schema:place and schema:geo,
7		* it is similar to schema:LocalBusiness.
8		* Allows the bulk setup of properties
9		*/
10		class BusinessContact extends Thing
11		{
12
13		protected static $DEFAULT_OPTIONS = array (
14		'taxID' => array(
15		'filter' => FILTER_CALLBACK,
16		'options' => '\BOTK\Filters::FILTER_SANITIZE_TOKEN',
17		'flags' => FILTER_REQUIRE_SCALAR,
18		),
19		'alternateName' => array(
20		'filter' => FILTER_CALLBACK,
21		'options' => '\BOTK\Filters::FILTER_SANITIZE_PERSON_NAME',
22		'flags' => FILTER_FORCE_ARRAY,
23		),
24		'givenName' => array(
25		'filter' => FILTER_CALLBACK,
26		'options' => '\BOTK\Filters::FILTER_SANITIZE_PERSON_NAME',
27		'flags' => FILTER_REQUIRE_SCALAR,
28		),
29		'familyName' => array(
30		'filter' => FILTER_CALLBACK,
31		'options' => '\BOTK\Filters::FILTER_SANITIZE_PERSON_NAME',
32		'flags' => FILTER_REQUIRE_SCALAR,
33		),
34		'additionalName' => array(
35		'filter' => FILTER_CALLBACK,
36		'options' => '\BOTK\Filters::FILTER_SANITIZE_PERSON_NAME',
37		'flags' => FILTER_REQUIRE_SCALAR,
38		),
39		'jobTitle' => array(
40		'filter' => FILTER_DEFAULT,
41		'flags' => FILTER_FORCE_ARRAY,
42		),
43		'honorificPrefix' => array(
44		'filter' => FILTER_DEFAULT,
45		'flags' => FILTER_FORCE_ARRAY,
46		),
47		'honorificSuffix' => array(
48		'filter' => FILTER_DEFAULT,
49		'flags' => FILTER_FORCE_ARRAY,
50		),
51		'gender' => array(
52		'filter' => FILTER_CALLBACK,
53		'options' => '\BOTK\Filters::FILTER_SANITIZE_GENDER',
54		'flags' => FILTER_REQUIRE_SCALAR,
55		),
56		'worksFor' => array(
57		'filter' => FILTER_CALLBACK,
58		'options' => '\BOTK\Filters::FILTER_VALIDATE_URI',
59		'flags' => FILTER_REQUIRE_SCALAR,
60		),
61		'telephone' => array(
62		'filter' => FILTER_CALLBACK,
63		'options' => '\BOTK\Filters::FILTER_SANITIZE_TELEPHONE',
64		'flags' => FILTER_FORCE_ARRAY,
65		),
66		'email' => array(
67		'filter' => FILTER_CALLBACK,
68		'options' => '\BOTK\Filters::FILTER_SANITIZE_EMAIL',
69		'flags' => FILTER_FORCE_ARRAY,
70		),
71		'spokenLanguage' => array(
72		'filter' => FILTER_CALLBACK,
73		'options' => '\BOTK\Filters::FILTER_SANITIZE_LANGUAGE',
74		'flags' => FILTER_FORCE_ARRAY,
75		),
76		'hasOptInOptOutDate' => array(
77		'filter' => FILTER_CALLBACK,
78		'options' => '\BOTK\Filters::FILTER_SANITIZE_DATETIME',
79		'flags' => FILTER_REQUIRE_SCALAR,
80		),
81		'privacyFlag' => array(
82		'filter' => FILTER_CALLBACK,
83		'options' => '\BOTK\Filters::FILTER_SANITIZE_BOOLEAN',
84		'flags' => FILTER_REQUIRE_SCALAR,
85		),
86		);
87
88
89	4	public function asTurtleFragment()
90		{
91	4	static $uriVars = array(
92		'gender' => 'schema:gender',
93		'worksFor' => 'schema:worksFor',
94		);
95	4	static $stringVars = array(
96		'taxID' => 'schema:taxID',
97		'givenName' => 'schema:givenName',
98		'familyName' => 'schema:familyName',
99		'additionalName' => 'schema:additionalName',
100		'telephone' => 'schema:telephone',
101		'faxNumber' => 'schema:faxNumber',
102		'jobTitle' => 'schema:jobTitle',
103		'honorificPrefix' => 'schema:honorificPrefix',
104		'honorificSuffix' => 'schema:honorificSuffix',
105		'email' => 'schema:email',
106		'spokenLanguage' => 'schema:spokenLanguage',
107		);
108
109
110	4	if(is_null($this->rdf)) {
111
112		// make a default for altenatename (can be empty) before calling parent::asTurtleFragment
113	4	if(empty($this->data['alternateName'])){
114	3	$this->data['alternateName'] ='';
115	3	if(!empty($this->data['givenName'])) { $this->data['alternateName'].= $this->data['givenName'].' ';}
116	3	if(!empty($this->data['additionalName'])) { $this->data['alternateName'].= $this->data['additionalName'].' ';}
117	3	if(!empty($this->data['familyName'])) { $this->data['alternateName'].= $this->data['familyName'].' ';}
118		}
119	4	$this->rdf = parent::asTurtleFragment();
120
121	4	$personUri = $this->getUri();
122
123		// serialize schema:LocalBusiness
124	4	$this->rdf .= "<$personUri> ";
125	4	foreach ( $uriVars as $uriVar => $property) {
126	4	if(!empty($this->data[$uriVar])){
127	4	$this->addFragment("$property <%s>;", $this->data[$uriVar],false);
128		}
129		}
130	4	foreach ($stringVars as $stringVar => $property) {
131	4	if(!empty($this->data[$stringVar])){
132	4	$this->addFragment("$property \"%s\";", $this->data[$stringVar]);
133		}
134		}
135	4	!empty($this->data['hasOptInOptOutDate'])&& $this->addFragment('botk:hasOptInOptOutDate "%s"^^xsd:dateTime;', $this->data['hasOptInOptOutDate']);
136	4	!empty($this->data['privacyFlag']) && $this->addFragment('botk:privacyFlag %s ;', $this->data['privacyFlag']);
137	4	$this->addFragment('a schema:Person.', $personUri);
138
139	4	if(!empty($this->data['aggregateRatingValue'])){
140		$ratingUri=$this->data['base'].'rating_'.$this->data['aggregateRatingValue'].
		1 ignored issue – show Unused Code introduced 2017-08-13 21:17 UTC by Report Bug Copy Issue Report `$ratingUri` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
141		$this->rdf .= "<$personUri> schema:aggregateRating <$ratingUri>.<$ratingUri> schema:ratingValue \"{$this->data['aggregateRatingValue']}\"^^xsd:float.";
		1 ignored issue – show Bug introduced 2017-08-13 21:17 UTC by Report Bug Copy Issue Report The variable `$ratingUri` seems only to be defined at a later point. Did you maybe move this code here without moving the variable definition? This error can happen if you refactor code and forget to move the variable initialization. Let’s take a look at a simple example: function someFunction() { $x = 5; echo $x; } The above code is perfectly fine. Now imagine that we re-order the statements: function someFunction() { echo $x; $x = 5; } In that case, `$x` would be read before it is initialized. This was a very basic example, however the principle is the same for the found issue. Loading history...
142		$this->tripleCount +=2;
143		}
144
145		}
146
147	4	return $this->rdf;
148		}
149
150		}

linkeddatacenter / BOTK-core

Push — master ( 2f2064...ba7592 )

BusinessContact::asTurtleFragment() C

Complexity

Size

Duplication

Code Coverage

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like