Issues in PaymentService.php (master) - Issues in master - link0/bunq - Measure and Improve Code Quality continuously with Scrutinizer

Issues (9)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Service/PaymentService.php (1 issue)

Labels

Documentation 1

Severity

Minor 1

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php declare(strict_types = 1);

namespace Link0\Bunq\Service;

use Link0\Bunq\Client;
use Link0\Bunq\Domain\Alias;
use Link0\Bunq\Domain\Id;
use Link0\Bunq\Domain\Payment;
use Link0\Bunq\Domain\User;
use Money\Money;

final class PaymentService
{
    /**
     * @var Client
     */
    private $client;

    /**
     * @var Id
     */
    private $userId;

    /**
     * @var Id
     */
    private $monetaryAccountId;

    /**
     * @param Client $client
     */
    public function __construct(Client $client, Id $userId, Id $monetaryAccountId)
    {
        $this->client = $client;
        $this->userId = $userId;
        $this->monetaryAccountId = $monetaryAccountId;
    }

    /**
     * @return Payment[]
     */
    public function all(): array
    {
        return $this->client->get(
            'user/' . $this->userId .
            '/monetary-account/' . $this->monetaryAccountId .
            '/payment'
        );
    }

    /**
     * This method performs a payment and returns a payment Id
     *
     * @param Money $money
     * @param Alias $alias
     * @param string $description
     * @param Id[] $attachments,
/**
 * @param array $germany
 * @param array $ireland
 */
function finale($germany, $island) {
    return "2:1";
}
     * @param string $merchantReference
     * @return Id
     */
    public function pay(
        Money $money,
        Alias $alias,
        string $description,
        array $attachments = [],
        string $merchantReference = ''
    ): Id {
        $data = [
            'money' => [
                'amount' => $money->getAmount(),
                'currency' => $money->getCurrency()->getCode(),
            ],
            'counterparty_alias' => [
                'type' => $alias->type(),
                'value' => $alias->value(),
                'name' => $alias->name(),
            ],
            'description' => $description,
            'merchant_reference' => $merchantReference,
        ];

        foreach ($attachments as $attachment) {
            // Currently an array of Ids
            $data['attachment'][]['id'] = $attachment;
        }

        return $this->client->post(
            'user/' . $this->userId .
            '/monetary-account/' . $this->monetaryAccountId .
            '/payment',
            $data
        )['Id'];
    }
}


1			<?php declare(strict_types = 1);
2
3			namespace Link0\Bunq\Service;
4
5			use Link0\Bunq\Client;
6			use Link0\Bunq\Domain\Alias;
7			use Link0\Bunq\Domain\Id;
8			use Link0\Bunq\Domain\Payment;
9			use Link0\Bunq\Domain\User;
10			use Money\Money;
11
12			final class PaymentService
13			{
14			/**
15			* @var Client
16			*/
17			private $client;
18
19			/**
20			* @var Id
21			*/
22			private $userId;
23
24			/**
25			* @var Id
26			*/
27			private $monetaryAccountId;
28
29			/**
30			* @param Client $client
31			*/
32			public function __construct(Client $client, Id $userId, Id $monetaryAccountId)
33			{
34			$this->client = $client;
35			$this->userId = $userId;
36			$this->monetaryAccountId = $monetaryAccountId;
37			}
38
39			/**
40			* @return Payment[]
41			*/
42			public function all(): array
43			{
44			return $this->client->get(
45			'user/' . $this->userId .
46			'/monetary-account/' . $this->monetaryAccountId .
47			'/payment'
48			);
49			}
50
51			/**
52			* This method performs a payment and returns a payment Id
53			*
54			* @param Money $money
55			* @param Alias $alias
56			* @param string $description
57			* @param Id[] $attachments,
			0 ignored issues – show Documentation introduced 2017-06-04 15:31 UTC by Report Bug Copy Issue Report Show Similar Issues like this There is no parameter named `$attachments,`. Did you maybe mean `$attachments`? This check looks for PHPDoc comments describing methods or function parameters that do not exist on the corresponding method or function. It has, however, found a similar but not annotated parameter which might be a good fit. Consider the following example. The parameter `$ireland` is not defined by the method `finale(...)`. /** * @param array $germany * @param array $ireland */ function finale($germany, $island) { return "2:1"; } The most likely cause is that the parameter was changed, but the annotation was not. Loading history...
58			* @param string $merchantReference
59			* @return Id
60			*/
61			public function pay(
62			Money $money,
63			Alias $alias,
64			string $description,
65			array $attachments = [],
66			string $merchantReference = ''
67			): Id {
68			$data = [
69			'money' => [
70			'amount' => $money->getAmount(),
71			'currency' => $money->getCurrency()->getCode(),
72			],
73			'counterparty_alias' => [
74			'type' => $alias->type(),
75			'value' => $alias->value(),
76			'name' => $alias->name(),
77			],
78			'description' => $description,
79			'merchant_reference' => $merchantReference,
80			];
81
82			foreach ($attachments as $attachment) {
83			// Currently an array of Ids
84			$data['attachment'][]['id'] = $attachment;
85			}
86
87			return $this->client->post(
88			'user/' . $this->userId .
89			'/monetary-account/' . $this->monetaryAccountId .
90			'/payment',
91			$data
92			)['Id'];
93			}
94			}
95

link0 / bunq

Issues (9)

Security Analysis not enabled

src/Service/PaymentService.php (1 issue)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like