MockySender - Code Metrics - Inspection of "add sender interface to testability." - linemob/core - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( df4cce...a240aa )

by ツ

created 2017-08-30 13:11 UTC

MockySender A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	85
Duplicated Lines	0 %

Importance

Changes

Metric	Value
wmc	8
dl	0
loc	85
rs	10
c	0
b	0
f	0

8 Methods

Rating	Name	Size	Complexity
A	leaveGroup()	4	1
A	pushMessage()	5	1
A	replyMessage()	5	1
A	replyText()	6	1
A	leaveRoom()	4	1
A	multicast()	5	1
A	getProfile()	4	1
A	validateSignature()	5	1

<?php

/*
 * This file is part of the LineMob package.
 *
 * (c) Ishmael Doss <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

namespace LineMob\Core\Sender;

use LINE\LINEBot\MessageBuilder;
use LINE\LINEBot\Response;

/**
 * @author Ishmael Doss <[email protected]>
 */
class MockySender implements SenderInterface
{
    /**
     * {@inheritdoc}
     */
    public function getProfile($userId)
    {
        return new Response(200, json_encode([
            '$userId' => $userId,
        ]));
    }

    /**
     * {@inheritdoc}
     */
    public function replyMessage($replyToken, MessageBuilder $messageBuilder)
    {
        return new Response(200, json_encode([
            '$replyToken' => $replyToken,
            '$messageBuilder' => $messageBuilder->buildMessage(),
        ]));
    }

    /**
     * {@inheritdoc}
     */
    public function replyText($replyToken, $text, $extraTexts = null)
    {
        return new Response(200, json_encode([
            '$replyToken' => $replyToken,
            '$text' => $text,
            '$extraTexts' => $extraTexts,
        ]));
    }

    /**
     * {@inheritdoc}
     */
    public function pushMessage($to, MessageBuilder $messageBuilder)
    {
        return new Response(200, json_encode([
            '$to' => $to,
            '$messageBuilder' => $messageBuilder->buildMessage(),
        ]));
    }

    /**
     * {@inheritdoc}
     */
    public function multicast(array $tos, MessageBuilder $messageBuilder)
    {
        return new Response(200, json_encode([
            '$tos' => $tos,
            '$messageBuilder' => $messageBuilder->buildMessage(),
        ]));
    }

    /**
     * {@inheritdoc}
     */
    public function leaveGroup($groupId)
    {
        return new Response(200, json_encode([
            '$groupId' => $groupId,
        ]));
    }

    /**
     * {@inheritdoc}
     */
    public function leaveRoom($roomId)
    {
        return new Response(200, json_encode([
            '$roomId' => $roomId,
        ]));
    }

    /**
     * {@inheritdoc}
     */
    public function validateSignature($body, $signature)
    {
        return new Response(200, json_encode([
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
            '$body' => $body,
            '$signature' => $signature,
        ]));
    }
}


1			<?php
2
3			/*
4			* This file is part of the LineMob package.
5			*
6			* (c) Ishmael Doss <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			namespace LineMob\Core\Sender;
13
14			use LINE\LINEBot\MessageBuilder;
15			use LINE\LINEBot\Response;
16
17			/**
18			* @author Ishmael Doss <[email protected]>
19			*/
20			class MockySender implements SenderInterface
21			{
22			/**
23			* {@inheritdoc}
24			*/
25			public function getProfile($userId)
26			{
27			return new Response(200, json_encode([
28			'$userId' => $userId,
29			]));
30			}
31
32			/**
33			* {@inheritdoc}
34			*/
35			public function replyMessage($replyToken, MessageBuilder $messageBuilder)
36			{
37			return new Response(200, json_encode([
38			'$replyToken' => $replyToken,
39			'$messageBuilder' => $messageBuilder->buildMessage(),
40			]));
41			}
42
43			/**
44			* {@inheritdoc}
45			*/
46			public function replyText($replyToken, $text, $extraTexts = null)
47			{
48			return new Response(200, json_encode([
49			'$replyToken' => $replyToken,
50			'$text' => $text,
51			'$extraTexts' => $extraTexts,
52			]));
53			}
54
55			/**
56			* {@inheritdoc}
57			*/
58			public function pushMessage($to, MessageBuilder $messageBuilder)
59			{
60			return new Response(200, json_encode([
61			'$to' => $to,
62			'$messageBuilder' => $messageBuilder->buildMessage(),
63			]));
64			}
65
66			/**
67			* {@inheritdoc}
68			*/
69			public function multicast(array $tos, MessageBuilder $messageBuilder)
70			{
71			return new Response(200, json_encode([
72			'$tos' => $tos,
73			'$messageBuilder' => $messageBuilder->buildMessage(),
74			]));
75			}
76
77			/**
78			* {@inheritdoc}
79			*/
80			public function leaveGroup($groupId)
81			{
82			return new Response(200, json_encode([
83			'$groupId' => $groupId,
84			]));
85			}
86
87			/**
88			* {@inheritdoc}
89			*/
90			public function leaveRoom($roomId)
91			{
92			return new Response(200, json_encode([
93			'$roomId' => $roomId,
94			]));
95			}
96
97			/**
98			* {@inheritdoc}
99			*/
100			public function validateSignature($body, $signature)
101			{
102			return new Response(200, json_encode([
			0 ignored issues – show Bug Best Practice introduced 2017-08-30 13:13 UTC by Report Bug Copy Issue Report The expression `return new LINE\LINEBot\...ature' => $signature)))` returns the type `LINE\LINEBot\Response` which is incompatible with the return type mandated by `LineMob\Core\Sender\Send...ce::validateSignature()` of `boolean`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
103			'$body' => $body,
104			'$signature' => $signature,
105			]));
106			}
107			}
108

linemob / core

Push — master ( df4cce...a240aa )

MockySender A

Complexity

Size/Duplication

Importance

8 Methods

Duplication Side-by-Side

Filter issues like