Issues in BlockInterpreter.php (master) - Issues in master - limoncello-php-dist/validation - Measure and Improve Code Quality continuously with Scrutinizer

Issues (135)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Execution/BlockInterpreter.php (49 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php declare(strict_types=1);

namespace Limoncello\Validation\Execution;

/**
 * Copyright 2015-2020 [email protected]
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

use Limoncello\Validation\Contracts\Captures\CaptureAggregatorInterface;
use Limoncello\Validation\Contracts\Errors\ErrorAggregatorInterface;
use Limoncello\Validation\Contracts\Execution\ContextInterface;
use Limoncello\Validation\Contracts\Execution\ContextStorageInterface;
use Limoncello\Validation\Errors\Error;
use Limoncello\Validation\Rules\BaseRule;
use function array_key_exists;
use function assert;
use function call_user_func;
use function is_array;
use function is_bool;
use function is_callable;
use function is_int;
use function is_iterable;

/**
 * @package Limoncello\Validation
 *
 * @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
 */
final class BlockInterpreter
{
    /**
     * @param mixed                      $input
     * @param array                      $serializedBlocks
     * @param ContextStorageInterface    $context
     * @param CaptureAggregatorInterface $captures
     * @param ErrorAggregatorInterface   $errors
     *
     * @return bool
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    public static function execute(
        $input,
        array $serializedBlocks,
        ContextStorageInterface $context,
        CaptureAggregatorInterface $captures,
        ErrorAggregatorInterface $errors
    ): bool {
        $blockIndex = BlockSerializer::FIRST_BLOCK_INDEX;

        $blocks   = static::getBlocks($serializedBlocks);

        $startsOk = static::executeStarts(static::getBlocksWithStart($serializedBlocks), $blocks, $context, $errors);

        $blockOk  = static::executeBlock($input, $blockIndex, $blocks, $context, $captures, $errors);
        $endsOk   = static::executeEnds(static::getBlocksWithEnd($serializedBlocks), $blocks, $context, $errors);


        return $startsOk && $blockOk && $endsOk;
    }

    /**
     * @param iterable|int[]           $indexes
     * @param array                    $blocks
     * @param ContextStorageInterface  $context
     * @param ErrorAggregatorInterface $errors
     *
     * @return bool
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    public static function executeStarts(

        iterable $indexes,
        array $blocks,
        ContextStorageInterface $context,
        ErrorAggregatorInterface $errors
    ): bool {
        $allOk = true;

        foreach ($indexes as $index) {
            $context->setCurrentBlockId($index);
            $block      = $blocks[$index];
            $errorsInfo = static::executeProcedureStart($block, $context);

            if (empty($errorsInfo) === false) {
                static::addBlockErrors($errorsInfo, $context, $errors);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $allOk = false;
            }
        }

        return $allOk;
    }

    /**
     * @param iterable|int[]           $indexes
     * @param array                    $blocks
     * @param ContextStorageInterface  $context
     * @param ErrorAggregatorInterface $errors
     *
     * @return bool
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    public static function executeEnds(

        iterable $indexes,
        array $blocks,
        ContextStorageInterface $context,
        ErrorAggregatorInterface $errors
    ): bool {
        $allOk = true;

        foreach ($indexes as $index) {
            $context->setCurrentBlockId($index);
            $block      = $blocks[$index];
            $errorsInfo = static::executeProcedureEnd($block, $context);

            if (empty($errorsInfo) === false) {
                static::addBlockErrors($errorsInfo, $context, $errors);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
                $allOk = false;
            }
        }

        return $allOk;
    }

    /**
     * @param mixed                      $input
     * @param int                        $blockIndex
     * @param array                      $blocks
     * @param ContextStorageInterface    $context
     * @param CaptureAggregatorInterface $captures
     * @param ErrorAggregatorInterface   $errors
     *
     * @return bool
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    public static function executeBlock(
        $input,
        int $blockIndex,
        array $blocks,
        ContextStorageInterface $context,
        CaptureAggregatorInterface $captures,
        ErrorAggregatorInterface $errors
    ): bool {
        $result = static::executeBlockImpl(

            $input,
            $blockIndex,
            $blocks,
            $context,
            $captures
        );
        if (BlockReplies::isResultSuccessful($result) === false) {
            $errorsInfo = BlockReplies::extractResultErrorsInfo($result);
            static::addBlockErrors($errorsInfo, $context, $errors);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            return false;
        }

        return true;
    }

    /**
     * @param mixed                      $input
     * @param int                        $blockIndex
     * @param array                      $blocks
     * @param ContextStorageInterface    $context
     * @param CaptureAggregatorInterface $captures
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function executeBlockImpl(
        $input,
        int $blockIndex,
        array $blocks,
        ContextStorageInterface $context,
        CaptureAggregatorInterface $captures
    ): array {
        assert(array_key_exists($blockIndex, $blocks));

        $blockType = static::getBlockType($blocks[$blockIndex]);

        $context->setCurrentBlockId($blockIndex);
        switch ($blockType) {
            case BlockSerializer::TYPE__PROCEDURE:
                $result = static::executeProcedureBlock($input, $blockIndex, $blocks, $context, $captures);

                break;
            case BlockSerializer::TYPE__IF_EXPRESSION:
                $result = static::executeIfBlock($input, $blockIndex, $blocks, $context, $captures);

                break;
            case BlockSerializer::TYPE__AND_EXPRESSION:
                $result = static::executeAndBlock($input, $blockIndex, $blocks, $context, $captures);

                break;
            case BlockSerializer::TYPE__OR_EXPRESSION:
            default:
                assert($blockType === BlockSerializer::TYPE__OR_EXPRESSION);
                $result = static::executeOrBlock($input, $blockIndex, $blocks, $context, $captures);

                break;
        }

        return $result;
    }

    /**
     * @param mixed                      $input
     * @param int                        $blockIndex
     * @param array                      $blocks
     * @param ContextStorageInterface    $context
     * @param CaptureAggregatorInterface $captures
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function executeProcedureBlock(
        $input,
        int $blockIndex,
        array $blocks,
        ContextStorageInterface $context,
        CaptureAggregatorInterface $captures
    ): array {
        $block = $blocks[$blockIndex];
        assert(static::getBlockType($block) === BlockSerializer::TYPE__PROCEDURE);


        $procedure = $block[BlockSerializer::PROCEDURE_EXECUTE_CALLABLE];
        assert(is_callable($procedure));
        $result = call_user_func($procedure, $input, $context);

        static::captureSuccessfulBlockResultIfEnabled($result, $block, $captures);


        return $result;
    }

    /**
     * @param mixed                      $input
     * @param int                        $blockIndex
     * @param array                      $blocks
     * @param ContextStorageInterface    $context
     * @param CaptureAggregatorInterface $captures
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function executeIfBlock(
        $input,
        int $blockIndex,
        array $blocks,
        ContextStorageInterface $context,
        CaptureAggregatorInterface $captures
    ): array {
        $block = $blocks[$blockIndex];
        assert(static::getBlockType($block) === BlockSerializer::TYPE__IF_EXPRESSION);


        $conditionCallable = $block[BlockSerializer::IF_EXPRESSION_CONDITION_CALLABLE];
        assert(is_callable($conditionCallable));
        $conditionResult = call_user_func($conditionCallable, $input, $context);
        assert(is_bool($conditionResult));

        $index = $block[$conditionResult === true ?
            BlockSerializer::IF_EXPRESSION_ON_TRUE_BLOCK : BlockSerializer::IF_EXPRESSION_ON_FALSE_BLOCK];

        $result = static::executeBlockImpl($input, $index, $blocks, $context, $captures);


        static::captureSuccessfulBlockResultIfEnabled($result, $block, $captures);


        return $result;
    }

    /**
     * @param mixed                      $input
     * @param int                        $blockIndex
     * @param array                      $blocks
     * @param ContextStorageInterface    $context
     * @param CaptureAggregatorInterface $captures
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function executeAndBlock(

        $input,
        int $blockIndex,
        array $blocks,
        ContextStorageInterface $context,
        CaptureAggregatorInterface $captures
    ): array {
        $block = $blocks[$blockIndex];
        assert(static::getBlockType($block) === BlockSerializer::TYPE__AND_EXPRESSION);


        $primaryIndex = $block[BlockSerializer::AND_EXPRESSION_PRIMARY];
        $result       = static::executeBlockImpl($input, $primaryIndex, $blocks, $context, $captures);

        if (BlockReplies::isResultSuccessful($result) === true) {
            $nextInput      = BlockReplies::extractResultOutput($result);
            $secondaryIndex = $block[BlockSerializer::AND_EXPRESSION_SECONDARY];
            $result         = static::executeBlockImpl($nextInput, $secondaryIndex, $blocks, $context, $captures);

        }

        static::captureSuccessfulBlockResultIfEnabled($result, $block, $captures);


        return $result;
    }

    /**
     * @param mixed                      $input
     * @param int                        $blockIndex
     * @param array                      $blocks
     * @param ContextStorageInterface    $context
     * @param CaptureAggregatorInterface $captures
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     * @SuppressWarnings(PHPMD.ElseExpression)
     */
    private static function executeOrBlock(

        $input,
        int $blockIndex,
        array $blocks,
        ContextStorageInterface $context,
        CaptureAggregatorInterface $captures
    ): array {
        $block = $blocks[$blockIndex];
        assert(static::getBlockType($block) === BlockSerializer::TYPE__OR_EXPRESSION);


        $primaryIndex      = $block[BlockSerializer::OR_EXPRESSION_PRIMARY];
        $resultFromPrimary = static::executeBlockImpl($input, $primaryIndex, $blocks, $context, $captures);

        if (BlockReplies::isResultSuccessful($resultFromPrimary) === true) {
            $result = $resultFromPrimary;
        } else {
            $secondaryIndex = $block[BlockSerializer::OR_EXPRESSION_SECONDARY];
            $result         = static::executeBlockImpl($input, $secondaryIndex, $blocks, $context, $captures);

        }

        static::captureSuccessfulBlockResultIfEnabled($result, $block, $captures);


        return $result;
    }

    /**
     * @param array $serializedBlocks
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function getBlocks(array $serializedBlocks): array
    {
        $blocks = BlockSerializer::unserializeBlocks($serializedBlocks);
        assert(static::debugCheckLooksLikeBlocksArray($blocks));
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $blocks;
    }

    /**
     * @param array $serializedBlocks
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function getBlocksWithStart(array $serializedBlocks): array

    {
        $blocksWithStart = BlockSerializer::unserializeBlocksWithStart($serializedBlocks);

        // check result contain only block indexes and the blocks are procedures
        assert(
            is_array($blocks = static::getBlocks($serializedBlocks)) &&

            static::debugCheckBlocksExist($blocksWithStart, $blocks, BlockSerializer::TYPE__PROCEDURE)

        );

        return $blocksWithStart;
    }

    /**
     * @param array $serializedBlocks
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function getBlocksWithEnd(array $serializedBlocks): array

    {
        $blocksWithEnd = BlockSerializer::unserializeBlocksWithEnd($serializedBlocks);

        // check result contain only block indexes and the blocks are procedures
        assert(
            is_array($blocks = static::getBlocks($serializedBlocks)) &&

            static::debugCheckBlocksExist($blocksWithEnd, $blocks, BlockSerializer::TYPE__PROCEDURE)

        );

        return $blocksWithEnd;
    }

    /**
     * @param array $block
     *
     * @return int
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function getBlockType(array $block): int
    {
        assert(static::debugHasKnownBlockType($block));


        $type = $block[BlockSerializer::TYPE];

        return $type;
    }

    /**
     * @param array                      $result
     * @param array                      $block
     * @param CaptureAggregatorInterface $captures
     *
     * @return void
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function captureSuccessfulBlockResultIfEnabled(
        array $result,
        array $block,
        CaptureAggregatorInterface $captures
    ): void {
        if (BlockReplies::isResultSuccessful($result) === true) {
            $isCaptureEnabled = $block[BlockSerializer::PROPERTIES][BaseRule::PROPERTY_IS_CAPTURE_ENABLED] ?? false;
            if ($isCaptureEnabled === true) {
                $name  = $block[BlockSerializer::PROPERTIES][BaseRule::PROPERTY_NAME];
                $value = BlockReplies::extractResultOutput($result);
                $captures->remember($name, $value);
            }
        }
    }

    /**
     * @param array            $procedureBlock
     * @param ContextInterface $context
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function executeProcedureStart(array $procedureBlock, ContextInterface $context): array

    {
        assert(static::getBlockType($procedureBlock) === BlockSerializer::TYPE__PROCEDURE);

        $callable = $procedureBlock[BlockSerializer::PROCEDURE_START_CALLABLE];
        assert(is_callable($callable) === true);
        $errors = call_user_func($callable, $context);
        assert(is_array($errors));

        return $errors;
    }

    /**
     * @param array            $procedureBlock
     * @param ContextInterface $context
     *
     * @return array
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function executeProcedureEnd(array $procedureBlock, ContextInterface $context): iterable

    {
        assert(static::getBlockType($procedureBlock) === BlockSerializer::TYPE__PROCEDURE);

        $callable = $procedureBlock[BlockSerializer::PROCEDURE_END_CALLABLE];
        assert(is_callable($callable) === true);
        $errors = call_user_func($callable, $context);
        assert(is_iterable($errors));

        return $errors;
    }

    /**
     * @param iterable                 $errorsInfo
     * @param ContextStorageInterface  $context
     * @param ErrorAggregatorInterface $errors
     *
     * @return void
     */
    private static function addBlockErrors(
        iterable $errorsInfo,
        ContextStorageInterface $context,
        ErrorAggregatorInterface $errors
    ): void {
        foreach ($errorsInfo as $errorInfo) {
            $index           = $errorInfo[BlockReplies::ERROR_INFO_BLOCK_INDEX];
            $value           = $errorInfo[BlockReplies::ERROR_INFO_VALUE];
            $errorCode       = $errorInfo[BlockReplies::ERROR_INFO_CODE];
            $messageTemplate = $errorInfo[BlockReplies::ERROR_INFO_MESSAGE_TEMPLATE];
            $messageParams   = $errorInfo[BlockReplies::ERROR_INFO_MESSAGE_PARAMETERS];

            $name = $context->setCurrentBlockId($index)->getProperties()->getProperty(BaseRule::PROPERTY_NAME);

            $errors->add(new Error($name, $value, $errorCode, $messageTemplate, $messageParams));
        }
    }

    /**
     * @param iterable $blocks
     *
     * @return bool
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function debugCheckLooksLikeBlocksArray(iterable $blocks): bool
    {
        $result = true;

        foreach ($blocks as $index => $block) {
            $result = $result &&
                is_int($index) === true &&
                is_array($block) === true &&
                static::debugHasKnownBlockType($block) === true;

        }

        return $result;
    }

    /**
     * @param iterable|int[] $blockIndexes
     * @param array          $blockList
     * @param int            $blockType
     *
     * @return bool
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    private static function debugCheckBlocksExist(iterable $blockIndexes, array $blockList, int $blockType): bool
    {
        $result = true;

        foreach ($blockIndexes as $index) {
            $result = $result &&
                array_key_exists($index, $blockList) === true &&
                static::getBlockType($blockList[$index]) === $blockType;

        }

        return $result;
    }

    /**
     * @param array $block
     *
     * @return bool
     */
    private static function debugHasKnownBlockType(array $block): bool
    {
        $result = false;

        if (array_key_exists(BlockSerializer::TYPE, $block) === true) {
            $type = $block[BlockSerializer::TYPE];

            $result =
                $type === BlockSerializer::TYPE__PROCEDURE ||
                $type === BlockSerializer::TYPE__AND_EXPRESSION ||
                $type === BlockSerializer::TYPE__OR_EXPRESSION ||
                $type === BlockSerializer::TYPE__IF_EXPRESSION;
        }

        return $result;
    }
}


1			<?php declare(strict_types=1);
2
3			namespace Limoncello\Validation\Execution;
4
5			/**
6			* Copyright 2015-2020 [email protected]
7			*
8			* Licensed under the Apache License, Version 2.0 (the "License");
9			* you may not use this file except in compliance with the License.
10			* You may obtain a copy of the License at
11			*
12			* http://www.apache.org/licenses/LICENSE-2.0
13			*
14			* Unless required by applicable law or agreed to in writing, software
15			* distributed under the License is distributed on an "AS IS" BASIS,
16			* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
17			* See the License for the specific language governing permissions and
18			* limitations under the License.
19			*/
20
21			use Limoncello\Validation\Contracts\Captures\CaptureAggregatorInterface;
22			use Limoncello\Validation\Contracts\Errors\ErrorAggregatorInterface;
23			use Limoncello\Validation\Contracts\Execution\ContextInterface;
24			use Limoncello\Validation\Contracts\Execution\ContextStorageInterface;
25			use Limoncello\Validation\Errors\Error;
26			use Limoncello\Validation\Rules\BaseRule;
27			use function array_key_exists;
28			use function assert;
29			use function call_user_func;
30			use function is_array;
31			use function is_bool;
32			use function is_callable;
33			use function is_int;
34			use function is_iterable;
35
36			/**
37			* @package Limoncello\Validation
38			*
39			* @SuppressWarnings(PHPMD.ExcessiveClassComplexity)
40			*/

limoncello-php-dist / validation

Issues (135)

Security Analysis no request data

src/Execution/BlockInterpreter.php (49 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like