Limoncello\Validation\Rules\Comparisons\ScalarInValues

Complexity

Total Complexity

6

Size/Duplication

Total Lines	44
Duplicated Lines	15.91 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	17	2
A	compare()	7	7	2
A	isValidType()	0	4	2

<?php declare(strict_types=1);

namespace Limoncello\Validation\Rules\Comparisons;

/**
 * Copyright 2015-2020 info@neomerx.com
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

use Limoncello\Validation\Contracts\Errors\ErrorCodes;
use Limoncello\Validation\Contracts\Execution\ContextInterface;
use Limoncello\Validation\I18n\Messages;
use function assert;
use function call_user_func;
use function in_array;
use function is_scalar;

/**
 * @package Limoncello\Validation
 */
final class ScalarInValues extends BaseOneValueComparision
{
    /**
     * @param mixed $scalars
     */
    public function __construct(array $scalars)
    {
        assert(call_user_func(function () use ($scalars) {
            foreach ($scalars as $scalar) {
                assert(static::isValidType($scalar) === true);

Since Limoncello\Validation\Rules\Comparisons\ScalarInValues is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

            }

            return true;
        }));

        parent::__construct(
            $scalars,
            ErrorCodes::SCALAR_IN_VALUES,
            Messages::SCALAR_IN_VALUES,
            $scalars
        );
    }

    /**
     * @inheritdoc
     */
    public static function compare($value, ContextInterface $context): bool

This method seems to be duplicated in your project.

    {
        assert(static::isValidType($value) === true);

Since Limoncello\Validation\Rules\Comparisons\ScalarInValues is declared final, using late-static binding will have no effect. You might want to replace static with self instead.

        $result = is_scalar($value) === true && in_array($value, static::readValue($context));

        return $result;
    }

    /**
     * @param mixed $value
     *
     * @return bool
     */
    private static function isValidType($value): bool
    {
        return is_scalar($value) === true || $value === null;
    }
}