MySqlPassportContainerConfigurator.php$0 ➔ verifyAllowedUserScope() - Code Metrics - Inspection of "Add user scope validation before issuing a token." - limoncello-php-dist/passport - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 0e7cb7...85d6ec )

by Neomerx

created 2017-06-09 22:56 UTC

pe() A

↳ Parent: anonymous//src/Package/MySqlPassportContainerConfigurator.php$0

Complexity

Conditions

Size

Total Lines

Duplication

Lines	7
Ratio	100 %

Importance

Changes

Metric	Value
dl	7
loc	7
rs	9.4285
c	0
b	0
f	0
cc	1

<?php namespace Limoncello\Passport\Package;

/**
 * Copyright 2015-2017 [email protected]
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

use Doctrine\DBAL\Connection;
use Limoncello\Contracts\Application\ContainerConfiguratorInterface as CCI;
use Limoncello\Contracts\Container\ContainerInterface as LimoncelloContainerInterface;
use Limoncello\Contracts\Settings\SettingsProviderInterface;
use Limoncello\Passport\Adaptors\MySql\MySqlPassportServerIntegration;
use Limoncello\Passport\Adaptors\MySql\TokenRepository;
use Limoncello\Passport\Contracts\Entities\DatabaseSchemeInterface;
use Limoncello\Passport\Contracts\PassportServerIntegrationInterface;
use Limoncello\Passport\Contracts\Repositories\TokenRepositoryInterface;
use Limoncello\Passport\Package\PassportSettings as C;
use Psr\Container\ContainerInterface as PsrContainerInterface;

/**
 * @package Limoncello\Passport
 */
class MySqlPassportContainerConfigurator extends BasePassportContainerConfigurator implements CCI

{
    /**
     * @inheritdoc
     *
     * @SuppressWarnings(PHPMD.UnusedLocalVariable)
     */
    public static function configureContainer(LimoncelloContainerInterface $container)
    {
        static::baseConfigureContainer($container);
class User
{
    private $email;

    public function getEmail()
    {
        return $this->email;
    }

    public function setEmail($email)
    {
        $this->email = $email;
    }
}

        $container[PassportServerIntegrationInterface::class] = function (PsrContainerInterface $container) {
            assert($container !== null);

            return new class ($container) extends MySqlPassportServerIntegration
            {
                /**
                 * @var PsrContainerInterface
                 */
                private $container;

                /**
                 * @var array
                 */
                private $settings;

                /**
                 * @param PsrContainerInterface $container
                 */
                public function __construct(PsrContainerInterface $container)
                {
                    $this->container = $container;
                    $this->settings  = $container->get(SettingsProviderInterface::class)->get(C::class);

                    /** @var Connection $connection */
                    $connection = $container->get(Connection::class);

                    parent::__construct(
                        $connection,
                        $this->settings[C::KEY_DEFAULT_CLIENT_ID],
                        $this->settings[C::KEY_APPROVAL_URI_STRING],
                        $this->settings[C::KEY_ERROR_URI_STRING],
                        $this->settings[C::KEY_CODE_EXPIRATION_TIME_IN_SECONDS],
                        $this->settings[C::KEY_TOKEN_EXPIRATION_TIME_IN_SECONDS],
                        $this->settings[C::KEY_RENEW_REFRESH_VALUE_ON_TOKEN_REFRESH]
                    );
                }

                /**
                 * @inheritdoc
                 */
                public function validateUserId(string $userName, string $password)
                {
                    $validator    = $this->settings[C::KEY_USER_CREDENTIALS_VALIDATOR];
                    $nullOrUserId = call_user_func($validator, $this->container, $userName, $password);

                    return $nullOrUserId;
                }

                /**
                 * @inheritdoc
                 */
                public function verifyAllowedUserScope(int $userIdentity, array $scope = null)
                {
                    $validator   = $this->settings[C::KEY_USER_SCOPE_VALIDATOR];
                    $nullOrScope = call_user_func($validator, $this->container, $userIdentity, $scope);

                    return $nullOrScope;
                }
            };
        };

        $container[TokenRepositoryInterface::class] = function (PsrContainerInterface $container) {
            $connection = $container->get(Connection::class);
            $scheme     = $container->get(DatabaseSchemeInterface::class);

            return new TokenRepository($connection, $scheme);
        };
    }
}


1		<?php namespace Limoncello\Passport\Package;
2
3		/**
4		* Copyright 2015-2017 [email protected]
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License");
7		* you may not use this file except in compliance with the License.
8		* You may obtain a copy of the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS,
14		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15		* See the License for the specific language governing permissions and
16		* limitations under the License.
17		*/
18
19		use Doctrine\DBAL\Connection;
20		use Limoncello\Contracts\Application\ContainerConfiguratorInterface as CCI;
21		use Limoncello\Contracts\Container\ContainerInterface as LimoncelloContainerInterface;
22		use Limoncello\Contracts\Settings\SettingsProviderInterface;
23		use Limoncello\Passport\Adaptors\MySql\MySqlPassportServerIntegration;
24		use Limoncello\Passport\Adaptors\MySql\TokenRepository;
25		use Limoncello\Passport\Contracts\Entities\DatabaseSchemeInterface;
26		use Limoncello\Passport\Contracts\PassportServerIntegrationInterface;
27		use Limoncello\Passport\Contracts\Repositories\TokenRepositoryInterface;
28		use Limoncello\Passport\Package\PassportSettings as C;
29		use Psr\Container\ContainerInterface as PsrContainerInterface;
30
31		/**
32		* @package Limoncello\Passport
33		*/
34	View Code Duplication	class MySqlPassportContainerConfigurator extends BasePassportContainerConfigurator implements CCI
		0 ignored issues – show Duplication introduced 2017-05-30 15:53 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
35		{
36		/**
37		* @inheritdoc
38		*
39		* @SuppressWarnings(PHPMD.UnusedLocalVariable)
40		*/
41		public static function configureContainer(LimoncelloContainerInterface $container)
42		{
43		static::baseConfigureContainer($container);
		0 ignored issues – show Unused Code introduced 2017-05-30 15:53 UTC by Report Bug Copy Issue Report The call to the method `Limoncello\Passport\Pack...aseConfigureContainer()` seems un-needed as the method has no side-effects. PHP Analyzer performs a side-effects analysis of your code. A side-effect is basically anything that might be visible after the scope of the method is left. Let’s take a look at an example: class User { private $email; public function getEmail() { return $this->email; } public function setEmail($email) { $this->email = $email; } } If we look at the `getEmail()` method, we can see that it has no side-effect. Whether you call this method or not, no future calls to other methods are affected by this. As such code as the following is useless: $user = new User(); $user->getEmail(); // This line could safely be removed as it has no effect. On the hand, if we look at the `setEmail()`, this method _has_ side-effects. In the following case, we could not remove the method call: $user = new User(); $user->setEmail('email@domain'); // This line has a side-effect (it changes an // instance variable). Loading history...
44
45		$container[PassportServerIntegrationInterface::class] = function (PsrContainerInterface $container) {
46		assert($container !== null);
47
48		return new class ($container) extends MySqlPassportServerIntegration
49		{
50		/**
51		* @var PsrContainerInterface
52		*/
53		private $container;
54
55		/**
56		* @var array
57		*/
58		private $settings;
59
60		/**
61		* @param PsrContainerInterface $container
62		*/
63		public function __construct(PsrContainerInterface $container)
64		{
65		$this->container = $container;
66		$this->settings = $container->get(SettingsProviderInterface::class)->get(C::class);
67
68		/** @var Connection $connection */
69		$connection = $container->get(Connection::class);
70
71		parent::__construct(
72		$connection,
73		$this->settings[C::KEY_DEFAULT_CLIENT_ID],
74		$this->settings[C::KEY_APPROVAL_URI_STRING],
75		$this->settings[C::KEY_ERROR_URI_STRING],
76		$this->settings[C::KEY_CODE_EXPIRATION_TIME_IN_SECONDS],
77		$this->settings[C::KEY_TOKEN_EXPIRATION_TIME_IN_SECONDS],
78		$this->settings[C::KEY_RENEW_REFRESH_VALUE_ON_TOKEN_REFRESH]
79		);
80		}
81
82		/**
83		* @inheritdoc
84		*/
85		public function validateUserId(string $userName, string $password)
86		{
87		$validator = $this->settings[C::KEY_USER_CREDENTIALS_VALIDATOR];
88		$nullOrUserId = call_user_func($validator, $this->container, $userName, $password);
89
90		return $nullOrUserId;
91		}
92
93		/**
94		* @inheritdoc
95		*/
96		public function verifyAllowedUserScope(int $userIdentity, array $scope = null)
97		{
98		$validator = $this->settings[C::KEY_USER_SCOPE_VALIDATOR];
99		$nullOrScope = call_user_func($validator, $this->container, $userIdentity, $scope);
100
101		return $nullOrScope;
102		}
103		};
104		};
105
106		$container[TokenRepositoryInterface::class] = function (PsrContainerInterface $container) {
107		$connection = $container->get(Connection::class);
108		$scheme = $container->get(DatabaseSchemeInterface::class);
109
110		return new TokenRepository($connection, $scheme);
111		};
112		}
113		}
114

limoncello-php-dist / passport

Push — master ( 0e7cb7...85d6ec )

pe() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like