JsonApiDataRulesSerializer - Code Metrics - Inspection of "Add resource ID param to validate relationship met..." - limoncello-php-dist/flute - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 6173d9...210649 )

by Neomerx

created 2018-07-26 14:09 UTC

JsonApiDataRulesSerializer A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	264
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	4

Test Coverage

Coverage

100%

Importance

Changes

Metric	Value
wmc	22
lcom	1
cbo	4
dl	0
loc	264
ccs	81
cts	81
cp	1
rs	10
c	0
b	0
f	0

20 Methods

Rating	Name	Size	Complexity
A	addRulesFromClass()	17	1
A	addDataRules()	25	1
A	getData()	7	1
A	readRules()	8	1
A	hasRules()	7	2
A	readBlocks()	8	1
A	readIdRuleIndexes()	8	1
A	readTypeRuleIndexes()	8	1
A	readAttributeRulesIndexes()	8	1
A	readToOneRulesIndexes()	8	1
A	readToManyRulesIndexes()	8	1
A	readRuleIndex()	4	1
A	readRuleStartIndexes()	4	1
A	readRuleEndIndexes()	4	1
A	readRulesIndexes()	4	1
A	readRulesStartIndexes()	4	1
A	readRulesEndIndexes()	4	1
A	readSingleRuleIndexes()	4	1
A	hasRule()	6	1
A	isRulesClass()	6	2

<?php namespace Limoncello\Flute\Validation\JsonApi\Execution;

/**
 * Copyright 2015-2018 [email protected]
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

use Limoncello\Flute\Contracts\Validation\JsonApiDataRulesInterface;
use Limoncello\Flute\Contracts\Validation\JsonApiDataRulesSerializerInterface;
use Limoncello\Flute\Validation\Serialize\RulesSerializer;
use Limoncello\Validation\Contracts\Rules\RuleInterface;
use Neomerx\JsonApi\Contracts\Document\DocumentInterface;

/**
 * @package Limoncello\Flute
 *
 * @SuppressWarnings(PHPMD.TooManyPublicMethods)
 */
class JsonApiDataRulesSerializer extends RulesSerializer implements JsonApiDataRulesSerializerInterface
{
    /** Serialized indexes key */
    protected const SERIALIZED_RULES = 0;

    /** Serialized rules key */
    protected const SERIALIZED_BLOCKS = self::SERIALIZED_RULES + 1;

    /** Index key */
    protected const ID_SERIALIZED = 0;

    /** Index key */
    protected const TYPE_SERIALIZED = self::ID_SERIALIZED + 1;

    /** Index key */
    protected const ATTRIBUTES_SERIALIZED = self::TYPE_SERIALIZED + 1;

    /** Index key */
    protected const TO_ONE_SERIALIZED = self::ATTRIBUTES_SERIALIZED + 1;

    /** Index key */
    protected const TO_MANY_SERIALIZED = self::TO_ONE_SERIALIZED + 1;

    /**
     * @var array
     */
    private $serializedRules = [];

    /**
     * @inheritdoc
     */
    public function addRulesFromClass(string $rulesClass): JsonApiDataRulesSerializerInterface
    {
        assert(static::isRulesClass($rulesClass));
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

        $name = $rulesClass;

        /** @var JsonApiDataRulesInterface $rulesClass */

        return $this->addDataRules(
            $name,
            $rulesClass::getIdRule(),
            $rulesClass::getTypeRule(),
            $rulesClass::getAttributeRules(),
            $rulesClass::getToOneRelationshipRules(),
            $rulesClass::getToManyRelationshipRules()
        );
    }

    /**
     * @inheritdoc
     */
    public function addDataRules(
        string $name,
        RuleInterface $idRule,
        RuleInterface $typeRule,
        array $attributeRules,
        array $toOneRules,
        array $toManyRules
    ): JsonApiDataRulesSerializerInterface {
        $idRule->setName(DocumentInterface::KEYWORD_ID)->enableCapture();
        $typeRule->setName(DocumentInterface::KEYWORD_TYPE)->enableCapture();

        $ruleSet = [
            static::ID_SERIALIZED         => $this->addRule($idRule),
            static::TYPE_SERIALIZED       => $this->addRule($typeRule),
            static::ATTRIBUTES_SERIALIZED => $this->addRules($attributeRules),
            static::TO_ONE_SERIALIZED     => $this->addRules($toOneRules),
            static::TO_MANY_SERIALIZED    => $this->addRules($toManyRules),
        ];

        $this->serializedRules[$name] = $ruleSet;

        $this->getSerializer()->clearBlocksWithStart()->clearBlocksWithEnd();

        return $this;
    }

    /**
     * @inheritdoc
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    public function getData(): array
    {
        return [
            static::SERIALIZED_RULES  => $this->serializedRules,
            static::SERIALIZED_BLOCKS => static::getBlocks(),
        ];
    }

    /**
     * @inheritdoc
     */
    public static function readRules(string $rulesClass, array $serializedData): array
    {
        assert(static::hasRules($rulesClass, $serializedData));

        $indexes = $serializedData[static::SERIALIZED_RULES][$rulesClass];

        return $indexes;
    }

    /**
     * @inheritdoc
     */
    public static function hasRules(string $name, array $serializedData): bool
    {
        // the value could be null so we have to check by key existence.
        return
            array_key_exists(static::SERIALIZED_RULES, $serializedData) === true &&
            array_key_exists($name, $serializedData[static::SERIALIZED_RULES]);
    }

    /**
     * @inheritdoc
     */
    public static function readBlocks(array $serializedData): array
    {
        assert(array_key_exists(static::SERIALIZED_BLOCKS, $serializedData));
        $serializedRules = $serializedData[static::SERIALIZED_BLOCKS];
        assert(is_array($serializedRules));

        return $serializedRules;
    }

    /**
     * @inheritdoc
     */
    public static function readIdRuleIndexes(array $serializedRules): array
    {
        assert(array_key_exists(static::ID_SERIALIZED, $serializedRules));
        $rule = $serializedRules[static::ID_SERIALIZED];
        assert(is_array($rule));

        return $rule;
    }

    /**
     * @inheritdoc
     */
    public static function readTypeRuleIndexes(array $serializedRules): array
    {
        assert(array_key_exists(static::TYPE_SERIALIZED, $serializedRules));
        $rule = $serializedRules[static::TYPE_SERIALIZED];
        assert(is_array($rule));

        return $rule;
    }

    /**
     * @inheritdoc
     */
    public static function readAttributeRulesIndexes(array $serializedRules): array
    {
        assert(array_key_exists(static::ATTRIBUTES_SERIALIZED, $serializedRules));
        $rules = $serializedRules[static::ATTRIBUTES_SERIALIZED];
        assert(is_array($rules));

        return $rules;
    }

    /**
     * @inheritdoc
     */
    public static function readToOneRulesIndexes(array $serializedRules): array
    {
        assert(array_key_exists(static::TO_ONE_SERIALIZED, $serializedRules));
        $rules = $serializedRules[static::TO_ONE_SERIALIZED];
        assert(is_array($rules));

        return $rules;
    }

    /**
     * @inheritdoc
     */
    public static function readToManyRulesIndexes(array $serializedRules): array
    {
        assert(array_key_exists(static::TO_MANY_SERIALIZED, $serializedRules));
        $rules = $serializedRules[static::TO_MANY_SERIALIZED];
        assert(is_array($rules));

        return $rules;
    }

    /**
     * @inheritdoc
     */
    public static function readRuleIndex(array $ruleIndexes): int
    {
        return parent::getRuleIndex($ruleIndexes);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @inheritdoc
     */
    public static function readRuleStartIndexes(array $ruleIndexes): array
    {
        return parent::getRuleStartIndexes($ruleIndexes);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @inheritdoc
     */
    public static function readRuleEndIndexes(array $ruleIndexes): array
    {
        return parent::getRuleEndIndexes($ruleIndexes);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @inheritdoc
     */
    public static function readRulesIndexes(array $arrayRuleIndexes): array
    {
        return parent::getRulesIndexes($arrayRuleIndexes);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @inheritdoc
     */
    public static function readRulesStartIndexes(array $arrayRuleIndexes): array
    {
        return parent::getRulesStartIndexes($arrayRuleIndexes);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @inheritdoc
     */
    public static function readRulesEndIndexes(array $arrayRuleIndexes): array
    {
        return parent::getRulesEndIndexes($arrayRuleIndexes);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @inheritdoc
     */
    public static function readSingleRuleIndexes(array $arrayRuleIndexes, string $name): array
    {
        return parent::geSingleRuleIndexes($arrayRuleIndexes, $name);
class Daddy
{
    protected function getFirstName()
    {
        return "Eidur";
    }

    protected function getSurName()
    {
        return "Gudjohnsen";
    }
}

class Son
{
    public function getFirstName()
    {
        return parent::getSurname();
    }
}
    }

    /**
     * @inheritdoc
     */
    public static function hasRule(int $index, array $blocks): bool
    {
        $result = array_key_exists($index, $blocks);

        return $result;
    }

    /**
     * @param string $rulesClass
     *
     * @return bool
     */
    private static function isRulesClass(string $rulesClass): bool
    {
        return
            class_exists($rulesClass) === true &&
            in_array(JsonApiDataRulesInterface::class, class_implements($rulesClass)) === true;
    }
}


1		<?php namespace Limoncello\Flute\Validation\JsonApi\Execution;
2
3		/**
4		* Copyright 2015-2018 [email protected]
5		*
6		* Licensed under the Apache License, Version 2.0 (the "License");
7		* you may not use this file except in compliance with the License.
8		* You may obtain a copy of the License at
9		*
10		* http://www.apache.org/licenses/LICENSE-2.0
11		*
12		* Unless required by applicable law or agreed to in writing, software
13		* distributed under the License is distributed on an "AS IS" BASIS,
14		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
15		* See the License for the specific language governing permissions and
16		* limitations under the License.
17		*/
18
19		use Limoncello\Flute\Contracts\Validation\JsonApiDataRulesInterface;
20		use Limoncello\Flute\Contracts\Validation\JsonApiDataRulesSerializerInterface;
21		use Limoncello\Flute\Validation\Serialize\RulesSerializer;
22		use Limoncello\Validation\Contracts\Rules\RuleInterface;
23		use Neomerx\JsonApi\Contracts\Document\DocumentInterface;
24
25		/**
26		* @package Limoncello\Flute
27		*
28		* @SuppressWarnings(PHPMD.TooManyPublicMethods)
29		*/
30		class JsonApiDataRulesSerializer extends RulesSerializer implements JsonApiDataRulesSerializerInterface
31		{
32		/** Serialized indexes key */
33		protected const SERIALIZED_RULES = 0;
34
35		/** Serialized rules key */
36		protected const SERIALIZED_BLOCKS = self::SERIALIZED_RULES + 1;
37
38		/** Index key */
39		protected const ID_SERIALIZED = 0;
40
41		/** Index key */
42		protected const TYPE_SERIALIZED = self::ID_SERIALIZED + 1;
43
44		/** Index key */
45		protected const ATTRIBUTES_SERIALIZED = self::TYPE_SERIALIZED + 1;
46
47		/** Index key */
48		protected const TO_ONE_SERIALIZED = self::ATTRIBUTES_SERIALIZED + 1;
49
50		/** Index key */
51		protected const TO_MANY_SERIALIZED = self::TO_ONE_SERIALIZED + 1;
52
53		/**
54		* @var array
55		*/
56		private $serializedRules = [];
57
58		/**
59		* @inheritdoc
60		*/
61	28	public function addRulesFromClass(string $rulesClass): JsonApiDataRulesSerializerInterface
62		{
63	28	assert(static::isRulesClass($rulesClass));
		0 ignored issues – show Bug introduced 2018-03-17 22:51 UTC by Report Bug Copy Issue Report Since `isRulesClass()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `isRulesClass()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
64
65	28	$name = $rulesClass;
66
67		/** @var JsonApiDataRulesInterface $rulesClass */
68
69	28	return $this->addDataRules(
70	28	$name,
71	28	$rulesClass::getIdRule(),
72	28	$rulesClass::getTypeRule(),
73	28	$rulesClass::getAttributeRules(),
74	28	$rulesClass::getToOneRelationshipRules(),
75	28	$rulesClass::getToManyRelationshipRules()
76		);
77		}
78
79		/**
80		* @inheritdoc
81		*/
82	44	public function addDataRules(
83		string $name,
84		RuleInterface $idRule,
85		RuleInterface $typeRule,
86		array $attributeRules,
87		array $toOneRules,
88		array $toManyRules
89		): JsonApiDataRulesSerializerInterface {
90	44	$idRule->setName(DocumentInterface::KEYWORD_ID)->enableCapture();
91	44	$typeRule->setName(DocumentInterface::KEYWORD_TYPE)->enableCapture();
92
93		$ruleSet = [
94	44	static::ID_SERIALIZED => $this->addRule($idRule),
95	44	static::TYPE_SERIALIZED => $this->addRule($typeRule),
96	44	static::ATTRIBUTES_SERIALIZED => $this->addRules($attributeRules),
97	44	static::TO_ONE_SERIALIZED => $this->addRules($toOneRules),
98	44	static::TO_MANY_SERIALIZED => $this->addRules($toManyRules),
99		];
100
101	44	$this->serializedRules[$name] = $ruleSet;
102
103	44	$this->getSerializer()->clearBlocksWithStart()->clearBlocksWithEnd();
104
105	44	return $this;
106		}
107
108		/**
109		* @inheritdoc
110		*
111		* @SuppressWarnings(PHPMD.StaticAccess)
112		*/
113	44	public function getData(): array
114		{
115		return [
116	44	static::SERIALIZED_RULES => $this->serializedRules,
117	44	static::SERIALIZED_BLOCKS => static::getBlocks(),
118		];
119		}
120
121		/**
122		* @inheritdoc
123		*/
124	26	public static function readRules(string $rulesClass, array $serializedData): array
125		{
126	26	assert(static::hasRules($rulesClass, $serializedData));
127
128	26	$indexes = $serializedData[static::SERIALIZED_RULES][$rulesClass];
129
130	26	return $indexes;
131		}
132
133		/**
134		* @inheritdoc
135		*/
136	26	public static function hasRules(string $name, array $serializedData): bool
137		{
138		// the value could be null so we have to check by key existence.
139		return
140	26	array_key_exists(static::SERIALIZED_RULES, $serializedData) === true &&
141	26	array_key_exists($name, $serializedData[static::SERIALIZED_RULES]);
142		}
143
144		/**
145		* @inheritdoc
146		*/
147	26	public static function readBlocks(array $serializedData): array
148		{
149	26	assert(array_key_exists(static::SERIALIZED_BLOCKS, $serializedData));
150	26	$serializedRules = $serializedData[static::SERIALIZED_BLOCKS];
151	26	assert(is_array($serializedRules));
152
153	26	return $serializedRules;
154		}
155
156		/**
157		* @inheritdoc
158		*/
159	26	public static function readIdRuleIndexes(array $serializedRules): array
160		{
161	26	assert(array_key_exists(static::ID_SERIALIZED, $serializedRules));
162	26	$rule = $serializedRules[static::ID_SERIALIZED];
163	26	assert(is_array($rule));
164
165	26	return $rule;
166		}
167
168		/**
169		* @inheritdoc
170		*/
171	26	public static function readTypeRuleIndexes(array $serializedRules): array
172		{
173	26	assert(array_key_exists(static::TYPE_SERIALIZED, $serializedRules));
174	26	$rule = $serializedRules[static::TYPE_SERIALIZED];
175	26	assert(is_array($rule));
176
177	26	return $rule;
178		}
179
180		/**
181		* @inheritdoc
182		*/
183	26	public static function readAttributeRulesIndexes(array $serializedRules): array
184		{
185	26	assert(array_key_exists(static::ATTRIBUTES_SERIALIZED, $serializedRules));
186	26	$rules = $serializedRules[static::ATTRIBUTES_SERIALIZED];
187	26	assert(is_array($rules));
188
189	26	return $rules;
190		}
191
192		/**
193		* @inheritdoc
194		*/
195	26	public static function readToOneRulesIndexes(array $serializedRules): array
196		{
197	26	assert(array_key_exists(static::TO_ONE_SERIALIZED, $serializedRules));
198	26	$rules = $serializedRules[static::TO_ONE_SERIALIZED];
199	26	assert(is_array($rules));
200
201	26	return $rules;
202		}
203
204		/**
205		* @inheritdoc
206		*/
207	26	public static function readToManyRulesIndexes(array $serializedRules): array
208		{
209	26	assert(array_key_exists(static::TO_MANY_SERIALIZED, $serializedRules));
210	26	$rules = $serializedRules[static::TO_MANY_SERIALIZED];
211	26	assert(is_array($rules));
212
213	26	return $rules;
214		}
215
216		/**
217		* @inheritdoc
218		*/
219	19	public static function readRuleIndex(array $ruleIndexes): int
220		{
221	19	return parent::getRuleIndex($ruleIndexes);
		0 ignored issues – show Comprehensibility Bug introduced 2018-03-17 22:51 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getRuleIndex()` instead of `readRuleIndex()`). Are you sure this is correct? If so, you might want to change this to `$this->getRuleIndex()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
222		}
223
224		/**
225		* @inheritdoc
226		*/
227	20	public static function readRuleStartIndexes(array $ruleIndexes): array
228		{
229	20	return parent::getRuleStartIndexes($ruleIndexes);
		0 ignored issues – show Comprehensibility Bug introduced 2018-03-17 22:51 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getRuleStartIndexes()` instead of `readRuleStartIndexes()`). Are you sure this is correct? If so, you might want to change this to `$this->getRuleStartIndexes()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
230		}
231
232		/**
233		* @inheritdoc
234		*/
235	20	public static function readRuleEndIndexes(array $ruleIndexes): array
236		{
237	20	return parent::getRuleEndIndexes($ruleIndexes);
		0 ignored issues – show Comprehensibility Bug introduced 2018-03-17 22:51 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getRuleEndIndexes()` instead of `readRuleEndIndexes()`). Are you sure this is correct? If so, you might want to change this to `$this->getRuleEndIndexes()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
238		}
239
240		/**
241		* @inheritdoc
242		*/
243	26	public static function readRulesIndexes(array $arrayRuleIndexes): array
244		{
245	26	return parent::getRulesIndexes($arrayRuleIndexes);
		0 ignored issues – show Comprehensibility Bug introduced 2018-03-17 22:51 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getRulesIndexes()` instead of `readRulesIndexes()`). Are you sure this is correct? If so, you might want to change this to `$this->getRulesIndexes()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
246		}
247
248		/**
249		* @inheritdoc
250		*/
251	26	public static function readRulesStartIndexes(array $arrayRuleIndexes): array
252		{
253	26	return parent::getRulesStartIndexes($arrayRuleIndexes);
		0 ignored issues – show Comprehensibility Bug introduced 2018-03-17 22:51 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getRulesStartIndexes()` instead of `readRulesStartIndexes()`). Are you sure this is correct? If so, you might want to change this to `$this->getRulesStartIndexes()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
254		}
255
256		/**
257		* @inheritdoc
258		*/
259	26	public static function readRulesEndIndexes(array $arrayRuleIndexes): array
260		{
261	26	return parent::getRulesEndIndexes($arrayRuleIndexes);
		0 ignored issues – show Comprehensibility Bug introduced 2018-03-17 22:51 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`getRulesEndIndexes()` instead of `readRulesEndIndexes()`). Are you sure this is correct? If so, you might want to change this to `$this->getRulesEndIndexes()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
262		}
263
264		/**
265		* @inheritdoc
266		*/
267	6	public static function readSingleRuleIndexes(array $arrayRuleIndexes, string $name): array
268		{
269	6	return parent::geSingleRuleIndexes($arrayRuleIndexes, $name);
		0 ignored issues – show Comprehensibility Bug introduced 2018-07-25 19:43 UTC by Report Bug Copy Issue Report It seems like you call parent on a different method (`geSingleRuleIndexes()` instead of `readSingleRuleIndexes()`). Are you sure this is correct? If so, you might want to change this to `$this->geSingleRuleIndexes()`. This check looks for a call to a parent method whose name is different than the method from which it is called. Consider the following code: class Daddy { protected function getFirstName() { return "Eidur"; } protected function getSurName() { return "Gudjohnsen"; } } class Son { public function getFirstName() { return parent::getSurname(); } } The `getFirstName()` method in the `Son` calls the wrong method in the parent class. Loading history...
270		}
271
272		/**
273		* @inheritdoc
274		*/
275	21	public static function hasRule(int $index, array $blocks): bool
276		{
277	21	$result = array_key_exists($index, $blocks);
278
279	21	return $result;
280		}
281
282		/**
283		* @param string $rulesClass
284		*
285		* @return bool
286		*/
287	28	private static function isRulesClass(string $rulesClass): bool
288		{
289		return
290	28	class_exists($rulesClass) === true &&
291	28	in_array(JsonApiDataRulesInterface::class, class_implements($rulesClass)) === true;
292		}
293		}
294

limoncello-php-dist / flute

Push — master ( 6173d9...210649 )

JsonApiDataRulesSerializer A

Complexity

Size/Duplication

Coupling/Cohesion

Test Coverage

Importance

20 Methods

Duplication Side-by-Side

Filter issues like