Limoncello\Core\Routing\Traits\HasRequestFactoryTrait

Complexity

Total Complexity

5

Size/Duplication

Total Lines	43
Duplicated Lines	0 %

Coupling/Cohesion

Components	1
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	setRequestFactory()	0	12	3
A	isRequestFactorySet()	0	4	1
A	getDefaultRequestFactory()	0	4	1

<?php declare(strict_types=1);

namespace Limoncello\Core\Routing\Traits;

/**
 * Copyright 2015-2020 info@neomerx.com
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

use Limoncello\Contracts\Core\SapiInterface;
use Limoncello\Core\Application\Application;
use LogicException;
use Psr\Container\ContainerInterface;
use Psr\Http\Message\ServerRequestInterface;

/**
 * @package Limoncello\Core
 *
 * @method string getCallableToCacheMessage();
 */
trait HasRequestFactoryTrait
{
    /**
     * @var callable|false|null
     */
    private $requestFactory = false;

    /**
     * @param callable|null $requestFactory
     *
     * @return self
     */
    public function setRequestFactory(callable $requestFactory = null): self
    {
        $parameters = [SapiInterface::class, ContainerInterface::class];
        if ($requestFactory !== null &&
            $this->checkPublicStaticCallable($requestFactory, $parameters, ServerRequestInterface::class) === false

It seems like checkPublicStaticCallable() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        ) {
            throw new LogicException($this->getCallableToCacheMessage());
        }
        $this->requestFactory = $requestFactory;

        return $this;
    }

    /**
     * @return bool
     */
    protected function isRequestFactorySet()
    {
        return $this->requestFactory !== false;
    }

    /**
     * @return callable

Consider making the return type a bit more specific; maybe use string[].

     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    protected function getDefaultRequestFactory(): callable
    {
        return Application::getDefaultRequestFactory();
    }
}