ComposerCommandProvider::setCommands() - Code Metrics - limoncello-php-dist/commands - Measure and Improve Code Quality continuously with Scrutinizer

ComposerCommandProvider::setCommands() A
last analyzed 2019-06-17 07:44 UTC

↳ Parent: ComposerCommandProvider

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	1
CRAP Score	1

Importance

Changes

Metric	Value
dl	0
loc	6
ccs	1
cts	1
cp	1
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1
crap	1

<?php declare(strict_types=1);

namespace Limoncello\Commands;

/**
 * Copyright 2015-2019 [email protected]
 *
 * Licensed under the Apache License, Version 2.0 (the "License");
 * you may not use this file except in compliance with the License.
 * You may obtain a copy of the License at
 *
 * http://www.apache.org/licenses/LICENSE-2.0
 *
 * Unless required by applicable law or agreed to in writing, software
 * distributed under the License is distributed on an "AS IS" BASIS,
 * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 * See the License for the specific language governing permissions and
 * limitations under the License.
 */

use Composer\Command\BaseCommand;
use Composer\Plugin\Capability\CommandProvider;
use function assert;

/**
 * @package Limoncello\Commands
 */
class ComposerCommandProvider implements CommandProvider
{
    /**
     * @var BaseCommand[]
     */
    private static $commands = [];

    /**
     * @inheritdoc
     */
    public function getCommands()
    {
        return static::$commands;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }

    /**
     * @param BaseCommand[] $commands
     *
     * @return void
     *
     * @SuppressWarnings(PHPMD.StaticAccess)
     */
    public static function setCommands(array $commands): void
    {
        assert(static::areCommands($commands) === true);
class YourClass
{
    private static function getTemperature() {
        return "3422 °C";
}

public static function getSomeVariable()
{
    return static::getTemperature();
}

        static::$commands = $commands;
class YourClass
{
    private static $someVariable;

    public static function getSomeVariable()
    {
        return static::$someVariable;
    }
}
    }

    /**
     * @param array $commands
     *
     * @return bool
     */
    private static function areCommands(array $commands): bool
    {
        $areCommands = true;

        foreach ($commands as $command) {
            $areCommands = $areCommands && ($command instanceof BaseCommand);
        }

        return $areCommands;
    }
}


1		<?php declare(strict_types=1);
2
3		namespace Limoncello\Commands;
4
5		/**
6		* Copyright 2015-2019 [email protected]
7		*
8		* Licensed under the Apache License, Version 2.0 (the "License");
9		* you may not use this file except in compliance with the License.
10		* You may obtain a copy of the License at
11		*
12		* http://www.apache.org/licenses/LICENSE-2.0
13		*
14		* Unless required by applicable law or agreed to in writing, software
15		* distributed under the License is distributed on an "AS IS" BASIS,
16		* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
17		* See the License for the specific language governing permissions and
18		* limitations under the License.
19		*/
20
21		use Composer\Command\BaseCommand;
22		use Composer\Plugin\Capability\CommandProvider;
23		use function assert;
24
25		/**
26		* @package Limoncello\Commands
27		*/
28		class ComposerCommandProvider implements CommandProvider
29		{
30		/**
31		* @var BaseCommand[]
32		*/
33		private static $commands = [];
34
35	1	/**
36		* @inheritdoc
37	1	*/
38		public function getCommands()
39		{
40		return static::$commands;
		0 ignored issues – show Bug introduced 2017-08-15 23:15 UTC by Report Bug Copy Issue Report Since `$commands` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$commands` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
41		}
42
43		/**
44		* @param BaseCommand[] $commands
45		*
46		* @return void
47	1	*
48		* @SuppressWarnings(PHPMD.StaticAccess)
49	1	*/
50		public static function setCommands(array $commands): void
51	1	{
52		assert(static::areCommands($commands) === true);
		0 ignored issues – show Bug introduced 2017-08-15 23:15 UTC by Report Bug Copy Issue Report Since `areCommands()` is declared private, calling it with `static` will lead to errors in possible sub-classes. You can either use `self`, or increase the visibility of `areCommands()` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return static::getTemperature(); } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { private static function getTemperature() { return "-182 °C"; } } print YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class YourClass { private static function getTemperature() { return "3422 °C"; } public static function getSomeVariable() { return self::getTemperature(); } } Loading history...
53
54		static::$commands = $commands;
		0 ignored issues – show Bug introduced 2017-08-15 23:15 UTC by Report Bug Copy Issue Report Since `$commands` is declared private, accessing it with `static` will lead to errors in possible sub-classes; consider using `self`, or increasing the visibility of `$commands` to at least protected. Let’s assume you have a class which uses late-static binding: class YourClass { private static $someVariable; public static function getSomeVariable() { return static::$someVariable; } } The code above will run fine in your PHP runtime. However, if you now create a sub-class and call the `getSomeVariable()` on that sub-class, you will receive a runtime error: class YourSubClass extends YourClass { } YourSubClass::getSomeVariable(); // Will cause an access error. In the case above, it makes sense to update `SomeClass` to use `self` instead: class SomeClass { private static $someVariable; public static function getSomeVariable() { return self::$someVariable; // self works fine with private. } } Loading history...
55		}
56
57		/**
58		* @param array $commands
59	1	*
60		* @return bool
61	1	*/
62		private static function areCommands(array $commands): bool
63	1	{
64	1	$areCommands = true;
65
66		foreach ($commands as $command) {
67	1	$areCommands = $areCommands && ($command instanceof BaseCommand);
68		}
69
70		return $areCommands;
71		}
72		}
73

limoncello-php-dist / commands

ComposerCommandProvider::setCommands() A last analyzed 2019-06-17 07:44 UTC

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like

ComposerCommandProvider::setCommands() A
last analyzed 2019-06-17 07:44 UTC