Issues (107)

Security Analysis    not enabled

This project does not seem to handle request data directly as such no vulnerable execution paths were found.

  Cross-Site Scripting
Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.
  File Exposure
File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.
  File Manipulation
File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.
  Object Injection
Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.
  Code Injection
Code Injection enables an attacker to execute arbitrary code on the server.
  Response Splitting
Response Splitting can be used to send arbitrary responses.
  File Inclusion
File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.
  Command Injection
Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.
  SQL Injection
SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.
  XPath Injection
XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.
  LDAP Injection
LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.
  Header Injection
  Other Vulnerability
This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.
  Regex Injection
Regex Injection enables an attacker to execute arbitrary code in your PHP process.
  XML Injection
XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.
  Variable Injection
Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.
Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

DoctrineMigrations/V2MigrationsLoader.php (1 issue)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
declare(strict_types=1);
4
5
namespace Liip\MonitorBundle\DependencyInjection\DoctrineMigrations;
6
7
use Doctrine\DBAL\Connection;
8
use Doctrine\DBAL\Driver\PDO\SQLite\Driver;
9
use Doctrine\DBAL\Driver\PDOSqlite\Driver as LegacyDriver;
10
use Doctrine\Migrations\Configuration\AbstractFileConfiguration;
11
use Doctrine\Migrations\Configuration\Configuration as DoctrineMigrationConfiguration;
12
use Liip\MonitorBundle\DoctrineMigrations\Configuration;
13
use Symfony\Component\DependencyInjection\ChildDefinition;
14
use Symfony\Component\DependencyInjection\Compiler\CompilerPassInterface;
15
use Symfony\Component\DependencyInjection\ContainerBuilder;
16
use Symfony\Component\DependencyInjection\Definition;
17
use Symfony\Component\DependencyInjection\Reference;
18
19
/**
20
 * Class V2MigrationsLoader.
21
 */
22
final class V2MigrationsLoader extends AbstractDoctrineMigrationsLoader implements CompilerPassInterface
23
{
24
    /**
25
     * Connection object needed for correct migration loading.
26
     *
27
     * @var Connection
28
     */
29
    private $fakeConnection;
30
31
    /**
32
     * Tuple (migrationsConfiguration, tempConfiguration) for doctrine migrations check.
33
     *
34
     * @var array
35
     */
36
    private $migrationConfigurationsServices = [];
37
38
    public function process(ContainerBuilder $container)
39
    {
40
        foreach ($this->migrationConfigurationsServices as $services) {
41
            [$configurationService, $configuration] = $services;
42
            /** @var Definition $configurationService */
43
            /** @var DoctrineMigrationConfiguration $configuration */
44
            $versions = $this->getPredefinedMigrations($container, $configuration, $this->fakeConnection);
45
            if ($versions) {
46
                $configurationService->addMethodCall('registerMigrations', [$versions]);
47
            }
48
        }
49
    }
50
51
    public function createMigrationConfigurationService(
52
        ContainerBuilder $container,
53
        string $connectionName,
54
        string $serviceId,
55
        string $filename = null
56
    ): void {
57
        if (!$container->has(Configuration::class)) {
58
            $container->register(Configuration::class)
59
                ->setAbstract(true)
60
                ->setPublic(true)
61
                ->setArguments([null])
62
                ->addMethodCall('setContainer', [new Reference('service_container')]);
63
        }
64
65
        $configuration = $this->createTemporaryConfiguration($container, $this->getConnection(), $filename);
66
67
        $serviceConfiguration = new ChildDefinition(Configuration::class);
68
69
        $this->migrationConfigurationsServices[] = [$serviceConfiguration, $configuration];
70
71
        $serviceConfiguration->replaceArgument(
72
            0,
73
            new Reference(sprintf('doctrine.dbal.%s_connection', $connectionName))
74
        );
75
76
        if ($configuration->getMigrationsNamespace()) {
77
            $serviceConfiguration->addMethodCall(
78
                'setMigrationsNamespace',
79
                [$configuration->getMigrationsNamespace()]
80
            );
81
        }
82
83
        if ($configuration->getMigrationsTableName()) {
84
            $serviceConfiguration->addMethodCall(
85
                'setMigrationsTableName',
86
                [$configuration->getMigrationsTableName()]
87
            );
88
        }
89
90
        if ($configuration->getMigrationsColumnName()) {
91
            $serviceConfiguration->addMethodCall(
92
                'setMigrationsColumnName',
93
                [$configuration->getMigrationsColumnName()]
94
            );
95
        }
96
97
        if ($configuration->getName()) {
98
            $serviceConfiguration->addMethodCall('setName', [$configuration->getName()]);
99
        }
100
101
        if ($configuration->getMigrationsDirectory()) {
102
            $directory = $configuration->getMigrationsDirectory();
103
            $pathPlaceholders = ['kernel.root_dir', 'kernel.cache_dir', 'kernel.logs_dir'];
104
            foreach ($pathPlaceholders as $parameter) {
105
                $kernelDir = realpath($container->getParameter($parameter));
106
                if (0 === strpos(realpath($directory), $kernelDir)) {
107
                    $directory = str_replace($kernelDir, "%{$parameter}%", $directory);
108
                    break;
109
                }
110
            }
111
112
            $serviceConfiguration->addMethodCall(
113
                'setMigrationsDirectory',
114
                [$directory]
115
            );
116
        }
117
118
        $serviceConfiguration->addMethodCall('configure', []);
119
120
        if ($configuration->areMigrationsOrganizedByYear()) {
121
            $serviceConfiguration->addMethodCall('setMigrationsAreOrganizedByYear', [true]);
122
        } elseif ($configuration->areMigrationsOrganizedByYearAndMonth()) {
123
            $serviceConfiguration->addMethodCall('setMigrationsAreOrganizedByYearAndMonth', [true]);
124
        }
125
126
        $container->setDefinition($serviceId, $serviceConfiguration);
127
    }
128
129
    /**
130
     * Creates in-memory migration configuration for setting up container service.
131
     *
132
     * @param ContainerBuilder $container  The container
133
     * @param Connection       $connection Fake connection
134
     * @param string           $filename   Migrations configuration file
135
     */
136
    private function createTemporaryConfiguration(
137
        ContainerBuilder $container,
138
        Connection $connection,
139
        string $filename = null
140
    ): DoctrineMigrationConfiguration {
141
        if (null === $filename) {
142
            // this is configured from migrations bundle
143
            return new DoctrineMigrationConfiguration($connection);
144
        }
145
146
        // -------
147
        // This part must be in sync with Doctrine\Migrations\Tools\Console\Helper\ConfigurationHelper::loadConfig
148
        $map = [
149
            'xml' => '\XmlConfiguration',
150
            'yaml' => '\YamlConfiguration',
151
            'yml' => '\YamlConfiguration',
152
            'php' => '\ArrayConfiguration',
153
            'json' => '\JsonConfiguration',
154
        ];
155
        // --------
156
157
        $filename = $container->getParameterBag()->resolveValue($filename);
158
        $info = pathinfo($filename);
159
        // check we can support this file type
160
        if (empty($map[$info['extension']])) {
161
            throw new \InvalidArgumentException('Given config file type is not supported');
162
        }
163
164
        $class = 'Doctrine\Migrations\Configuration';
165
        $class .= $map[$info['extension']];
166
        // -------
167
168
        /** @var AbstractFileConfiguration $configuration */
169
        $configuration = new $class($connection);
170
        $configuration->load($filename);
171
        $configuration->validate();
172
173
        return $configuration;
174
    }
175
176
    private function getConnection(): Connection
177
    {
178
        if (null === $this->fakeConnection) {
179
            if (!class_exists(Connection::class)) {
180
                throw new \InvalidArgumentException(sprintf('Can not configure doctrine migration checks, because of absence of "%s" class', Connection::class));
181
            }
182
183
            $driver = class_exists(Driver::class)
184
                ? new Driver()
185
                : new LegacyDriver();
186
187
            $this->fakeConnection = new Connection([], $driver);
188
        }
189
190
        return $this->fakeConnection;
191
    }
192
193
    /**
194
     * Return key-value array with migration version as key and class as a value defined in config file.
195
     *
196
     * @param ContainerBuilder               $container  The container
197
     * @param DoctrineMigrationConfiguration $config     Current configuration
198
     * @param Connection                     $connection Fake connections
199
     *
200
     * @return string[]
201
     */
202
    private function getPredefinedMigrations(ContainerBuilder $container, DoctrineMigrationConfiguration $config, Connection $connection): array
203
    {
204
        $result = [];
205
206
        $diff = new Configuration($connection);
207
208
        if ($namespace = $config->getMigrationsNamespace()) {
0 ignored issues
show
$namespace is not used, you could remove the assignment.

This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently.

$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

Both the $myVar assignment in line 1 and the $higher assignment in line 2 are dead. The first because $myVar is never used and the second because $higher is always overwritten for every possible time line.

Loading history...
209
            $diff->setMigrationsNamespace($config->getMigrationsNamespace());
210
        }
211
212
        if ($dir = $config->getMigrationsDirectory()) {
213
            $diff->setMigrationsDirectory($dir);
214
        }
215
216
        $diff->setContainer($container);
217
        $diff->configure();
218
219
        foreach ($config->getMigrations() as $version) {
220
            $result[$version->getVersion()] = get_class($version->getMigration());
221
        }
222
223
        foreach ($diff->getAvailableVersions() as $version) {
224
            unset($result[$version]);
225
        }
226
227
        return $result;
228
    }
229
}
230