PathHelperTest::testGenerateRoutes() - Code Metrics - Inspection of "Added fallback for undefined services of symfony3" - liip/LiipMonitorBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#145)

by Thanos

created 2017-05-05 14:15 UTC

PathHelperTest::testGenerateRoutes() A

↳ Parent: PathHelperTest

Complexity

Conditions	3
Paths	2

Size

Total Lines	19
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	19
rs	9.4285
cc	3
eloc	10
nc	2
nop	0

<?php
namespace Liip\MonitorBundle\Tests\Helper;

use Liip\MonitorBundle\Helper\PathHelper;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\HttpKernel\Kernel;

class PathHelperTest extends WebTestCase
{
    public function testGenerateRoutes()
    {
        if (Kernel::MAJOR_VERSION === '2' && Kernel::MINOR_VERSION === '7') {
            $environment = 'symfony27';
        } else {
            $environment = 'symfony' . Kernel::MAJOR_VERSION;
        }

        $client = static::createClient(array('environment' => $environment));

        $container = $client->getContainer();

        $pathHelper = new PathHelper($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        // test route is defined in Tests/app/routing.yml
        $routes = $pathHelper->generateRoutes(['test_route' => []]);

        $this->assertEquals(['api.test_route = "/monitor";'], $routes);
    }
}


1			<?php
2			namespace Liip\MonitorBundle\Tests\Helper;
3
4			use Liip\MonitorBundle\Helper\PathHelper;
5			use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
6			use Symfony\Component\HttpKernel\Kernel;
7
8			class PathHelperTest extends WebTestCase
9			{
10			public function testGenerateRoutes()
11			{
12			if (Kernel::MAJOR_VERSION === '2' && Kernel::MINOR_VERSION === '7') {
13			$environment = 'symfony27';
14			} else {
15			$environment = 'symfony' . Kernel::MAJOR_VERSION;
16			}
17
18			$client = static::createClient(array('environment' => $environment));
19
20			$container = $client->getContainer();
21
22			$pathHelper = new PathHelper($container);
			0 ignored issues – show Bug introduced 2017-05-05 11:42 UTC by Report Bug Copy Issue Report It seems like `$container` defined by `$client->getContainer()` on line `20` can be `null`; however, `Liip\MonitorBundle\Helpe...thHelper::__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
23
24			// test route is defined in Tests/app/routing.yml
25			$routes = $pathHelper->generateRoutes(['test_route' => []]);
26
27			$this->assertEquals(['api.test_route = "/monitor";'], $routes);
28			}
29			}
30

liip / LiipMonitorBundle

Pull Request — master (#145)

PathHelperTest::testGenerateRoutes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like