DoctrineMongoDbCollection::__construct() - Code Metrics - Inspection of "Merge pull request #148 from tegbessou/add-mongodb..." - liip/LiipMonitorBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 255f7a...c09052 )

by Lukas Kahwe

created 2017-07-17 10:47 UTC

DoctrineMongoDbCollection::__construct() A

↳ Parent: DoctrineMongoDbCollection

Complexity

Conditions	3
Paths	4

Size

Total Lines	13
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	13
rs	9.4285
cc	3
eloc	7
nc	4
nop	2

<?php

namespace Liip\MonitorBundle\Check;

use Doctrine\Common\Persistence\ConnectionRegistry;
use ZendDiagnostics\Check\CheckCollectionInterface;

/**
 * @author Hugues Gobet <[email protected]>
 */
class DoctrineMongoDbCollection implements CheckCollectionInterface
{
    private $checks = array();

    public function __construct(ConnectionRegistry $manager, $connections)
    {
        if (!is_array($connections)) {
            $connections = array($connections);
        }

        foreach ($connections as $connection) {
            $check = new DoctrineMongoDb($manager, $connection);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
            $check->setLabel(sprintf('Doctrine Mongo Db "%s" connection', $connection));

            $this->checks[sprintf('doctrine_dbal_%s_connection', $connection)] = $check;
        }
    }

    /**
     * {@inheritdoc}
     */
    public function getChecks()
    {
        return $this->checks;
    }
}


1			<?php
2
3			namespace Liip\MonitorBundle\Check;
4
5			use Doctrine\Common\Persistence\ConnectionRegistry;
6			use ZendDiagnostics\Check\CheckCollectionInterface;
7
8			/**
9			* @author Hugues Gobet <[email protected]>
10			*/
11			class DoctrineMongoDbCollection implements CheckCollectionInterface
12			{
13			private $checks = array();
14
15			public function __construct(ConnectionRegistry $manager, $connections)
16			{
17			if (!is_array($connections)) {
18			$connections = array($connections);
19			}
20
21			foreach ($connections as $connection) {
22			$check = new DoctrineMongoDb($manager, $connection);
			0 ignored issues – show Documentation introduced 2017-07-13 13:19 UTC by Report Bug Copy Issue Report `$manager` is of type `object<Doctrine\Common\P...nce\ConnectionRegistry>`, but the function expects a `object<Doctrine\Bundle\M...Bundle\ManagerRegistry>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
23			$check->setLabel(sprintf('Doctrine Mongo Db "%s" connection', $connection));
24
25			$this->checks[sprintf('doctrine_dbal_%s_connection', $connection)] = $check;
26			}
27			}
28
29			/**
30			* {@inheritdoc}
31			*/
32			public function getChecks()
33			{
34			return $this->checks;
35			}
36			}
37

liip / LiipMonitorBundle

Push — master ( 255f7a...c09052 )

DoctrineMongoDbCollection::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like