YamlFileCollection::__construct() - Code Metrics - Inspection of "Label for checks" - liip/LiipMonitorBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#250)

unknown

created 2020-11-10 09:47 UTC

YamlFileCollection::__construct() A

↳ Parent: YamlFileCollection

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	13
Ratio	100 %

Importance

Changes

Metric	Value
dl	13
loc	13
rs	9.8333
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

declare(strict_types=1);

namespace Liip\MonitorBundle\Check;

use Laminas\Diagnostics\Check\CheckCollectionInterface;
use Laminas\Diagnostics\Check\CheckInterface;

class YamlFileCollection implements CheckCollectionInterface

{
    /**
     * @var CheckInterface[]
     */
    private $checks = [];

    public function __construct(array $configs)
    {
        foreach ($configs as $config) {
            $path = $config['path'];

            $check = new YamlFile($path);

            $label = $config['label'] ?? sprintf('YAML file `%s` exists and valid', $path);
            $check->setLabel($label);

            $this->checks[sprintf('file_yaml_%s', $path)] = $check;
        }
    }

    /**
     * @return CheckInterface[]
     */
    public function getChecks(): array
    {
        return $this->checks;
    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Liip\MonitorBundle\Check;
6
7		use Laminas\Diagnostics\Check\CheckCollectionInterface;
8		use Laminas\Diagnostics\Check\CheckInterface;
9
10	View Code Duplication	class YamlFileCollection implements CheckCollectionInterface
		0 ignored issues – show Duplication introduced 2020-11-10 10:07 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		/**
13		* @var CheckInterface[]
14		*/
15		private $checks = [];
16
17		public function __construct(array $configs)
18		{
19		foreach ($configs as $config) {
20		$path = $config['path'];
21
22		$check = new YamlFile($path);
23
24		$label = $config['label'] ?? sprintf('YAML file `%s` exists and valid', $path);
25		$check->setLabel($label);
26
27		$this->checks[sprintf('file_yaml_%s', $path)] = $check;
28		}
29		}
30
31		/**
32		* @return CheckInterface[]
33		*/
34		public function getChecks(): array
35		{
36		return $this->checks;
37		}
38		}
39

liip / LiipMonitorBundle

Pull Request — master (#250)

YamlFileCollection::__construct() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like