PathHelperTest::testGenerateRoutes() - Code Metrics - Inspection of "Added fallback for undefined services of symfony3" - liip/LiipMonitorBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#145)

by Thanos

created 2017-05-05 11:38 UTC

PathHelperTest::testGenerateRoutes() A

↳ Parent: PathHelperTest

Complexity

Conditions	1
Paths	1

Size

Total Lines	18
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
c	1
b	0
f	0
dl	0
loc	18
rs	9.4285
cc	1
eloc	9
nc	1
nop	0

<?php
namespace Liip\MonitorBundle\Tests\Helper;

use Liip\MonitorBundle\Helper\PathHelper;
use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
use Symfony\Component\HttpFoundation\Request;

class PathHelperTest extends WebTestCase
{
    public function testGenerateRoutes()
    {
        $client = static::createClient(array('environment' => 'twig'));

        // mock a request flow to allow testing without enabling assets
        // (which causes compatibility issues with old symfony versions)
        $container = $client->getContainer();
        $request = new Request();
        $container->enterScope('request');

        $container->set('request', $request, 'request');


        $pathHelper = new PathHelper($container);
/** @return stdClass|null */
function mayReturnNull() { }

function doesNotAcceptNull(stdClass $x) { }

// With potential error.
function withoutCheck() {
    $x = mayReturnNull();
    doesNotAcceptNull($x); // Potential error here.
}

// Safe - Alternative 1
function withCheck1() {
    $x = mayReturnNull();
    if ( ! $x instanceof stdClass) {
        throw new \LogicException('$x must be defined.');
    }
    doesNotAcceptNull($x);
}

// Safe - Alternative 2
function withCheck2() {
    $x = mayReturnNull();
    if ($x instanceof stdClass) {
        doesNotAcceptNull($x);
    }
}

        // test route is defined in Tests/app/routing.yml
        $routes = $pathHelper->generateRoutes(['test_route' => []]);

        $this->assertEquals(['api.test_route = "/monitor";'], $routes);
    }
}


1			<?php
2			namespace Liip\MonitorBundle\Tests\Helper;
3
4			use Liip\MonitorBundle\Helper\PathHelper;
5			use Symfony\Bundle\FrameworkBundle\Test\WebTestCase;
6			use Symfony\Component\HttpFoundation\Request;
7
8			class PathHelperTest extends WebTestCase
9			{
10			public function testGenerateRoutes()
11			{
12			$client = static::createClient(array('environment' => 'twig'));
13
14			// mock a request flow to allow testing without enabling assets
15			// (which causes compatibility issues with old symfony versions)
16			$container = $client->getContainer();
17			$request = new Request();
18			$container->enterScope('request');
			0 ignored issues – show Bug introduced 2017-05-05 11:42 UTC by Report Bug Copy Issue Report The method `enterScope()` does not seem to exist on `object<Symfony\Component...ion\ContainerInterface>`. This check looks for calls to methods that do not seem to exist on a given type. It looks for the method on the type itself as well as in inherited classes or implemented interfaces. This is most likely a typographical error or the method has been renamed. Loading history...
19			$container->set('request', $request, 'request');
			0 ignored issues – show Unused Code introduced 2017-05-05 11:42 UTC by Report Bug Copy Issue Report The call to `ContainerInterface::set()` has too many arguments starting with `'request'`. This check compares calls to functions or methods with their respective definitions. If the call has more arguments than are defined, it raises an issue. If a function is defined several times with a different number of parameters, the check may pick up the wrong definition and report false positives. One codebase where this has been known to happen is Wordpress. In this case you can add the `@ignore` PhpDoc annotation to the duplicate definition and it will be ignored. Loading history...
20
21			$pathHelper = new PathHelper($container);
			0 ignored issues – show Bug introduced 2017-05-05 11:42 UTC by Report Bug Copy Issue Report It seems like `$container` defined by `$client->getContainer()` on line `16` can be `null`; however, `Liip\MonitorBundle\Helpe...thHelper::__construct()` does not accept `null`, maybe add an additional type check? Unless you are absolutely sure that the expression can never be null because of other conditions, we strongly recommend to add an additional type check to your code: /** @return stdClass\|null */ function mayReturnNull() { } function doesNotAcceptNull(stdClass $x) { } // With potential error. function withoutCheck() { $x = mayReturnNull(); doesNotAcceptNull($x); // Potential error here. } // Safe - Alternative 1 function withCheck1() { $x = mayReturnNull(); if ( ! $x instanceof stdClass) { throw new \LogicException('$x must be defined.'); } doesNotAcceptNull($x); } // Safe - Alternative 2 function withCheck2() { $x = mayReturnNull(); if ($x instanceof stdClass) { doesNotAcceptNull($x); } } Loading history...
22
23			// test route is defined in Tests/app/routing.yml
24			$routes = $pathHelper->generateRoutes(['test_route' => []]);
25
26			$this->assertEquals(['api.test_route = "/monitor";'], $routes);
27			}
28			}
29

liip / LiipMonitorBundle

Pull Request — master (#145)

PathHelperTest::testGenerateRoutes() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like