Liip\MonitorBundle\Check\RedisCollection

Complexity

Total Complexity

7

Size/Duplication

Total Lines	42
Duplicated Lines	52.38 %

Coupling/Cohesion

Components	0
Dependencies	1

Test Coverage

Coverage

100%

Importance

Changes

0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	13	13	3
A	parseDsn()	9	18	3
A	getChecks()	0	4	1

<?php

namespace Liip\MonitorBundle\Check;

use Laminas\Diagnostics\Check\CheckCollectionInterface;
use Laminas\Diagnostics\Check\Redis;

/**
 * @author Kevin Bond <kevinbond@gmail.com>
 */
class RedisCollection implements CheckCollectionInterface
{
    private $checks = [];

    public function __construct(array $configs)

This method seems to be duplicated in your project.

    {
        foreach ($configs as $name => $config) {
            if (isset($config['dsn'])) {
                $this->parseDsn($config);
            }

            $check = new Redis($config['host'], $config['port'], $config['password']);
            $check->setLabel(\sprintf('Redis "%s"', $name));

            $this->checks[\sprintf('redis_%s', $name)] = $check;
        }
    }

    private function parseDsn(array &$config)
    {
        $config = \array_merge($config, \parse_url($config['dsn']));

        if (isset($config['pass'])) {
            $config['password'] = $config['pass'];
            // Cleanup
            unset($config['pass']);
        } elseif (isset($config['user'])) {

This code seems to be duplicated across your project.

            /*
             * since "redis://my-super-secret-password@redis-host:6379" is a valid redis
             * dsn but \parse_url does not understand this notation and extracts the auth as user,
             * we need to check for it.
             */
            $config['password'] = $config['user'];
            unset($config['user']);
        }
    }

    public function getChecks()
    {
        return $this->checks;
    }
}