Issues in WebPathResolver.php (master) - Issues in master - liip/LiipImagineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Issues (94)

Security Analysis not enabled

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

Imagine/Cache/Resolver/WebPathResolver.php (5 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

/*
 * This file is part of the `liip/LiipImagineBundle` project.
 *
 * (c) https://github.com/liip/LiipImagineBundle/graphs/contributors
 *
 * For the full copyright and license information, please view the LICENSE.md
 * file that was distributed with this source code.
 */

namespace Liip\ImagineBundle\Imagine\Cache\Resolver;

use Liip\ImagineBundle\Binary\BinaryInterface;
use Liip\ImagineBundle\Imagine\Cache\Helper\PathHelper;
use Symfony\Component\Filesystem\Filesystem;
use Symfony\Component\Routing\RequestContext;

class WebPathResolver implements ResolverInterface
{
    /**
     * @var Filesystem
     */
    protected $filesystem;

    /**
     * @var RequestContext
     */
    protected $requestContext;

    /**
     * @var string
     */
    protected $webRoot;

    /**
     * @var string
     */
    protected $cachePrefix;

    /**
     * @var string
     */
    protected $cacheRoot;

    /**
     * @param string $webRootDir
     * @param string $cachePrefix
     */
    public function __construct(
        Filesystem $filesystem,
        RequestContext $requestContext,
        $webRootDir,
        $cachePrefix = 'media/cache'
    ) {
        $this->filesystem = $filesystem;
        $this->requestContext = $requestContext;

        $this->webRoot = rtrim(str_replace('//', '/', $webRootDir), '/');
        $this->cachePrefix = ltrim(str_replace('//', '/', $cachePrefix), '/');
        $this->cacheRoot = $this->webRoot.'/'.$this->cachePrefix;
    }

    /**
     * {@inheritdoc}
     */
    public function resolve($path, $filter)

    {
        return sprintf('%s/%s',
            rtrim($this->getBaseUrl(), '/'),
            ltrim($this->getFileUrl($path, $filter), '/')
        );
    }

    /**
     * {@inheritdoc}
     */
    public function isStored($path, $filter)
    {
        return is_file($this->getFilePath($path, $filter));
    }

    /**
     * {@inheritdoc}
     */
    public function store(BinaryInterface $binary, $path, $filter)
    {
        $this->filesystem->dumpFile(
            $this->getFilePath($path, $filter),
            $binary->getContent()
        );
    }

    /**
     * {@inheritdoc}
     */
    public function remove(array $paths, array $filters)
    {
        if (empty($paths) && empty($filters)) {
            return;
        }

        if (empty($paths)) {
            $filtersCacheDir = [];
            foreach ($filters as $filter) {
                $filtersCacheDir[] = $this->cacheRoot.'/'.$filter;
            }

            $this->filesystem->remove($filtersCacheDir);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

            return;
        }

        foreach ($paths as $path) {
            foreach ($filters as $filter) {
                $this->filesystem->remove($this->getFilePath($path, $filter));
            }
        }
    }

    /**
     * {@inheritdoc}
     */
    protected function getFilePath($path, $filter)
    {
        return $this->webRoot.'/'.$this->getFullPath($path, $filter);
    }

    /**
     * {@inheritdoc}
     */
    protected function getFileUrl($path, $filter)
    {
        return PathHelper::filePathToUrlPath($this->getFullPath($path, $filter));
    }

    /**
     * @return string
     */
    protected function getBaseUrl()
    {
        $port = '';
        if ('https' === $this->requestContext->getScheme() && 443 !== $this->requestContext->getHttpsPort()) {

            $port = ":{$this->requestContext->getHttpsPort()}";
        }

        if ('http' === $this->requestContext->getScheme() && 80 !== $this->requestContext->getHttpPort()) {

            $port = ":{$this->requestContext->getHttpPort()}";
        }

        $baseUrl = $this->requestContext->getBaseUrl();
        if ('.php' === mb_substr($this->requestContext->getBaseUrl(), -4)) {
            $baseUrl = pathinfo($this->requestContext->getBaseurl(), PATHINFO_DIRNAME);
        }
        $baseUrl = rtrim($baseUrl, '/\\');

        return sprintf('%s://%s%s%s',
            $this->requestContext->getScheme(),
            $this->requestContext->getHost(),
            $port,
            $baseUrl
        );
    }

    private function getFullPath($path, $filter)

    {
        // crude way of sanitizing URL scheme ("protocol") part
        $path = str_replace('://', '---', $path);

        return $this->cachePrefix.'/'.$filter.'/'.ltrim($path, '/');
    }
}


1		<?php
2
3		/*
4		* This file is part of the `liip/LiipImagineBundle` project.
5		*
6		* (c) https://github.com/liip/LiipImagineBundle/graphs/contributors
7		*
8		* For the full copyright and license information, please view the LICENSE.md
9		* file that was distributed with this source code.
10		*/
11
12		namespace Liip\ImagineBundle\Imagine\Cache\Resolver;
13
14		use Liip\ImagineBundle\Binary\BinaryInterface;
15		use Liip\ImagineBundle\Imagine\Cache\Helper\PathHelper;
16		use Symfony\Component\Filesystem\Filesystem;
17		use Symfony\Component\Routing\RequestContext;
18
19		class WebPathResolver implements ResolverInterface
20		{
21		/**
22		* @var Filesystem
23		*/
24		protected $filesystem;
25
26		/**
27		* @var RequestContext
28		*/
29		protected $requestContext;
30
31		/**
32		* @var string
33		*/
34		protected $webRoot;
35
36		/**
37		* @var string
38		*/
39		protected $cachePrefix;
40
41		/**
42		* @var string
43		*/
44		protected $cacheRoot;
45
46		/**
47		* @param string $webRootDir
48		* @param string $cachePrefix
49		*/
50		public function __construct(
51		Filesystem $filesystem,
52		RequestContext $requestContext,
53		$webRootDir,
54		$cachePrefix = 'media/cache'
55		) {
56		$this->filesystem = $filesystem;
57		$this->requestContext = $requestContext;
58
59		$this->webRoot = rtrim(str_replace('//', '/', $webRootDir), '/');
60		$this->cachePrefix = ltrim(str_replace('//', '/', $cachePrefix), '/');
61		$this->cacheRoot = $this->webRoot.'/'.$this->cachePrefix;
62		}
63
64		/**
65		* {@inheritdoc}
66		*/
67	View Code Duplication	public function resolve($path, $filter)
		0 ignored issues – show Duplication introduced 2019-08-22 12:13 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
68		{
69		return sprintf('%s/%s',
70		rtrim($this->getBaseUrl(), '/'),
71		ltrim($this->getFileUrl($path, $filter), '/')
72		);
73		}
74
75		/**
76		* {@inheritdoc}
77		*/
78		public function isStored($path, $filter)
79		{
80		return is_file($this->getFilePath($path, $filter));
81		}
82
83		/**
84		* {@inheritdoc}
85		*/
86		public function store(BinaryInterface $binary, $path, $filter)
87		{
88		$this->filesystem->dumpFile(
89		$this->getFilePath($path, $filter),
90		$binary->getContent()
91		);
92		}
93
94		/**
95		* {@inheritdoc}
96		*/
97		public function remove(array $paths, array $filters)
98		{
99		if (empty($paths) && empty($filters)) {
100		return;
101		}
102
103		if (empty($paths)) {
104		$filtersCacheDir = [];
105		foreach ($filters as $filter) {
106		$filtersCacheDir[] = $this->cacheRoot.'/'.$filter;
107		}
108
109		$this->filesystem->remove($filtersCacheDir);
		0 ignored issues – show Documentation introduced 2017-11-24 14:23 UTC by Report Bug Copy Issue Report Show Similar Issues like this `$filtersCacheDir` is of type `array`, but the function expects a `string\|object<Symfony\Co...nt\Filesystem\iterable>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
110
111		return;
112		}
113
114		foreach ($paths as $path) {
115		foreach ($filters as $filter) {
116		$this->filesystem->remove($this->getFilePath($path, $filter));
117		}
118		}
119		}
120
121		/**
122		* {@inheritdoc}
123		*/
124		protected function getFilePath($path, $filter)
125		{
126		return $this->webRoot.'/'.$this->getFullPath($path, $filter);
127		}
128
129		/**
130		* {@inheritdoc}
131		*/
132		protected function getFileUrl($path, $filter)
133		{
134		return PathHelper::filePathToUrlPath($this->getFullPath($path, $filter));
135		}
136
137		/**
138		* @return string
139		*/
140		protected function getBaseUrl()
141		{
142		$port = '';
143	View Code Duplication	if ('https' === $this->requestContext->getScheme() && 443 !== $this->requestContext->getHttpsPort()) {
		0 ignored issues – show Duplication introduced 2019-07-17 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
144		$port = ":{$this->requestContext->getHttpsPort()}";
145		}
146
147	View Code Duplication	if ('http' === $this->requestContext->getScheme() && 80 !== $this->requestContext->getHttpPort()) {
		0 ignored issues – show Duplication introduced 2019-07-17 16:12 UTC by Report Bug Copy Issue Report Show Similar Issues like this This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
148		$port = ":{$this->requestContext->getHttpPort()}";
149		}
150
151		$baseUrl = $this->requestContext->getBaseUrl();
152		if ('.php' === mb_substr($this->requestContext->getBaseUrl(), -4)) {
153		$baseUrl = pathinfo($this->requestContext->getBaseurl(), PATHINFO_DIRNAME);
154		}
155		$baseUrl = rtrim($baseUrl, '/\\');
156
157		return sprintf('%s://%s%s%s',
158		$this->requestContext->getScheme(),
159		$this->requestContext->getHost(),
160		$port,
161		$baseUrl
162		);
163		}
164
165	View Code Duplication	private function getFullPath($path, $filter)
		0 ignored issues – show Duplication introduced 2019-03-20 17:43 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
166		{
167		// crude way of sanitizing URL scheme ("protocol") part
168		$path = str_replace('://', '---', $path);
169
170		return $this->cachePrefix.'/'.$filter.'/'.ltrim($path, '/');
171		}
172		}
173

liip / LiipImagineBundle

Issues (94)

Security Analysis not enabled

Imagine/Cache/Resolver/WebPathResolver.php (5 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like