Liip\ImagineBundle\Tests\DependencyInjection\Factory\Loader\FileSystemLoaderFactoryTest

Complexity

Total Complexity

7

Size/Duplication

Total Lines	91
Duplicated Lines	38.46 %

Coupling/Cohesion

Components	1
Dependencies	6

Importance

Changes	1
Bugs	0	Features	0

7 Methods

Rating	Name	Duplication	Size	Complexity
A	testCouldBeConstructedWithoutAnyArguments()	0	4	1
A	testImplementsLoaderFactoryInterface()	0	6	1
A	testReturnExpectedName()	0	6	1
A	testCreateLoaderDefinitionOnCreate()	18	18	1
A	testProcessCorrectlyOptionsOnAddConfiguration()	0	19	1
A	testAddDefaultOptionsIfNotSetOnAddConfiguration()	17	17	1
A	processConfigTree()	0	6	1

<?php

namespace Liip\ImagineBundle\Tests\DependencyInjection\Factory\Loader;

use Liip\ImagineBundle\DependencyInjection\Factory\Loader\FileSystemLoaderFactory;
use Symfony\Component\Config\Definition\Builder\TreeBuilder;
use Symfony\Component\Config\Definition\Processor;
use Symfony\Component\DependencyInjection\ContainerBuilder;

/**
 * @covers Liip\ImagineBundle\DependencyInjection\Factory\Loader\FileSystemLoaderFactory<extended>
 */
class FileSystemLoaderFactoryTest extends \Phpunit_Framework_TestCase
{
    public function testImplementsLoaderFactoryInterface()
    {
        $rc = new \ReflectionClass('Liip\ImagineBundle\DependencyInjection\Factory\Loader\FileSystemLoaderFactory');

        $this->assertTrue($rc->implementsInterface('Liip\ImagineBundle\DependencyInjection\Factory\Loader\LoaderFactoryInterface'));
    }

    public function testCouldBeConstructedWithoutAnyArguments()
    {
        new FileSystemLoaderFactory();
    }

    public function testReturnExpectedName()
    {
        $loader = new FileSystemLoaderFactory();

        $this->assertEquals('filesystem', $loader->getName());
    }

    public function testCreateLoaderDefinitionOnCreate()

This method seems to be duplicated in your project.

    {
        $container = new ContainerBuilder();

        $loader = new FileSystemLoaderFactory();

        $loader->create($container, 'theLoaderName', array(
            'data_root' => 'theDataRoot',
        ));

        $this->assertTrue($container->hasDefinition('liip_imagine.binary.loader.theloadername'));

        $loaderDefinition = $container->getDefinition('liip_imagine.binary.loader.theloadername');
        $this->assertInstanceOf('Symfony\Component\DependencyInjection\DefinitionDecorator', $loaderDefinition);
        $this->assertEquals('liip_imagine.binary.loader.prototype.filesystem', $loaderDefinition->getParent());

        $this->assertEquals('theDataRoot', $loaderDefinition->getArgument(2));
    }

    public function testProcessCorrectlyOptionsOnAddConfiguration()
    {
        $expectedDataRoot = 'theDataRoot';

        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('filesystem', 'array');

        $loader = new FileSystemLoaderFactory();
        $loader->addConfiguration($rootNode);

        $config = $this->processConfigTree($treeBuilder, array(
            'filesystem' => array(
                'data_root' => $expectedDataRoot,
            ),
        ));

        $this->assertArrayHasKey('data_root', $config);
        $this->assertEquals($expectedDataRoot, $config['data_root']);
    }

    public function testAddDefaultOptionsIfNotSetOnAddConfiguration()

This method seems to be duplicated in your project.

    {
        $expectedDataRoot = '%kernel.root_dir%/../web';

        $treeBuilder = new TreeBuilder();
        $rootNode = $treeBuilder->root('filesystem', 'array');

        $loader = new FileSystemLoaderFactory();
        $loader->addConfiguration($rootNode);

        $config = $this->processConfigTree($treeBuilder, array(
            'filesystem' => array(),
        ));

        $this->assertArrayHasKey('data_root', $config);
        $this->assertEquals($expectedDataRoot, $config['data_root']);
    }

    /**
     * @param TreeBuilder $treeBuilder
     * @param array       $configs
     *
     * @return array
     */
    protected function processConfigTree(TreeBuilder $treeBuilder, array $configs)
    {
        $processor = new Processor();

        return $processor->process($treeBuilder->buildTree(), $configs);
    }
}