ScaleFilterLoader::isImageProcessable() - Code Metrics - Inspection of "Merge pull request #787 from antoligy/list-depreca..." - liip/LiipImagineBundle - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( c2562a...15ecc0 )

by Lukas Kahwe

created 2016-09-19 07:34 UTC

ScaleFilterLoader::isImageProcessable() A

↳ Parent: ScaleFilterLoader

Complexity

Conditions	1
Paths	1

Size

Total Lines	4
Code Lines	2

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	4
c	0
b	0
f	0
rs	10
cc	1
eloc	2
nc	1
nop	1

<?php

namespace Liip\ImagineBundle\Imagine\Filter\Loader;

use Imagine\Filter\Basic\Resize;
use Imagine\Image\ImageInterface;
use Imagine\Image\Box;

/**
 * Scale filter.
 *
 * @author Devi Prasad <https://github.com/deviprsd21>
 */
class ScaleFilterLoader implements LoaderInterface
{
    /**
     * @var string
     */
    protected $dimensionKey;

    /**
     * @var string
     */
    protected $ratioKey;

    /**
     * @var bool
     */
    protected $absoluteRatio;

    public function __construct($dimensionKey = 'dim', $ratioKey = 'to', $absoluteRatio = true)
    {
        $this->dimensionKey = $dimensionKey;
        $this->ratioKey = $ratioKey;
        $this->absoluteRatio = $absoluteRatio;
    }

    /**
     * {@inheritdoc}
     */
    public function load(ImageInterface $image, array $options = array())
    {
        if (!isset($options[$this->dimensionKey]) && !isset($options[$this->ratioKey])) {
            throw new \InvalidArgumentException("Missing $this->dimensionKey or $this->ratioKey option.");
        }

        $size = $image->getSize();
        $origWidth = $size->getWidth();
        $origHeight = $size->getHeight();

        if (isset($options[$this->ratioKey])) {
            $ratio = $this->absoluteRatio ? $options[$this->ratioKey] : $this->calcAbsoluteRatio($options[$this->ratioKey]);
        } elseif (isset($options[$this->dimensionKey])) {
            $size = $options[$this->dimensionKey];
            $width = isset($size[0]) ? $size[0] : null;
            $height = isset($size[1]) ? $size[1] : null;

            $widthRatio = $width / $origWidth;
            $heightRatio = $height / $origHeight;

            if (null == $width || null == $height) {
                $ratio = max($widthRatio, $heightRatio);
            } else {
                $ratio = min($widthRatio, $heightRatio);
            }
        }

        if ($this->isImageProcessable($ratio)) {
            $filter = new Resize(new Box(round($origWidth * $ratio), round($origHeight * $ratio)));
function myFunction($a) {
    switch ($a) {
        case 'foo':
            $x = 1;
            break;

        case 'bar':
            $x = 2;
            break;
    }

    // $x is potentially undefined here.
    echo $x;
}

            return $filter->apply($image);
        }

        return $image;
    }

    protected function calcAbsoluteRatio($ratio)
    {
        return $ratio;
    }

    protected function isImageProcessable($ratio)
    {
        return true;
    }
}


1			<?php
2
3			namespace Liip\ImagineBundle\Imagine\Filter\Loader;
4
5			use Imagine\Filter\Basic\Resize;
6			use Imagine\Image\ImageInterface;
7			use Imagine\Image\Box;
8
9			/**
10			* Scale filter.
11			*
12			* @author Devi Prasad <https://github.com/deviprsd21>
13			*/
14			class ScaleFilterLoader implements LoaderInterface
15			{
16			/**
17			* @var string
18			*/
19			protected $dimensionKey;
20
21			/**
22			* @var string
23			*/
24			protected $ratioKey;
25
26			/**
27			* @var bool
28			*/
29			protected $absoluteRatio;
30
31			public function __construct($dimensionKey = 'dim', $ratioKey = 'to', $absoluteRatio = true)
32			{
33			$this->dimensionKey = $dimensionKey;
34			$this->ratioKey = $ratioKey;
35			$this->absoluteRatio = $absoluteRatio;
36			}
37
38			/**
39			* {@inheritdoc}
40			*/
41			public function load(ImageInterface $image, array $options = array())
42			{
43			if (!isset($options[$this->dimensionKey]) && !isset($options[$this->ratioKey])) {
44			throw new \InvalidArgumentException("Missing $this->dimensionKey or $this->ratioKey option.");
45			}
46
47			$size = $image->getSize();
48			$origWidth = $size->getWidth();
49			$origHeight = $size->getHeight();
50
51			if (isset($options[$this->ratioKey])) {
52			$ratio = $this->absoluteRatio ? $options[$this->ratioKey] : $this->calcAbsoluteRatio($options[$this->ratioKey]);
53			} elseif (isset($options[$this->dimensionKey])) {
54			$size = $options[$this->dimensionKey];
55			$width = isset($size[0]) ? $size[0] : null;
56			$height = isset($size[1]) ? $size[1] : null;
57
58			$widthRatio = $width / $origWidth;
59			$heightRatio = $height / $origHeight;
60
61			if (null == $width \|\| null == $height) {
62			$ratio = max($widthRatio, $heightRatio);
63			} else {
64			$ratio = min($widthRatio, $heightRatio);
65			}
66			}
67
68			if ($this->isImageProcessable($ratio)) {
69			$filter = new Resize(new Box(round($origWidth * $ratio), round($origHeight * $ratio)));
			0 ignored issues – show Bug introduced 2016-08-17 23:20 UTC by Report Bug Copy Issue Report The variable `$ratio` does not seem to be defined for all execution paths leading up to this point. If you define a variable conditionally, it can happen that it is not defined for all execution paths. Let’s take a look at an example: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } // $x is potentially undefined here. echo $x; } In the above example, the variable `$x` is defined if you pass “foo” or “bar” as argument for `$a`. However, since the `switch` statement has no default case statement, if you pass any other value, the variable `$x` would be undefined. Available Fixes Check for existence of the variable explicitly: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } if (isset($x)) { // Make sure it's always set. echo $x; } } Define a default value for the variable: function myFunction($a) { $x = ''; // Set a default which gets overridden for certain paths. switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; } echo $x; } Add a value for the missing path: function myFunction($a) { switch ($a) { case 'foo': $x = 1; break; case 'bar': $x = 2; break; // We add support for the missing case. default: $x = ''; break; } echo $x; } Loading history...
70
71			return $filter->apply($image);
72			}
73
74			return $image;
75			}
76
77			protected function calcAbsoluteRatio($ratio)
78			{
79			return $ratio;
80			}
81
82			protected function isImageProcessable($ratio)
83			{
84			return true;
85			}
86			}
87

liip / LiipImagineBundle

Push — master ( c2562a...15ecc0 )

ScaleFilterLoader::isImageProcessable() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like